pids: sys_getpgid: use rcu_read_lock() instead of tasklist_lock
PATCH 1/1 pids: sys_getpgid: use rcu_read_lock() instead of tasklist_lock
Convert sys_getpgid() to use rcu_read_lock() instead of tasklist_lock, make sure we also check the result of task_pgrp_vnr().
Signed-off-by Oleg Nesterov <[email protected]>
kernel/sys.c renamed from kernel/sys.c~2_GETPGID +5 -5
@@ -988,19 +988,19 @@ asmlinkage long sys_getpgid(pid_t pid)if (!pid)return task_pgrp_vnr (current);else { -int retval; +int retval =0 ;struct task_struct *p; -read_lock (&tasklist_lock); +rcu_read_lock (); p =find_task_by_vpid (pid); - retval = -ESRCH ;if (p) { retval =security_task_getpgid (p);if (!retval) retval =task_pgrp_vnr (p); } -read_unlock (&tasklist_lock); -return retval; +rcu_read_unlock (); + +return retval ?: -ESRCH ; } }