Skip to contentSkip to conversation

i2c: i2c-ibm_iic fast mode parm desc fixup.

PATCH In review Paul Mundt 2 participants 2 messages Mar 25, 2008 1 message not in the archive I2C subsystem host drivers

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 i2c: i2c-ibm_iic fast mode parm desc fixup.

Noticed this when grepping for fast mode module params, the i2c-ibm_iic driver was using a non-existent variable for MODULE_PARM_DESC. Fix it up to reflect what it's actually supposed to be describing.

---

 drivers/i2c/busses/i2c-ibm_iic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-ibm_iic.c +1 -1
index 7c7eb0c..22bb247 100644
@@ -55,7 +55,7 @@ MODULE_PARM_DESC(iic_force_poll, "Force polling mode");
 
 static int iic_force_fast;
 module_param(iic_force_fast, bool, 0);
-MODULE_PARM_DESC(iic_fast_poll, "Force fast mode (400 kHz)");
+MODULE_PARM_DESC(iic_force_fast, "Force fast mode (400 kHz)");
 
 #define DBG_LEVEL 0
 

_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi Paul,

Quoted 16 lines · Paul Mundt

Noticed this when grepping for fast mode module params, the i2c-ibm_iic driver was using a non-existent variable for MODULE_PARM_DESC. Fix it up to reflect what it's actually supposed to be describing.

---

 drivers/i2c/busses/i2c-ibm_iic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/i2c-ibm_iic.c +0 -0
index 7c7eb0c..22bb247 100644

drivers/i2c/busses/i2c-ibm_iic.c MODULE_PARM_DESC(iic_force_poll, "Force polling mode"); · line 61

Quoted 8 lines
drivers/i2c/busses/i2c-ibm_iic.c +1 -1
@@ -55,7 +55,7 @@ MODULE_PARM_DESC(iic_force_poll, "Force polling mode");
 
 static int iic_force_fast;
 module_param(iic_force_fast, bool, 0);
-MODULE_PARM_DESC(iic_fast_poll, "Force fast mode (400 kHz)");
+MODULE_PARM_DESC(iic_force_fast, "Force fast mode (400 kHz)");
 
 #define DBG_LEVEL 0
 

Good catch. Patch applied, thank you. It seems that it has been broken pretty much forever. I thought that building would fail in this case, but it seems not.

Signature · 6 lines
Jean Delvare

_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c