vfs patches
misc VFS fixes for 2.6.25. Please pull fromgit://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus
Shortlog:
Al Viro (5):
restore export of do_kern_mount()
sanitize hppfs
double dput() on failure exit in tiny-shmem
double iput() on failure exit in hugetlb
get stack footprint of pathname resolution back to relative sanity
Christoph Hellwig (1):
check for null vfsmount in dentry_open()
Dave Hansen (2):
hppfs pass vfsmount to dentry_open()
fix up new filp allocators
Jeff Mahoney (1):
reiserfs: eliminate private use of struct file in xattr
Diffstat:
fs/anon_inodes.c | 18 +- fs/file_table.c | 6 + fs/hppfs/hppfs_kern.c | 435 +++++++++++++++++++++++-------------------------- fs/hugetlbfs/inode.c | 2 +- fs/namei.c | 63 ++++---- fs/open.c | 12 ++ fs/pipe.c | 19 +- fs/reiserfs/xattr.c | 110 ++++--------- fs/super.c | 1 + mm/tiny-shmem.c | 2 + 10 files changed, 302 insertions(+), 366 deletions(-)
Quoted 3 lines · Al Viro
misc VFS fixes for 2.6.25. Please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/for-linus
Pulled.
And looking at the diffs, I see sequences like
dget(save.dentry); mntget(save.mnt); ... path_put(&save);
which looks very strange compared to the natural sequence:
path_get(&save); .. path_put(&save);
and yes, I realize the code was just moved (and the reason for the mixing is that the "path_put()" conversion was done much more aggressively, as the ordering matters), but I'm bringing this up in the hope somebody has the energy to clean things like up some day...
Linus
Quoted 7 lines · Linus Torvalds
dget(save.dentry); mntget(save.mnt); ... path_put(&save);which looks very strange compared to the natural sequence:
Quoted 8 lines
path_get(&save); .. path_put(&save);and yes, I realize the code was just moved (and the reason for the mixing is that the "
path_put()" conversion was done much more aggressively, as the ordering matters), but I'm bringing this up in the hope somebody has the energy to clean things like up some day...
*nod*
Keep in mind that there's a lot more coming post-.25; FWIW, there's another bunch of patches that probably ought to go before .25 (mount expiry stuff; I'll do a bit of reordering and probably ask to pull tomorrow).
The next couple of cycles is going to get interesting around fs/{namei,namespace,pnode,super,dentry}.c