DM644x: (2nd try) This adds support for theProdrive PMDRA board, based on a DM6441

PATCH New Pieter Voorthuijsen 4 participants 8 messages Mar 21, 2008 – Mar 26, 2008 Kbuild

lore

Share & tools

lore

Pieter Voorthuijsen

author

2008-03-21 11:28 UTC #0 lore raw

PATCH 1/1 DM644x: (2nd try) This adds support for theProdrive PMDRA board, based on a DM6441

2nd try, previous one was wrapped:
Double checked spaces and coding style...

Original message:

Hello,

This patch adds support for the new Prodrive PMDR-A board. It is based on the DaVinci DM6441 processor, has 256M DDR2, 8M NOR and 256M of NAND. (This requires the previous patch that removes board specific code from /cpu/arm926ejs/davinci)

Best regards,
Pieter

Pieter Voorthuijsen
Prodrive B.V.
Science Park Eindhoven
P.O. box 28030
5602 JA Eindhoven
The Netherlands

Email pieter.voorthuijsen at prodrive.nl
Tel: +31-40-2676258
Fax: +31-40-2676201
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-DM644x-This-adds-support-for-theProdrive-PMDRA-boar.patch
Type: application/octet-stream
Size: 20231 bytes
Desc: 0002-DM644x-This-adds-support-for-theProdrive-PMDRA-boar.patch
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080321/0be7fc9a/attachment.obj

Jean-Christophe PLAGNIOL-VILLARD

2008-03-22 13:38 UTC #1 lore raw

PATCH 1/1 DM644x: (2nd try) This adds support for theProdrive PMDRA board, based on a DM6441

Quoted 14 lines · Pieter Voorthuijsen

2nd try, previous one was wrapped:
Double checked spaces and coding style...
Original message:
Hello,
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */

Review

Quoted 3 lines

(quoted diff) +3 -0

+
+/* This code sets up the timing params for EMIF CE2 and CE3 which
+ * connect to NOR and NAND flash

Whitespace please remove

Quoted 1 line

+ */

Please use this style of comment
/*
* ....
* ....
*/

Quoted 1 line

+

^
Whitespace please remove

Quoted 10 lines

#include <config.h>
.globl dv_board_init
dv_board_init:
extern void timer_init(void);
extern int eth_hw_init(void);
extern phy_t phy;

please remove, only one emply line

Quoted 19 lines

/* Works on Always On power domain only (no PD argument) */ void lpsc_on(unsigned int id)
{
	/* Enable EMAC and AEMIF pins */
	REG(PINMUX0) = 0x80000c1f;

	/* Enable I2C pin Mux */
	REG(PINMUX1) |= (1 << 7);

	/* Set the Bus Priority Register to appropriate value */
	REG(VBPR) = 0x20;

	timer_init();

	return(0);
}
int misc_init_r (void)

Quoted 14 lines

{
	int		clk = 0;

	clk = ((REG(PLL2_PLLM) + 1) * 27) / ((REG(PLL2_DIV2) & 0x1f) + 1);

	printf ("ARM Clock : %dMHz\n", ((REG(PLL1_PLLM) + 1) * 27 ) / 2);
	printf ("DDR Clock : %dMHz\n", (clk / 2));

	if (!eth_hw_init())
		printf("ethernet init failed!\n");
	else
		printf("ETH PHY   : %s\n", phy.name);

please remove, only one emply line

Quoted 3 lines

	return(0);
}

Best Regards,
J.

Pieter Voorthuijsen

author

2008-03-25 09:28 UTC #2 lore raw

PATCH 1/1 DM644x: (2nd try) This adds support for theProdrivePMDRA board, based on a DM6441

Signed-off-by Pieter Voorthuijsen <[email protected]>

---
 Makefile                          |    3 +
 board/prodrive/pmdra/Makefile     |   52 ++++++++++
 board/prodrive/pmdra/board_init.S |   30 ++++++
 board/prodrive/pmdra/config.mk    |   39 ++++++++
 board/prodrive/pmdra/pmdra.c      |  190 +++++++++++++++++++++++++++++++++++++
 board/prodrive/pmdra/u-boot.lds   |   52 ++++++++++
 include/configs/pmdra.h           |  184 +++++++++++++++++++++++++++++++++++
 7 files changed, 550 insertions(+), 0 deletions(-)
 create mode 100644 board/prodrive/pmdra/Makefile
 create mode 100644 board/prodrive/pmdra/board_init.S
 create mode 100644 board/prodrive/pmdra/config.mk
 create mode 100644 board/prodrive/pmdra/pmdra.c
 create mode 100644 board/prodrive/pmdra/u-boot.lds
 create mode 100644 include/configs/pmdra.h

Makefile +3 -0

index 4fde699..77f3d24 100644
@@ -2375,6 +2375,9 @@ davinci_schmoogie_config :	unconfig
 davinci_sonata_config :	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm926ejs sonata davinci davinci
 
+pmdra_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm926ejs pmdra prodrive davinci
+
 omap1610inn_config \
 omap1610inn_cs0boot_config \
 omap1610inn_cs3boot_config \

board/prodrive/pmdra/Makefile new file +52 -0

52 lines not on this page · raw message

board/prodrive/pmdra/board_init.S new file +30 -0

new file mode 100644
index 0000000..0a8ee01
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2008 Prodrive B.V.
+ *
+ * Board-specific low level initialization code. Called at the very end
+ * of cpu/arm926ejs/davinci/lowlevel_init.S. Just returns if there is no
+ * initialization required.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+
+.globl	dv_board_init
+dv_board_init:
+
+	mov	pc, lr
+

board/prodrive/pmdra/config.mk new file +39 -0

new file mode 100644
index 0000000..aa89d0e
@@ -0,0 +1,39 @@
+#
+# (C) Copyright 2002
+# Gary Jennejohn, DENX Software Engineering, <[email protected]>
+# David Mueller, ELSOFT AG, <[email protected]>
+#
+# (C) Copyright 2003
+# Texas Instruments, <www.ti.com>
+# Swaminathan <[email protected]>
+#
+# Davinci EVM board (ARM925EJS) cpu
+# see http://www.ti.com/ for more information on Texas Instruments
+#
+# Davinci EVM has 1 bank of 256 MB DDR RAM
+# Physical Address:
+# 8000'0000 to 9000'0000
+#
+# Copyright (C) 2007 Sergey Kubushyn <[email protected]>
+#
+# Visioneering Corp. Sonata board (ARM926EJS) cpu
+#
+# Sonata board has 1 bank of 128 MB DDR RAM
+# Physical Address:
+# 8000'0000 to 8800'0000
+#
+# Razorstream, LLC. SCHMOOGIE board (ARM926EJS) cpu
+#
+# Schmoogie board has 1 bank of 128 MB DDR RAM
+# Physical Address:
+# 8000'0000 to 8800'0000
+#
+# Linux-Kernel is expected to be at 8000'8000, entry 8000'8000
+# (mem base + reserved)
+#
+# we load ourself to 8108 '0000
+#
+#
+
+#Provide at least 16MB spacing between us and the Linux Kernel image
+TEXT_BASE = 0x81080000

board/prodrive/pmdra/pmdra.c new file +190 -0

190 lines not on this page · raw message

board/prodrive/pmdra/u-boot.lds new file +52 -0

52 lines not on this page · raw message

include/configs/pmdra.h new file +184 -0

184 lines not on this page · raw message

Signature · 1 line

1.5.3.7

-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: zaterdag 22 maart 2008 14:38
To: Pieter Voorthuijsen
Cc: u-boot-users at lists.sourceforge.net
Subject: Re: [PATCH] DM644x: (2nd try) This adds support for theProdrivePMDRA board, based on a DM6441

Quoted 14 lines · Pieter Voorthuijsen

2nd try, previous one was wrapped:
Double checked spaces and coding style...
Original message:
Hello,
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */

Review

Quoted 3 lines

(quoted diff) +3 -0

+
+/* This code sets up the timing params for EMIF CE2 and CE3 which
+ * connect to NOR and NAND flash

Whitespace please remove

Quoted 1 line

+ */

Please use this style of comment
/*
* ....
* ....
*/

Quoted 1 line

+

^
Whitespace please remove

Quoted 10 lines

#include <config.h>
.globl dv_board_init
dv_board_init:
extern void timer_init(void);
extern int eth_hw_init(void);
extern phy_t phy;

please remove, only one emply line

Quoted 18 lines

/* Works on Always On power domain only (no PD argument) */ void lpsc_on(unsigned int id) {
	/* Enable EMAC and AEMIF pins */
	REG(PINMUX0) = 0x80000c1f;

	/* Enable I2C pin Mux */
	REG(PINMUX1) |= (1 << 7);

	/* Set the Bus Priority Register to appropriate value */
	REG(VBPR) = 0x20;

	timer_init();

	return(0);
}
int misc_init_r (void)

Quoted 14 lines

{
	int		clk = 0;

	clk = ((REG(PLL2_PLLM) + 1) * 27) / ((REG(PLL2_DIV2) & 0x1f) + 1);

	printf ("ARM Clock : %dMHz\n", ((REG(PLL1_PLLM) + 1) * 27 ) / 2);
	printf ("DDR Clock : %dMHz\n", (clk / 2));

	if (!eth_hw_init())
		printf("ethernet init failed!\n");
	else
		printf("ETH PHY   : %s\n", phy.name);

please remove, only one emply line

Quoted 3 lines

	return(0);
}

Best Regards,
J.

Wolfgang Denk

2008-03-25 12:42 UTC #3 lore raw

PATCH 1/1 DM644x: (2nd try) This adds support for theProdrivePMDRA board, based on a DM6441

A: Because it messes up the order in which people normally read text.

Q: Why is it such a bad thing?

A: Top-posting.

Q: What is the most annoying thing on usenet and in e-mail?

Quoted 1 line · In message <[email protected]> you…

Signed-off-by Pieter Voorthuijsen <[email protected]>

Your subject line (which will become part of the commit message) is seriously corrupted in terms of whitespace.

And the second most annoying thing is full-quoting, which you did again.

Please read http://www.netmeister.org/news/learn2quote.html before posting again, and please do NOT quote such stuff when posting patches.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A failure will not appear until a unit has passed final inspection.

Wolfgang Denk

2008-03-26 00:04 UTC #4 lore raw

PATCH 1/1 DM644x: (2nd try) This adds support for theProdrive PMDRA board, based on a DM6441

In reply to Pieter Voorthuijsen

Quoted 3 lines · In message <[email protected]> you…

2nd try, previous one was wrapped:
Double checked spaces and coding style...

Sorry, I know this must be frustrating to you, but...

Quoted 7 lines

Content-Type: application/octet-stream;
	name="0002-DM644x-This-adds-support-for-theProdrive-PMDRA-boar.patch"
Content-Transfer-Encoding: base64
Content-Description: 0002-DM644x-This-adds-support-for-theProdrive-PMDRA-boar.patch
Content-Disposition: attachment;
	filename="0002-DM644x-This-adds-support-for-theProdrive-PMDRA-boar.patch"

Quoted 5 lines

RnJvbSAzOTYyNTZiYmFkNjI2YTBhYWMzZTQ4YzhhMjVjODY1N2I0MjMyYzRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWV0ZXIgVm9vcnRodWlqc2VuIDxwaWV0ZXIudm9vcnRodWlq c2VuQHByb2RyaXZlLm5sPgpEYXRlOiBGcmksIDIxIE1hciAyMDA4IDExOjIxOjAzICswMTAwClN1 YmplY3Q6IFtQQVRDSF0gRE02NDR4OiBUaGlzIGFkZHMgc3VwcG9ydCBmb3IgdGhlUHJvZHJpdmUg UE1EUkEgYm9hcmQsIGJhc2VkIG9uIGEgRE02NDQxCgpTaWduZWQtb2ZmLWJ5OiBQaWV0ZXIgVm9v

...

Please send the patch inlune as plain text.

Do NOT use base64 encoding, do not use MIME attachments.

As had been mentioned a couple times before, it is strongly recommended that you use git-send-email to post the patches.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Bus error -- please leave by the rear door.

Pieter Voorthuijsen

author

2008-03-26 07:18 UTC #5 lore raw

PATCH 1/1 DM644x: (2nd try) This adds support for theProdrive PMDRA board, based on a DM6441

Quoted 10 lines

-----Original Message-----
From: wd at denx.de [mailto:wd at denx.de]
In message <[email protected]>
Quoted 3 lines · you
2nd try, previous one was wrapped:
Double checked spaces and coding style...
Sorry, I know this must be frustrating to you, but...

Yes it is..

Quoted 27 lines

Quoted 3 lines
Content-Type: application/octet-stream;
name="0002-DM644x-This-adds-support-for-theProdrive-PMDRA-boar.patch"
Quoted 5 lines
Content-Transfer-Encoding: base64 Content-Description:
0002-DM644x-This-adds-support-for-theProdrive-PMDRA-boar.patch
Content-Disposition: attachment;
filename="0002-DM644x-This-adds-support-for-theProdrive-PMDRA- boar.patch"
Quoted 2 lines
RnJvbSAzOTYyNTZiYmFkNjI2YTBhYWMzZTQ4YzhhMjVjODY1N2I0MjMyYzRkIE1vbiBTZX
Quoted 2 lines
AgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWV0ZXIgVm9vcnRodWlqc2VuIDxwaWV0ZXIudm9vcn
Quoted 2 lines
RodWlq
c2VuQHByb2RyaXZlLm5sPgpEYXRlOiBGcmksIDIxIE1hciAyMDA4IDExOjIxOjAzICswMT
Quoted 2 lines
AwClN1
YmplY3Q6IFtQQVRDSF0gRE02NDR4OiBUaGlzIGFkZHMgc3VwcG9ydCBmb3IgdGhlUHJvZH
Quoted 2 lines
JpdmUg
UE1EUkEgYm9hcmQsIGJhc2VkIG9uIGEgRE02NDQxCgpTaWduZWQtb2ZmLWJ5OiBQaWV0ZX
Quoted 1 line
IgVm9v

Quoted 8 lines

...
Please send the patch inlune as plain text.
Do NOT use base64 encoding, do not use MIME attachments.
As had been mentioned a couple times before, it is strongly recommended that you use git-send-email to post the patches.

This one already got resend as plain text. I'm trying to get git-send-email to work. Is there an easy way to test this without spamming the mailing list?

Best regards, Pieter

Dirk Behme

2008-03-26 07:34 UTC #6 lore raw

PATCH 1/1 DM644x: (2nd try) This adds support for theProdrive PMDRA board, based on a DM6441

Quoted 58 lines · Pieter Voorthuijsen

Quoted 10 lines
-----Original Message-----
From: wd at denx.de [mailto:wd at denx.de]
In message <[email protected]>
Quoted 2 lines · you
2nd try, previous one was wrapped:
Double checked spaces and coding style...
Sorry, I know this must be frustrating to you, but...
Yes it is..
Quoted 43 lines
Quoted 2 lines
Content-Type: application/octet-stream;
name="0002-DM644x-This-adds-support-for-theProdrive-PMDRA-boar.patch"
Quoted 5 lines
Content-Transfer-Encoding: base64 Content-Description:
0002-DM644x-This-adds-support-for-theProdrive-PMDRA-boar.patch
Content-Disposition: attachment;
filename="0002-DM644x-This-adds-support-for-theProdrive-PMDRA- boar.patch"
Quoted 1 line
RnJvbSAzOTYyNTZiYmFkNjI2YTBhYWMzZTQ4YzhhMjVjODY1N2I0MjMyYzRkIE1vbiBTZX
Quoted 2 lines
AgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaWV0ZXIgVm9vcnRodWlqc2VuIDxwaWV0ZXIudm9vcn
Quoted 2 lines
RodWlq
c2VuQHByb2RyaXZlLm5sPgpEYXRlOiBGcmksIDIxIE1hciAyMDA4IDExOjIxOjAzICswMT
Quoted 2 lines
AwClN1
YmplY3Q6IFtQQVRDSF0gRE02NDR4OiBUaGlzIGFkZHMgc3VwcG9ydCBmb3IgdGhlUHJvZH
Quoted 2 lines
JpdmUg
UE1EUkEgYm9hcmQsIGJhc2VkIG9uIGEgRE02NDQxCgpTaWduZWQtb2ZmLWJ5OiBQaWV0ZX
Quoted 1 line
IgVm9v
...
Please send the patch inlune as plain text.

Quoted 8 lines

Quoted 4 lines
Do NOT use base64 encoding, do not use MIME attachments.
As had been mentioned a couple times before, it is strongly recommended that you use git-send-email to post the patches.
This one already got resend as plain text. I'm trying to get git-send-email to work. Is there an easy way to test this without spamming the mailing list?

First --dry-run. And if this is fine, sending them to yourself? Use your own mail address in --to instead of list address. Then, if everything is fine, add list to --too.

Dirk

Wolfgang Denk

2008-03-26 07:34 UTC #7 lore raw

PATCH 1/1 DM644x: (2nd try) This adds support for theProdrive PMDRA board, based on a DM6441

In reply to Pieter Voorthuijsen

Quoted 2 lines · In message <[email protected]> you…

This one already got resend as plain text. I'm trying to get git-send-email to

Sorry, I missed this one.

Quoted 1 line

work. Is there an easy way to test this without spamming the mailing list?

Send it to yourself? Or feel free to send it to my address, and I'll try to help.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Insufficient facts always invite danger.
	-- Spock, "Space Seed", stardate 3141.9