Skip to contentSkip to conversation

gcc-4.3 considers unaligned accesses on X86 as undefined

DISCUSSION Török Edwin 4 participants 4 messages Mar 25, 2008 – Mar 26, 2008

lore
Share & tools
lore
#0 lore raw

Hello x86 architecture maintainers,

GCC-4.3 now considers that it is undefined behaviour to access memory through an int* that is not aligned to sizeof(int).
At -O3 it generates vectorized code that _relies_ on the fact that pointers are always aligned (unless you use packed attributes, etc.), and the resulting code crashes if the pointer is unaligned. (-O3 -msse on 32-bit, and simply -O3 on 64-bit since -msse is default) See this gcc bugreport: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35653
[I do not really agree with this sudden change, because unaligned accesses have always been possible on x86, but the C99 standard does say it is undefined behaviour ...]

I thought to inform you of this change in gcc's behaviour, because include/asm-x86/unaligned.h is no longer safe in the above context, especially that it is being used in a loop:
http://lxr.linux.no/linux/net/bluetooth/bnep/core.c#L153

P.S.: I only compile my kernels with -O2, so I don't know if it actually crashes or not at -O3.

Best regards,
--Edwin

#1 lore raw
Quoted 13 lines · Török Edwin

Hello x86 architecture maintainers,

GCC-4.3 now considers that it is undefined behaviour to access memory through an int* that is not aligned to sizeof(int).
At -O3 it generates vectorized code that _relies_ on the fact that pointers are always aligned (unless you use packed attributes, etc.), and the resulting code crashes if the pointer is unaligned. (-O3 -msse on 32-bit, and simply -O3 on 64-bit since -msse is default) See this gcc bugreport: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35653
[I do not really agree with this sudden change, because unaligned accesses have always been possible on x86, but the C99 standard does say it is undefined behaviour ...]

Quoted 8 lines

I thought to inform you of this change in gcc's behaviour, because include/asm-x86/unaligned.h is no longer safe in the above context, especially that it is being used in a loop:
http://lxr.linux.no/linux/net/bluetooth/bnep/core.c#L153

P.S.: I only compile my kernels with -O2, so I don't know if it actually crashes or not at -O3.

Generating vectorized code in the kernel is death anyway, so I don't think the change in alignment is an issue. We CANNOT ALLOW vectorized code in the kernel under any circumstances (well, except when surrounded by the appropriate protection constructs.)

-hpa

#2 lore raw
In reply to Török Edwin
Quoted 5 lines · On Tue, 25 Mar 2008 22:51:09 +0200 Török Edwin <[email protected]> wrote:

Hello x86 architecture maintainers,

GCC-4.3 now considers that it is undefined behaviour to access memory through an int* that is not aligned to sizeof(int).
At -O3 it generates vectorized code

FPU/MMX/SSE are not available or usable for the kernel anyway fortunately in this case.

Alan

#3 lore raw
In reply to Török Edwin
Quoted 4 lines · Török Edwin

At -O3 it generates vectorized code that _relies_ on the fact that pointers are always aligned (unless you use packed attributes, etc.), and the resulting code crashes if the pointer is unaligned. (-O3 -msse on 32-bit, and simply -O3 on 64-bit since -msse is default)

The 2.6 kernel disables SSE and MMX code generation explicitely. 2.4 should be also safe unless someone misguided recompiles it with -O3.

-Andi