x86: GEODE: add missing module.h include

PATCH New Andres Salomon 1 participant 1 message Mar 26, 2008 2 messages not in the archive x86

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andres Salomon

author

2008-03-26 18:12 UTC #2 lore raw

PATCH 1/1 x86: GEODE: add missing module.h include

Quoted 17 lines · On Wed, 26 Mar 2008 11:56:22 -0600 Jordan Crouse <[email protected]> wrote:

Quoted 16 lines · Stefan Pfetzing
Hello Jordan,
I just tried to build your geodwdt driver for the geode watchdog. Therefore I pulled your repository from http://git.infradead.org/geode.git (or more, the git url).
I tried to build the geodewdt driver as a module - which didn't work, and it failed with the same problem as earlier mentioned on lkmk [1]. I also checked the fix [2], but that seems to be already in your (or linus) tree - and so I'm unsure what the problem is.
[1] http://kerneltrap.org/mailarchive/linux-kernel/2008/2/17/884074
[2] http://kerneltrap.org/mailarchive/linux-kernel/2008/2/17/884174
Building directly into the kernel seems to work.

Quoted 9 lines

Quoted 1 line
Maybe you have some idea?
Hmm - that is strange. Exporting the symbols should work. I recommend starting over with a clean tree.
CCing Andres - any thoughts?
Jordan

Er, yeah. The patch below should fix it. This should probably go into 2.6.25.

Oops, EXPORT_SYMBOL_GPL wasn't being declared due to this header being missing.

Signed-off-by Andres Salomon <[email protected]>

---
 arch/x86/kernel/mfgpt_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/x86/kernel/mfgpt_32.c +1 -0

index 3f0f603..2c0e6b5 100644
@@ -30,6 +30,7 @@
 
 #include <linux/kernel.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <asm/geode.h>
 
 static struct mfgpt_timer_t {

Signature · 1 line

1.5.3.7