b44: Truncate PHY address

PATCH New Michael Buesch 1 participant 1 message Mar 26, 2008

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Michael Buesch

author

2008-03-26 14:04 UTC #0 lore raw

PATCH 1/1 b44: Truncate PHY address

Some ROMs on embedded devices store incorrect values for the PHY address of the ethernet device.
It looks like the number is sign-extended.
Truncate the value by applying the PHY-address mask to it. The patch was tested on a bcm47xx embedded system (where the bug triggers) and a bcm4400 PCI card.

Signed-off-by Michael Buesch <[email protected]>

---

This patch is applied to the netdev tree. Commit is 5ea79631c0c47d28831a0635e8af9da539d449cd

drivers/net/b44.c +5 -0

Index: linux-2.6.24.3/drivers/net/b44.c
===================================================================
@@ -2066,6 +2066,11 @@ static int __devinit b44_get_invariants(
 		addr = sdev->bus->sprom.r1.et0mac;
 		bp->phy_addr = sdev->bus->sprom.r1.et0phyaddr;
 	}
+	/* Some ROMs have buggy PHY addresses with the high
+	 * bits set (sign extension?). Truncate them to a
+	 * valid PHY address. */
+	bp->phy_addr &= 0x1F;
+
 	memcpy(bp->dev->dev_addr, addr, 6);
 
 	if (!is_valid_ether_addr(&bp->dev->dev_addr[0])){

Signature · 1 line

Greetings Michael.