Skip to contentSkip to conversation

3W RAID drivers: memset not needed in probe

PATCH In review [email protected] 1 participant 1 message Mar 28, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 3/17 3W RAID drivers: memset not needed in probe

From: Denis Cheng <[email protected]>

The memory return from scsi_host_alloc is alloced by kzalloc, which is already zero initilized, so memset not needed.

---

 drivers/scsi/3w-9xxx.c |    2 --
 drivers/scsi/3w-xxxx.c |    2 --
 2 files changed, 4 deletions(-)
drivers/scsi/3w-9xxx.c renamed from drivers/scsi/3w-9xxx.c~3w-raid-drivers-memset-not-needed-in-probe +0 -2
diff -puN drivers/scsi/3w-9xxx.c~3w-raid-drivers-memset-not-needed-in-probe drivers/scsi/3w-9xxx.c
@@ -2026,8 +2026,6 @@ static int __devinit twa_probe(struct pc
 	}
 	tw_dev = (TW_Device_Extension *)host->hostdata;
 
-	memset(tw_dev, 0, sizeof(TW_Device_Extension));
-
 	/* Save values to device extension */
 	tw_dev->host = host;
 	tw_dev->tw_pci_dev = pdev;
drivers/scsi/3w-xxxx.c renamed from drivers/scsi/3w-xxxx.c~3w-raid-drivers-memset-not-needed-in-probe +0 -2
diff -puN drivers/scsi/3w-xxxx.c~3w-raid-drivers-memset-not-needed-in-probe drivers/scsi/3w-xxxx.c
@@ -2287,8 +2287,6 @@ static int __devinit tw_probe(struct pci
 	}
 	tw_dev = (TW_Device_Extension *)host->hostdata;
 
-	memset(tw_dev, 0, sizeof(TW_Device_Extension));
-
 	/* Save values to device extension */
 	tw_dev->host = host;
 	tw_dev->tw_pci_dev = pdev;

_