SPARC: CFI flash_read64 is defined a weak function.
PATCH 1/1 SPARC: CFI flash_read64 is defined a weak function.
Hello Wolfgang and Stefan,
SPARC has implemented __raw_readq, it reads 64-bit from any 32-bit address. SPARC CPUs implement flash_read64 which calls __raw_readq.
For current SPARC architectures (LEON2 and LEON3) each read from the FLASH must lead to a cache miss. This is because FLASH can not be set non-cacheable since program code resides there, and alternatively disabling cache is poor from performance view, or doing a cache flush between each read is even poorer.
Forcing a cache miss on a SPARC is done by a special instruction "lda" - load alternative space, the alternative space number (ASI) is processor implementation spcific and can be found by including <asm/processor.h>.
This patch is also available at ftp://ftp.gaisler.com/gaisler.com/uboot/patches.
Best Regards,
Daniel Hellstrom
--- drivers/mtd/cfi_flash.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/mtd/cfi_flash.c +3 -1
@@ -239,12 +239,14 @@ static u32 flash_read32(void *addr)return __raw_readl (addr); } -static u64 flash_read64 (void *addr) +static u64 __flash_read64 (void *addr) {/* No architectures currently implement __raw_readq() */ return *(volatile u64 *)addr; } +u64 flash_read64 (void *addr)__attribute__((weak,alias ("__flash_read64" ))); +/*----------------------------------------------------------------------- */ #if defined(CFG_ENV_IS_IN_FLASH ) || defined(CFG_ENV_ADDR_REDUND ) || (CFG_MONITOR_BASE >=CFG_FLASH_BASE )
Signature · 1 line
1.5.4
PATCH 1/1 SPARC: CFI flash_read64 is defined a weak function.
Quoted 9 lines · Daniel Hellstrom
SPARC has implemented
__raw_readq, it reads 64-bit from any 32-bit address. SPARC CPUs implementflash_read64which calls__raw_readq.For current SPARC architectures (LEON2 and LEON3) each read from the FLASH must lead to a cache miss. This is because FLASH can not be set non-cacheable since program code resides there, and alternatively disabling cache is poor from performance view, or doing a cache flush between each read is even poorer.
Quoted 3 lines
Forcing a cache miss on a SPARC is done by a special instruction "lda" - load alternative space, the alternative space number (ASI) is processor implementation spcific and can be found by including <
asm/processor.h>.
Added to cfi-flash repository. Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================