New VID/PID pair for i2c-tiny-usb
Subsystems (2)
PATCH 1/1 New VID/PID pair for i2c-tiny-usb
I have recently bought some USB PIDs from EZPrototypes for my USB projects and one will be for the i2c-tiny-usb. I have not yet started to use the new one in the official i2c-tiny-usb firmware since i think it makes sense to get the change into the kernel before releasing a modified firmware.
This patch adds support for the EZPrototypes USB vid/pid pair used in later i2c-tiny-usb firmware versions (avrusb v1.06 and up, usbtiny v2.06 and up).
--- linux-2.6.24.3.orig/drivers/i2c/busses/i2c-tiny-usb.c 2008-02-26
01:20:20.000000000 +0100
+++ linux-2.6.24.3/drivers/i2c/busses/i2c-tiny-usb.c 2008-03-24
10:27:13.000000000 +0100
@@ -131,11 +131,13 @@
/* ----- begin of usb layer ---------------------------------------------- */
-/* The usb i2c interface uses a vid/pid pair donated by */ -/* Future Technology Devices International Ltd. */
+/* Initially the usb i2c interface used a vid/pid pair donated by */ +/* Future Technology Devices International Ltd., later a pair was */ +/* bought from EZPrototypes */
static struct usb_device_id i2c_tiny_usb_table [] = {
- { USB_DEVICE(0x0403, 0xc631) },
- { } /* Terminating entry */
+ { USB_DEVICE(0x0403, 0xc631) }, /* FTDI */
+ { USB_DEVICE(0x1c40, 0x0534) }, /* EZPrototypes */
+ { } /* Terminating entry */
};
MODULE_DEVICE_TABLE(usb, i2c_tiny_usb_table);
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi Till,
Quoted 8 lines · Till Harbaum / Lists
I have recently bought some USB PIDs from EZPrototypes for my USB projects and one will be for the i2c-tiny-usb. I have not yet started to use the new one in the official i2c-tiny-usb firmware since i think it makes sense to get the change into the kernel before releasing a modified firmware.
This patch adds support for the EZPrototypes USB vid/pid pair used in later i2c-tiny-usb firmware versions (avrusb v1.06 and up, usbtiny v2.06 and up).
Quoted 6 lines
Signed-off-by Till Harbaum <[email protected]>---
linux-2.6.24.3.orig/drivers/i2c/busses/i2c-tiny-usb.c2008-02-26
01:20:20.000000000 +0100
+++linux-2.6.24.3/drivers/i2c/busses/i2c-tiny-usb.c2008-03-24
10:27:13.000000000 +0100
Note: your e-mail client is wrapping long lines -> patch doesn't apply.
Review line 136
Quoted 9 lines
(quoted diff) +3
-2@@ -131,11 +131,13 @@ /* ----- begin of usb layer ---------------------------------------------- */ -/* The usb i2c interface uses a vid/pid pair donated by */ -/* Future Technology Devices International Ltd. */ +/* Initially the usb i2c interface used a vid/pid pair donated by */ +/* Future Technology Devices International Ltd., later a pair was */ +/* bought from EZPrototypes */
Please use a single /* */ pair for multi-line comments.
Review line 143
Quoted 9 lines
(quoted diff) +3
-2static struct usb_device_id i2c_tiny_usb_table [] = { - { USB_DEVICE(0x0403, 0xc631) }, - { } /* Terminating entry */ + { USB_DEVICE(0x0403, 0xc631) }, /* FTDI */ + { USB_DEVICE(0x1c40, 0x0534) }, /* EZPrototypes */ + { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, i2c_tiny_usb_table);
Maybe I'm missing something obvious, but if you already have a device ID, what's the point of switching to another? The original ID is not going to be deprecated and/or used for something else, is it?
Signature · 6 lines
Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi,
Am Mittwoch 26 März 2008 schrieb Jean Delvare:
Quoted 1 line
Note: your e-mail client is wrapping long lines -> patch doesn't apply.
I thought i've verified that, but obviously it happened anyway.
Quoted 1 line
Please use a single /* */ pair for multi-line comments.
Ok
Quoted 3 lines
Maybe I'm missing something obvious, but if you already have a device ID, what's the point of switching to another? The original ID is not going to be deprecated and/or used for something else, is it?
The original id was donated by ftdi without stating anywhere that the id has to be used with their products. So i used it for the i2c-tiny-usb which obviously isn't based on a ftdi chipset. I've been told that ftdi has changed that policy lately. While i don't expect them to actually ask me not to use their id without using the chips i thought it was clever to switch to an id i've explicitely bought to avoid future problems with ftdis new policies. I'll change the id from the ftdi ones to the ones i recently bought on all my projects. Just to avoid future problems as early as possible.
Does this make sense?
Updated patch will follow.
Regards,
Till
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi Till,
Quoted 19 lines · Till Harbaum / Lists
Am Mittwoch 26 März 2008 schrieb Jean Delvare:
Quoted 1 line
Note: your e-mail client is wrapping long lines -> patch doesn't apply.
I thought i've verified that, but obviously it happened anyway.
Quoted 1 line
Please use a single /* */ pair for multi-line comments.
Ok
Quoted 3 lines
Maybe I'm missing something obvious, but if you already have a device ID, what's the point of switching to another? The original ID is not going to be deprecated and/or used for something else, is it?
The original id was donated by ftdi without stating anywhere that the id has to be used with their products. So i used it for the i2c-tiny-usb which obviously isn't based on a ftdi chipset. I've been told that ftdi has changed that policy lately. While i don't expect them to actually ask me not to use their id without using the chips i thought it was clever to switch to an id i've explicitely bought to avoid future problems with ftdis new policies. I'll change the id from the ftdi ones to the ones i recently bought on all my projects. Just to avoid future problems as early as possible.
Quoted 1 line
Does this make sense?
Yes it does, thanks for clarifying. Please send an updated patch and I'll apply it.
Quoted 1 line
Updated patch will follow.
Do you plan to phase out the old VID/PID pair? If so, I'll have to send you back my i2c-tiny-usb device for a firmware update.
Signature · 6 lines
Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi,
Am Sonntag 30 März 2008 schrieb Jean Delvare:
Quoted 4 lines
Quoted 1 line
Does this make sense?
Yes it does, thanks for clarifying. Please send an updated patch and I'll apply it.
Please find a new patch attached.
Quoted 2 lines
Do you plan to phase out the old VID/PID pair? If so, I'll have to send you back my i2c-tiny-usb device for a firmware update.
Nothing will change for people using the old vid/pid pair as the driver still supports that and i don't think there's a reason to also remove the old vid/pid pair from the driver. But since you don't have the latest firmware, you might of course return your device anyway to get it updated. It'll then be detected correctly if it's plugged in at boot time.
Till
So here we go:
This patch adds support for the EZPrototypes USB vid/pid pair used in later i2c-tiny-usb firmware versions (avrusb v1.06 and up, usbtiny v2.06 and up).
drivers/i2c/busses/i2c-tiny-usb.c +8 -4
@@ -131,11 +131,15 @@/* ----- begin of usb layer ---------------------------------------------- */ -/* The usb i2c interface uses a vid/pid pair donated by */ -/* Future Technology Devices International Ltd. */ +/* +* Initially the usb i2c interface uses a vid/pid pair donated by +* Future Technology Devices International Ltd., later a pair was +* bought from EZPrototypes +*/ static struct usb_device_id i2c_tiny_usb_table [] = { - {USB_DEVICE (0x0403 ,0xc631 ) }, - { }/* Terminating entry */ + {USB_DEVICE (0x0403 ,0xc631 ) },/* FTDI */ + {USB_DEVICE (0x1c40 ,0x0534 ) },/* EZPrototypes */ + { }/* Terminating entry */ };MODULE_DEVICE_TABLE (usb, i2c_tiny_usb_table);
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
A message that is not in the archive (sent off-list or not yet received): [email protected]
Jean Delvare
AppliedQuoted 1 line · Till Harbaum / Lists
Please find a new patch attached.
Applied, thanks.
Signature · 6 lines
Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c