Skip to contentSkip to conversation

Remove empty function from arch/arm/mach-pxa/trizeps4.c

PATCH In review Andrey Valyaev 2 participants 2 messages Mar 31, 2008

Subsystems (4)
Arm (32-bit) Arm sub-architectures Kernel janitors PXA2xx/PXA3xx support
lore
Share & tools
lore

Andrey Valyaev

author
#0 lore raw

PATCH 1/1 Remove empty function from arch/arm/mach-pxa/trizeps4.c

Remove empty function from arch/arm/mach-pxa/trizeps4.c It's valid Janitor patch?

 trizeps4.c |    6 ------
 1 file changed, 6 deletions(-)

========

arch/arm/mach-pxa/trizeps4.c +0 -6
index f207fcd..5df658f 100644
@@ -333,15 +333,9 @@ static int trizeps4_ohci_init(struct device *dev)
        return 0;
 }
 
-static void trizeps4_ohci_exit(struct device *dev)
-{
-       ;
-}
-
 static struct pxaohci_platform_data trizeps4_ohci_platform_data = {
        .port_mode      = PMM_PERPORT_MODE,
        .init           = trizeps4_ohci_init,
-       .exit           = trizeps4_ohci_exit,
 };
 
 static struct map_desc trizeps4_io_desc[] __initdata = {

========

Signature · 1 line
	Andrey Valyaev <[email protected]>
#1 lore raw
Quoted 2 lines · Andrey Valyaev

Remove empty function from arch/arm/mach-pxa/trizeps4.c It's valid Janitor patch?

Does anyone call pxaohci_platform_data->exit unconditionally assuming it is always present?

Quoted 24 lines
 trizeps4.c |    6 ------
 1 file changed, 6 deletions(-)

========

arch/arm/mach-pxa/trizeps4.c +0 -6
index f207fcd..5df658f 100644
@@ -333,15 +333,9 @@ static int trizeps4_ohci_init(struct device *dev)
        return 0;
 }
 
-static void trizeps4_ohci_exit(struct device *dev)
-{
-       ;
-}
-
 static struct pxaohci_platform_data trizeps4_ohci_platform_data = {
        .port_mode      = PMM_PERPORT_MODE,
        .init           = trizeps4_ohci_init,
-       .exit           = trizeps4_ohci_exit,
 };
 
 static struct map_desc trizeps4_io_desc[] __initdata = {
Quoted 5 lines

========

Signature · 1 line
	Andrey Valyaev <[email protected]>

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed