Skip to contentSkip to conversation

fix comments in sound/core.h (fwd)

PATCH Applied Pavel Machek 4 participants 6 messages Apr 1, 2008 – Apr 21, 2008 Sound

lore
Share & tools
lore
#0 lore raw

Do we have sound maintainers? Noone replies on trivial patches :-(.

Pavel

----- Forwarded message from Pavel Machek <[email protected]> -----

From: Pavel Machek <[email protected]>
To: [email protected], kernel list <[email protected]>,
Trivial patch monkey <[email protected]>, [email protected]
Subject: fix comments in sound/core.h
X-Warning: Reading this can be dangerous to your mental health.

Two sentences seem to be spliced into one in comment, fix that and fix english. Also fix codingstyle.

include/sound/core.h +3 -3
index 4fc0235..452000d 100644
@@ -310,7 +310,7 @@ int snd_card_file_add(struct snd_card *c
 int snd_card_file_remove(struct snd_card *card, struct file *file);
 
 #ifndef snd_card_set_dev
-#define snd_card_set_dev(card,devptr) ((card)->dev = (devptr))
+#define snd_card_set_dev(card, devptr) ((card)->dev = (devptr))
 #endif
 
 /* device.c */
@@ -373,7 +373,7 @@ #ifdef CONFIG_SND_VERBOSE_PRINTK
  * snd_printd - debug printk
  * @fmt: format string
  *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
  * Ignored when CONFIG_SND_DEBUG is not set.
  */
 #define snd_printd(fmt, args...) \
@@ -417,7 +417,7 @@ #ifdef CONFIG_SND_DEBUG_DETECT
  * snd_printdd - debug printk
  * @format: format string
  *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
  * Ignored when CONFIG_SND_DEBUG_DETECT is not set.
  */
 #define snd_printdd(format, args...) snd_printk(format, ##args)
Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


----- End forwarded message -----

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
maintainer Applied
#1 lore raw
Quoted 1 line · Pavel Machek

Do we have sound maintainers? Noone replies on trivial patches :-(.

Applied to ALSA repository. Thanks.

Jaroslav

Quoted 57 lines

----- Forwarded message from Pavel Machek <[email protected]> -----

From: Pavel Machek <[email protected]>
To: [email protected], kernel list <[email protected]>,
Trivial patch monkey <[email protected]>, [email protected]
Subject: fix comments in sound/core.h
X-Warning: Reading this can be dangerous to your mental health.

Two sentences seem to be spliced into one in comment, fix that and fix english. Also fix codingstyle.

include/sound/core.h +3 -3
index 4fc0235..452000d 100644
@@ -310,7 +310,7 @@ int snd_card_file_add(struct snd_card *c
 int snd_card_file_remove(struct snd_card *card, struct file *file);
 
 #ifndef snd_card_set_dev
-#define snd_card_set_dev(card,devptr) ((card)->dev = (devptr))
+#define snd_card_set_dev(card, devptr) ((card)->dev = (devptr))
 #endif
 
 /* device.c */
@@ -373,7 +373,7 @@ #ifdef CONFIG_SND_VERBOSE_PRINTK
  * snd_printd - debug printk
  * @fmt: format string
  *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
  * Ignored when CONFIG_SND_DEBUG is not set.
  */
 #define snd_printd(fmt, args...) \
@@ -417,7 +417,7 @@ #ifdef CONFIG_SND_DEBUG_DETECT
  * snd_printdd - debug printk
  * @format: format string
  *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
  * Ignored when CONFIG_SND_DEBUG_DETECT is not set.
  */
 #define snd_printdd(format, args...) snd_printk(format, ##args)
Signature · 10 lines
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


----- End forwarded message -----

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.

#2 lore raw
Quoted 5 lines · Jaroslav Kysela
Quoted 1 line · Pavel Machek

Do we have sound maintainers? Noone replies on trivial patches :-(.

Applied to ALSA repository. Thanks.

There should be queue of few more similar patches (this was first resend)... will you process them, or should I resend?
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw
In reply to Pavel Machek

Hi Pavel,

I've been on vacation (a sort of honeymoon) until April 11. So I cannot work on your patches right now. Sorry for inconvenience.

Takashi

Quoted 62 lines · Pavel Machek

Do we have sound maintainers? Noone replies on trivial patches :-(.

Pavel

----- Forwarded message from Pavel Machek <[email protected]> -----

From: Pavel Machek <[email protected]>
To: [email protected], kernel list <[email protected]>,
Trivial patch monkey <[email protected]>, [email protected]
Subject: fix comments in sound/core.h
X-Warning: Reading this can be dangerous to your mental health.

Two sentences seem to be spliced into one in comment, fix that and fix english. Also fix codingstyle.

include/sound/core.h +3 -4
index 4fc0235..452000d 100644
@@ -310,7 +310,7 @@ int snd_card_file_add(struct snd_card *c
 int snd_card_file_remove(struct snd_card *card, struct file *file);
 
 #ifndef snd_card_set_dev
-#define snd_card_set_dev(card,devptr) ((card)->dev = (devptr))
+#define snd_card_set_dev(card, devptr) ((card)->dev = (devptr))
 #endif
 
 /* device.c */
@@ -373,7 +373,7 @@ #ifdef CONFIG_SND_VERBOSE_PRINTK
 * snd_printd - debug printk
 * @fmt: format string
 *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
 * Ignored when CONFIG_SND_DEBUG is not set.
 */
 #define snd_printd(fmt, args...) \
@@ -417,7 +417,7 @@ #ifdef CONFIG_SND_DEBUG_DETECT
 * snd_printdd - debug printk
 * @format: format string
 *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
 * Ignored when CONFIG_SND_DEBUG_DETECT is not set.
 */
 #define snd_printdd(format, args...) snd_printk(format, ##args)
 
--

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

----- End forwarded message -----

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

#4 lore raw
In reply to Pavel Machek
Quoted 2 lines · Pavel Machek

Do we have sound maintainers? Noone replies on trivial patches :-(.

I handle trivial patches (well, at least those send to [email protected]).
I don't check that mailbox daily though - for a few reasons;

1. I prefer to wait a while to see if patches get merged elsewhere before bothering about them for Trivial.

2. I only just took over Trivial fron Adrian and I've still to work out how to deal with it properly.

/Jesper Juhl

Quoted 59 lines

Pavel

----- Forwarded message from Pavel Machek <[email protected]> -----

From: Pavel Machek <[email protected]>
To: [email protected], kernel list <[email protected]>,
Trivial patch monkey <[email protected]>, [email protected]
Subject: fix comments in sound/core.h
X-Warning: Reading this can be dangerous to your mental health.

Two sentences seem to be spliced into one in comment, fix that and fix english. Also fix codingstyle.

include/sound/core.h +3 -3
index 4fc0235..452000d 100644
@@ -310,7 +310,7 @@ int snd_card_file_add(struct snd_card *c
 int snd_card_file_remove(struct snd_card *card, struct file *file);
 
 #ifndef snd_card_set_dev
-#define snd_card_set_dev(card,devptr) ((card)->dev = (devptr))
+#define snd_card_set_dev(card, devptr) ((card)->dev = (devptr))
 #endif
 
 /* device.c */
@@ -373,7 +373,7 @@ #ifdef CONFIG_SND_VERBOSE_PRINTK
  * snd_printd - debug printk
  * @fmt: format string
  *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
  * Ignored when CONFIG_SND_DEBUG is not set.
  */
 #define snd_printd(fmt, args...) \
@@ -417,7 +417,7 @@ #ifdef CONFIG_SND_DEBUG_DETECT
  * snd_printdd - debug printk
  * @format: format string
  *
- * Compiled only when Works like snd_printk() for debugging purpose.
+ * Works like snd_printk() for debugging purposes.
  * Ignored when CONFIG_SND_DEBUG_DETECT is not set.
  */
 #define snd_printdd(format, args...) snd_printk(format, ##args)
Signature · 10 lines
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


----- End forwarded message -----

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#5 lore raw

Hi!

Quoted 7 lines
Quoted 2 lines

Do we have sound maintainers? Noone replies on trivial patches :-(.

I handle trivial patches (well, at least those send to [email protected]).
I don't check that mailbox daily though - for a few reasons;

Quoted 5 lines

1. I prefer to wait a while to see if patches get merged elsewhere before bothering about them for Trivial.

2. I only just took over Trivial fron Adrian and I've still to work out how to deal with it properly.

No problem. I this is already merged, so ignore this...

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html