Skip to contentSkip to conversation

2.6.25-rc6 hangs at resume after suspend to RAM on Mac mini Core Duo

DISCUSSION Tino Keitel 8 participants 31 messages Mar 20, 2008 – Apr 2, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi folks,

whereas I had working suspend with 2.6.25-rc5, I had a hang at resume with git HEAD from March 19th (something after 2.6.25-rc6). I tried it again and got another hang, so it seems to be reproducible.

Any hints what commit might have broke suspend? I won't have the time to start a git bisect or any resume debugging using CONFIG_PM_TRACE_RTC until next Tuesday.

This is a Mac mini Core Duo. Here is the lspci -nn output:

00:00.0 Host bridge [0600]: Intel Corporation Mobile 945GM/PM/GMS, 943/940GML and 945GT Express Memory Controller Hub [8086:27a0] (rev 03)

00:02.0 VGA compatible controller [0300]: Intel Corporation Mobile 945GM/GMS, 943/940GML Express Integrated Graphics Controller [8086:27a2] (rev 03)

00:07.0 Performance counters [1101]: Intel Corporation Unknown device [8086:27a3] (rev 03)

00:1b.0 Audio device [0403]: Intel Corporation 82801G (ICH7 Family) High Definition Audio Controller [8086:27d8] (rev 02)

00:1c.0 PCI bridge [0604]: Intel Corporation 82801G (ICH7 Family) PCI Express Port 1 [8086:27d0] (rev 02)

00:1c.1 PCI bridge [0604]: Intel Corporation 82801G (ICH7 Family) PCI Express Port 2 [8086:27d2] (rev 02)

00:1d.0 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #1 [8086:27c8] (rev 02)

00:1d.1 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #2 [8086:27c9] (rev 02)

00:1d.2 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #3 [8086:27ca] (rev 02)

00:1d.3 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #4 [8086:27cb] (rev 02)

00:1d.7 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB2 EHCI Controller [8086:27cc] (rev 02)

00:1e.0 PCI bridge [0604]: Intel Corporation 82801 Mobile PCI Bridge [8086:2448] (rev e2)

00:1f.0 ISA bridge [0601]: Intel Corporation 82801GBM (ICH7-M) LPC Interface Bridge [8086:27b9] (rev 02)

00:1f.1 IDE interface [0101]: Intel Corporation 82801G (ICH7 Family) IDE Controller [8086:27df] (rev 02)

00:1f.2 IDE interface [0101]: Intel Corporation 82801GBM/GHM (ICH7 Family) SATA IDE Controller [8086:27c4] (rev 02)

00:1f.3 SMBus [0c05]: Intel Corporation 82801G (ICH7 Family) SMBus Controller [8086:27da] (rev 02)

01:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd. 88E8053 PCI-E Gigabit Ethernet Controller [11ab:4362] (rev 22)

02:00.0 Ethernet controller [0200]: Atheros Communications, Inc. AR242x 802.11abg Wireless PCI Express Adapter [168c:001c] (rev 01)

03:03.0 FireWire (IEEE 1394) [0c00]: Agere Systems FW323 [11c1:5811] (rev 61)

Regards,
Tino

#1 lore raw
Quoted 1 line · Tino Keitel

Hi folks,

Hi,

Quoted 7 lines

whereas I had working suspend with 2.6.25-rc5, I had a hang at resume with git HEAD from March 19th (something after 2.6.25-rc6). I tried it again and got another hang, so it seems to be reproducible.

Any hints what commit might have broke suspend? I won't have the time to start a git bisect or any resume debugging using CONFIG_PM_TRACE_RTC until next Tuesday.

No ideas for now.

I have created a Bugzilla entry for this problem at:
http://bugzilla.kernel.org/show_bug.cgi?id=10291

Please add yourself to the CC list in there.

Quoted 51 lines

This is a Mac mini Core Duo. Here is the lspci -nn output:

00:00.0 Host bridge [0600]: Intel Corporation Mobile 945GM/PM/GMS, 943/940GML and 945GT Express Memory Controller Hub [8086:27a0] (rev 03)

00:02.0 VGA compatible controller [0300]: Intel Corporation Mobile 945GM/GMS, 943/940GML Express Integrated Graphics Controller [8086:27a2] (rev 03)

00:07.0 Performance counters [1101]: Intel Corporation Unknown device [8086:27a3] (rev 03)

00:1b.0 Audio device [0403]: Intel Corporation 82801G (ICH7 Family) High Definition Audio Controller [8086:27d8] (rev 02)

00:1c.0 PCI bridge [0604]: Intel Corporation 82801G (ICH7 Family) PCI Express Port 1 [8086:27d0] (rev 02)

00:1c.1 PCI bridge [0604]: Intel Corporation 82801G (ICH7 Family) PCI Express Port 2 [8086:27d2] (rev 02)

00:1d.0 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #1 [8086:27c8] (rev 02)

00:1d.1 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #2 [8086:27c9] (rev 02)

00:1d.2 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #3 [8086:27ca] (rev 02)

00:1d.3 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB UHCI Controller #4 [8086:27cb] (rev 02)

00:1d.7 USB Controller [0c03]: Intel Corporation 82801G (ICH7 Family) USB2 EHCI Controller [8086:27cc] (rev 02)

00:1e.0 PCI bridge [0604]: Intel Corporation 82801 Mobile PCI Bridge [8086:2448] (rev e2)

00:1f.0 ISA bridge [0601]: Intel Corporation 82801GBM (ICH7-M) LPC Interface Bridge [8086:27b9] (rev 02)

00:1f.1 IDE interface [0101]: Intel Corporation 82801G (ICH7 Family) IDE Controller [8086:27df] (rev 02)

00:1f.2 IDE interface [0101]: Intel Corporation 82801GBM/GHM (ICH7 Family) SATA IDE Controller [8086:27c4] (rev 02)

00:1f.3 SMBus [0c05]: Intel Corporation 82801G (ICH7 Family) SMBus Controller [8086:27da] (rev 02)

Quoted 8 lines

01:00.0 Ethernet controller [0200]: Marvell Technology Group Ltd. 88E8053 PCI-E Gigabit Ethernet Controller [11ab:4362] (rev 22)

02:00.0 Ethernet controller [0200]: Atheros Communications, Inc. AR242x 802.11abg Wireless PCI Express Adapter [168c:001c] (rev 01)

03:03.0 FireWire (IEEE 1394) [0c00]: Agere Systems FW323 [11c1:5811] (rev 61)

Thanks,
Rafael

#2 lore raw
In reply to Tino Keitel
Quoted 5 lines · On Thu, 20 Mar 2008 07:05:50 +0100 Tino Keitel <[email protected]> wrote:

Hi folks,

whereas I had working suspend with 2.6.25-rc5, I had a hang at resume with git HEAD from March 19th (something after 2.6.25-rc6). I tried it again and got another hang, so it seems to be reproducible.

Was 2.6.24 OK?

Quoted 5 lines

Any hints what commit might have broke suspend? I won't have the time to start a git bisect or any resume debugging using CONFIG_PM_TRACE_RTC until next Tuesday.

This is a Mac mini Core Duo.

I assume Linus doesn't use his any more ;)

Quoted 1 line

Here is the lspci -nn output:

Please try Linus's current tree - quite a few things got reverted today which might have fixed this.

#3 lore raw
Quoted 9 lines · Andrew Morton
Quoted 5 lines · On Thu, 20 Mar 2008 07:05:50 +0100 Tino Keitel <[email protected]> wrote:

Hi folks,

whereas I had working suspend with 2.6.25-rc5, I had a hang at resume with git HEAD from March 19th (something after 2.6.25-rc6). I tried it again and got another hang, so it seems to be reproducible.

Was 2.6.24 OK?

Yes, mostly ok (some seldom failures).

Quoted 8 lines
Quoted 6 lines

Any hints what commit might have broke suspend? I won't have the time to start a git bisect or any resume debugging using CONFIG_PM_TRACE_RTC until next Tuesday.

This is a Mac mini Core Duo.

I assume Linus doesn't use his any more ;)

That's too bad.

Quoted 4 lines
Quoted 1 line

Here is the lspci -nn output:

Please try Linus's current tree - quite a few things got reverted today which might have fixed this.

OK, I'll try it.

Regards,
Tino

#4 lore raw
Quoted 22 lines · Tino Keitel
Quoted 9 lines · Andrew Morton
Quoted 5 lines · On Thu, 20 Mar 2008 07:05:50 +0100 Tino Keitel <[email protected]> wrote:

Hi folks,

whereas I had working suspend with 2.6.25-rc5, I had a hang at resume with git HEAD from March 19th (something after 2.6.25-rc6). I tried it again and got another hang, so it seems to be reproducible.

Was 2.6.24 OK?

Yes, mostly ok (some seldom failures).

Quoted 8 lines
Quoted 6 lines

Any hints what commit might have broke suspend? I won't have the time to start a git bisect or any resume debugging using CONFIG_PM_TRACE_RTC until next Tuesday.

This is a Mac mini Core Duo.

I assume Linus doesn't use his any more ;)

Quoted 8 lines

That's too bad.

Quoted 4 lines
Quoted 1 line

Here is the lspci -nn output:

Please try Linus's current tree - quite a few things got reverted today which might have fixed this.

OK, I'll try it.

I tried HEAD from yesterday, but resume still fails. So it looks like I need to start a git bisect.

Regards,
Tino

#5 lore raw
Quoted 27 lines · Tino Keitel
Quoted 26 lines · Tino Keitel
Quoted 9 lines · Andrew Morton
Quoted 5 lines · On Thu, 20 Mar 2008 07:05:50 +0100 Tino Keitel <[email protected]> wrote:

Hi folks,

whereas I had working suspend with 2.6.25-rc5, I had a hang at resume with git HEAD from March 19th (something after 2.6.25-rc6). I tried it again and got another hang, so it seems to be reproducible.

Was 2.6.24 OK?

Yes, mostly ok (some seldom failures).

Quoted 8 lines
Quoted 6 lines

Any hints what commit might have broke suspend? I won't have the time to start a git bisect or any resume debugging using CONFIG_PM_TRACE_RTC until next Tuesday.

This is a Mac mini Core Duo.

I assume Linus doesn't use his any more ;)

That's too bad.

Quoted 2 lines
Quoted 1 line

Here is the lspci -nn output:

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Please try Linus's current tree - quite a few things got reverted today which might have fixed this.

OK, I'll try it.

I tried HEAD from yesterday, but resume still fails. So it looks like I need to start a git bisect.

Can you please try to boot with acpi_new_pts_ordering and retest?

Thanks,
Rafael

#6 lore raw

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

Regards,
Tino

#7 lore raw
Quoted 8 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

You should put "acpi_new_pts_ordering" on kernel command line.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#8 lore raw
Quoted 11 lines · Pavel Machek
Quoted 8 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

You should put "acpi_new_pts_ordering" on kernel command line.

I did, just forgot to mention it.

Regards,
Tino

#9 lore raw
Quoted 6 lines · Tino Keitel
Quoted 5 lines · Pavel Machek
Quoted 4 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

You should put "acpi_new_pts_ordering" on kernel command line.

I did, just forgot to mention it.

OK, thanks.

Have you tried to do:

# echo core > /sys/power/pm_test
# echo mem > /sys/power/state

(it's good to boot the kernel with no_console_suspend and do "echo 8 > /proc/sys/kernel/printk" before that to see the messages)?

Rafael

#10 lore raw
Quoted 18 lines · Rafael J. Wysocki
Quoted 6 lines · Tino Keitel
Quoted 5 lines · Pavel Machek
Quoted 4 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

You should put "acpi_new_pts_ordering" on kernel command line.

I did, just forgot to mention it.

OK, thanks.

Quoted 7 lines

Have you tried to do:

# echo core > /sys/power/pm_test
# echo mem > /sys/power/state

(it's good to boot the kernel with no_console_suspend and do "echo 8 > /proc/sys/kernel/printk" before that to see the messages)?

Thanks, I'll try this evening. What should I look for in the kernel messages?

Regards,
Tino

#11 lore raw
Quoted 21 lines · Tino Keitel
Quoted 20 lines · Rafael J. Wysocki
Quoted 6 lines · Tino Keitel
Quoted 5 lines · Pavel Machek
Quoted 4 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

You should put "acpi_new_pts_ordering" on kernel command line.

I did, just forgot to mention it.

OK, thanks.

Have you tried to do:

Quoted 8 lines
Quoted 5 lines
# echo core > /sys/power/pm_test
# echo mem > /sys/power/state

(it's good to boot the kernel with no_console_suspend and do "echo 8 > /proc/sys/kernel/printk" before that to see the messages)?

Thanks, I'll try this evening. What should I look for in the kernel messages?

Any irregularities. Please just post the dmesg output if the system survives.

If there are any oopes etc., you should see them. :-)

Thanks,
Rafael

#12 lore raw
In reply to Tino Keitel
Quoted 8 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

Soeren

Signature · 2 lines
For the one fact about the future of which we can be certain is that it
will be utterly fantastic. -- Arthur C. Clarke, 1962
#13 lore raw
Quoted 5 lines · Soeren Sonnenburg
Quoted 4 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.

Regards,
Tino

#14 lore raw
Quoted 8 lines · Tino Keitel
Quoted 7 lines · Soeren Sonnenburg
Quoted 6 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.

No never worked in 2.6.25 (at least from rc2 on) and still does not in rc7-current-git. But note that on console I could suspend to ram and resume but the display is not anymore coming back with s2ram - from within X it freezes though.

Soeren

#15 lore raw
Quoted 15 lines · Soeren Sonnenburg
Quoted 14 lines · Tino Keitel
Quoted 12 lines · Soeren Sonnenburg
Quoted 8 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

Quoted 6 lines
Quoted 1 line

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.

No never worked in 2.6.25 (at least from rc2 on) and still does not in rc7-current-git. But note that on console I could suspend to ram and resume but the display is not anymore coming back with s2ram - from within X it freezes though.

Please try -rc8.

Thanks,
Rafael

#16 lore raw
Quoted 16 lines · Rafael J. Wysocki
Quoted 15 lines · Soeren Sonnenburg
Quoted 14 lines · Tino Keitel
Quoted 12 lines · Soeren Sonnenburg
Quoted 8 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.

No never worked in 2.6.25 (at least from rc2 on) and still does not in rc7-current-git. But note that on console I could suspend to ram and resume but the display is not anymore coming back with s2ram - from within X it freezes though.

Please try -rc8.

OK I did. Now not only the console stays black but blindly typing reboot/s2ram does not do anything after a resume... in this respect rc7 was better though not usable (as the display remained off).

Soeren

#17 lore raw
Quoted 24 lines · Soeren Sonnenburg
Quoted 23 lines · Rafael J. Wysocki
Quoted 21 lines · Soeren Sonnenburg
Quoted 8 lines · Tino Keitel
Quoted 7 lines · Soeren Sonnenburg
Quoted 6 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.

No never worked in 2.6.25 (at least from rc2 on) and still does not in rc7-current-git. But note that on console I could suspend to ram and resume but the display is not anymore coming back with s2ram - from within X it freezes though.

Quoted 5 lines
Quoted 1 line

Please try -rc8.

OK I did. Now not only the console stays black but blindly typing reboot/s2ram does not do anything after a resume... in this respect rc7 was better though not usable (as the display remained off).

The Felix's MacBook suspends sucessfully with current -git, AFAICS. Perhaps you can compare .configs?

Rafael

#18 lore raw
Quoted 25 lines · Rafael J. Wysocki
Quoted 24 lines · Soeren Sonnenburg
Quoted 23 lines · Rafael J. Wysocki
Quoted 21 lines · Soeren Sonnenburg
Quoted 8 lines · Tino Keitel
Quoted 7 lines · Soeren Sonnenburg
Quoted 6 lines · Tino Keitel

On Sat, Mar 29, 2008 at 00:03:15 +0100, Rafael J. Wysocki wrote:

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.

No never worked in 2.6.25 (at least from rc2 on) and still does not in rc7-current-git. But note that on console I could suspend to ram and resume but the display is not anymore coming back with s2ram - from within X it freezes though.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Please try -rc8.

OK I did. Now not only the console stays black but blindly typing reboot/s2ram does not do anything after a resume... in this respect rc7 was better though not usable (as the display remained off).

The Felix's MacBook suspends sucessfully with current -git, AFAICS. Perhaps you can compare .configs?

Well it suspends, since rc2/3 or so but it simply does not resume as it used to in 2.24. Anyway config is here
http://nn7.de/debugging/config.gz .
Also note that this is a macbookpro1,1 and that I have to use
http://marc.info/?l=linux-kernel&m=120674502201007&w=4 to be able to boot.

Soeren

#19 lore raw
In reply to Tino Keitel

Hi!

Quoted 11 lines
Quoted 9 lines
Quoted 6 lines

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.

Any chance to bisect?

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#20 lore raw
Quoted 9 lines · Pavel Machek

Hi!

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.

Any chance to bisect?

I'll try to find the time for a bisect his week.

Regards,
Tino

author Tested-by Gordon Farquharson
#21 lore raw
In reply to Pavel Machek
Quoted 9 lines · Pavel Machek

Hi!

Quoted 7 lines
Quoted 7 lines
Quoted 6 lines

[...]

Quoted 1 line

Can you please try to boot with acpi_new_pts_ordering and retest?

I just tried current -git (a9edadbf790d72adf6ebed476cb5caf7743e7e4a), without success. I still got the same hand at resume.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

I am having the hang on resume problem too (macbook pro), cf.
http://bugzilla.kernel.org/show_bug.cgi?id=10319, 2.6.24 was fine.

What about 2.6.25-rc5? Up to this, resume works for me. -rc6 is broken.

Any chance to bisect?

git-bisect revealed this:

$ git bisect good
e82cc1288fa57857c6af8c57f3d07096d4bcd9d9 is first bad commit
commit e82cc1288fa57857c6af8c57f3d07096d4bcd9d9
Author: David Brownell <[email protected]>
Date:   Fri Mar 7 13:49:42 2008 -0800

USB: fix ehci unlink regressions

The recent EHCI driver update to split the IAA watchdog timer out from the other timers made several things work better, but not everything; and it created a couple new issues in bugzilla. Ergo this patch:

- Handle a should-be-rare SMP race between the watchdog firing and (very late) IAA interrupts;

- Remove a shouldn't-have-been-added WARN_ON() test;

- Guard against one observed OOPS;

- If this watchdog fires during clean HC shutdown, it should act as a NOP instead of interfering with the shutdown sequence;

- Guard against silicon errata hypothesized by some vendors:
* IAA status latch broken, but IAAD cleared OK;
* IAAD wasn't cleared when IAA status got reported;

The WARN_ON is in bugzilla as 10168; the OOPS as 10078; these are both regressions.

:040000 040000 ff621bb62396fdf71c7b97877ddbb8542f57b871
251bc90076ea0b3a14d0b88dd250581fa815b5de M drivers

For the linux-usb people: this commit breaks resume from suspend to RAM on my Mac mini Core Duo. It worked with 2.6.24, 2.6.25-rc5, and was broken since 2.6.25-rc6 (also with -rc7 and later). See
http://lkml.org/lkml/2008/3/20/23 for more information.

Regards,
Tino

maintainer
#22 lore raw
Quoted 8 lines · Tino Keitel

git-bisect revealed this:

$ git bisect good
e82cc1288fa57857c6af8c57f3d07096d4bcd9d9 is first bad commit
commit e82cc1288fa57857c6af8c57f3d07096d4bcd9d9
Author: David Brownell <[email protected]>
Date:   Fri Mar 7 13:49:42 2008 -0800
Quoted 6 lines

USB: fix ehci unlink regressions

For the linux-usb people: this commit breaks resume from suspend to RAM on my Mac mini Core Duo. It worked with 2.6.24, 2.6.25-rc5, and was broken since 2.6.25-rc6 (also with -rc7 and later). See
http://lkml.org/lkml/2008/3/20/23 for more information.

Can you get any information out of the computer after the hang? It would help to see the dmesg log (with CONFIG_USB_DEBUG enabled) and an Alt-SysRq-T stack dump.

Alan Stern

#23 lore raw

On Tue, Apr 01, 2008 at 15:06:51 -0400, Alan Stern wrote:

[...]

Quoted 3 lines

Can you get any information out of the computer after the hang? It would help to see the dmesg log (with CONFIG_USB_DEBUG enabled) and an Alt-SysRq-T stack dump.

Looks difficult. The text console stays black after resume, and there is no serial interface.

Regards,
Tino

maintainer
#24 lore raw
Quoted 10 lines · Tino Keitel

On Tue, Apr 01, 2008 at 15:06:51 -0400, Alan Stern wrote:

[...]

Quoted 3 lines

Can you get any information out of the computer after the hang? It would help to see the dmesg log (with CONFIG_USB_DEBUG enabled) and an Alt-SysRq-T stack dump.

Looks difficult. The text console stays black after resume, and there is no serial interface.

Network console? SSH? Or even telnet?

Alan Stern

#25 lore raw
Quoted 6 lines · Alan Stern
Quoted 4 lines · Tino Keitel

On Tue, Apr 01, 2008 at 15:06:51 -0400, Alan Stern wrote:

[...]

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Can you get any information out of the computer after the hang? It would help to see the dmesg log (with CONFIG_USB_DEBUG enabled) and an Alt-SysRq-T stack dump.

Looks difficult. The text console stays black after resume, and there is no serial interface.

Network console? SSH? Or even telnet?

Network is dead, too.

Regards,
Tino

maintainer
#26 lore raw
Quoted 3 lines · Tino Keitel
Quoted 1 line

Network console? SSH? Or even telnet?

Network is dead, too.

Okay, then try this. Boot with "no_console_suspend" on the command line. Do "echo devices >/sys/power/pm_test" before starting the suspend. Then "echo mem >/sys/power/state", and while the system is paused try unplugging/replugging a USB device.

Maybe that will provide usable information.

Alan Stern

maintainer
#27 lore raw
In reply to Tino Keitel
Quoted 11 lines · Tino Keitel
Quoted 10 lines · Alan Stern
Quoted 8 lines · Tino Keitel

On Tue, Apr 01, 2008 at 15:06:51 -0400, Alan Stern wrote:

[...]

Quoted 3 lines

Can you get any information out of the computer after the hang? It would help to see the dmesg log (with CONFIG_USB_DEBUG enabled) and an Alt-SysRq-T stack dump.

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

Looks difficult. The text console stays black after resume, and there is no serial interface.

Network console? SSH? Or even telnet?

Network is dead, too.

Tino, try this patch. It fixed Mark Lord's problem, which looked the same as yours.

Alan Stern

drivers/usb/host/ehci-hub.c +3 -2
@@ -135,8 +135,6 @@
 		hcd->state = HC_STATE_QUIESCING;
 	}
 	ehci->command = ehci_readl(ehci, &ehci->regs->command);
-	if (ehci->reclaim)
-		end_unlink_async(ehci);
 	ehci_work(ehci);
 
 	/* Unlike other USB host controller types, EHCI doesn't have
@@ -180,6 +178,9 @@
 	ehci_halt (ehci);
 	hcd->state = HC_STATE_SUSPENDED;
 
+	if (ehci->reclaim)
+		end_unlink_async(ehci);
+
 	/* allow remote wakeup */
 	mask = INTR_MASK;
 	if (!device_may_wakeup(&hcd->self.root_hub->dev))
#28 lore raw
Quoted 16 lines · Alan Stern
Quoted 14 lines · Tino Keitel
Quoted 13 lines · Alan Stern
Quoted 10 lines · Tino Keitel

On Tue, Apr 01, 2008 at 15:06:51 -0400, Alan Stern wrote:

[...]

Quoted 3 lines

Can you get any information out of the computer after the hang? It would help to see the dmesg log (with CONFIG_USB_DEBUG enabled) and an Alt-SysRq-T stack dump.

Looks difficult. The text console stays black after resume, and there is no serial interface.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Network console? SSH? Or even telnet?

Network is dead, too.

Tino, try this patch. It fixed Mark Lord's problem, which looked the same as yours.

Fine, it seems to solve the hang, I see no problems after the resume. Thanks a lot.

Regards,
Tino

#29 lore raw
Quoted 19 lines · Tino Keitel
Quoted 18 lines · Alan Stern
Quoted 16 lines · Tino Keitel
Quoted 14 lines · Alan Stern
Quoted 10 lines · Tino Keitel

On Tue, Apr 01, 2008 at 15:06:51 -0400, Alan Stern wrote:

[...]

Quoted 3 lines

Can you get any information out of the computer after the hang? It would help to see the dmesg log (with CONFIG_USB_DEBUG enabled) and an Alt-SysRq-T stack dump.

Looks difficult. The text console stays black after resume, and there is no serial interface.

Network console? SSH? Or even telnet?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Network is dead, too.

Tino, try this patch. It fixed Mark Lord's problem, which looked the same as yours.

Fine, it seems to solve the hang, I see no problems after the resume. Thanks a lot.

Using this patch fixes the hang for my macbookpro1,1 too. However the console stays black after resume, though I can s2ram multiple times and reboot...

Soeren

#30 lore raw
In reply to Tino Keitel
Quoted 9 lines

git-bisect revealed this:

$ git bisect good
e82cc1288fa57857c6af8c57f3d07096d4bcd9d9 is first bad commit
commit e82cc1288fa57857c6af8c57f3d07096d4bcd9d9
Author: David Brownell <[email protected]>
Date:   Fri Mar 7 13:49:42 2008 -0800

USB: fix ehci unlink regressions

Most curious. Based on what I read earlier, I was wondering about the handling of the unlink watchdog during a known-dodgey path.

Specifically:

Quoted 7 lines

The recent EHCI driver update to split the IAA watchdog timer out from the other timers made several things work better, but not everything; and it created a couple new issues in bugzilla. Ergo this patch:

- Handle a should-be-rare SMP race between the watchdog firing and (very late) IAA interrupts;

Quoted 6 lines

- Remove a shouldn't-have-been-added WARN_ON() test;

- Guard against one observed OOPS;

- If this watchdog fires during clean HC shutdown, it should act as a NOP instead of interfering with the shutdown sequence;

This "fires during a clean shutdown" path. If there's any way this patch would affect resume handling, that's where I'd expect it to kick in. Virtually nothing else *could* cause problems there.

If you'd like to experiment, modify the "if (...)" at the top of the ehci_iaa_watchdog() function and make it just check to see if there's an entry being reclaimed ... comment out the HC_IS_RUNNING() check.

Quoted 3 lines

- Guard against silicon errata hypothesized by some vendors:
* IAA status latch broken, but IAAD cleared OK;
* IAAD wasn't cleared when IAA status got reported;

FWIW the former has been confirmed as existing on some current AMD/ATI chipsets (SB600 and SB700 are the numbers that come to mind).

Quoted 6 lines

The WARN_ON is in bugzilla as 10168; the OOPS as 10078; these are both regressions.