Skip to contentSkip to conversation

b43legacy: fix bcm4303 crash

PATCH In review Stefano Brivio 3 participants 4 messages Apr 6, 2008 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43legacy: fix bcm4303 crash

This fixes an hard crash which happened upon driver loading on bcm4303 rev. 2 devices.

---
John, this is for 2.6.26.
---

drivers/ssb/main.c +6 -0
index e123719..4bc0e8b 100644
@@ -1101,6 +1101,12 @@ int ssb_bus_may_powerdown(struct ssb_bus *bus)
 		goto out;
 
 	cc = &bus->chipco;
+
+	if (!cc->dev)
+		goto out;
+	if (cc->dev->id.revision < 5)
+		goto out;
+
 	ssb_chipco_set_clockmode(cc, SSB_CLKMODE_SLOW);
 	err = ssb_pci_xtal(bus, SSB_GPIO_XTAL | SSB_GPIO_PLL, 0);
 	if (err)

--
Ciao
Stefano

#1 lore raw
Quoted 4 lines · On Sunday 06 April 2008 17:05:07 Stefano Brivio wrote:

This fixes an hard crash which happened upon driver loading on bcm4303 rev. 2 devices.

ACK

Quoted 2 lines

---
John, this is for 2.6.26.

Why not 2.6.25?

Quoted 29 lines

---

drivers/ssb/main.c +6 -1
index e123719..4bc0e8b 100644
@@ -1101,6 +1101,12 @@ int ssb_bus_may_powerdown(struct ssb_bus *bus)
 		goto out;
 
 	cc = &bus->chipco;
+
+	if (!cc->dev)
+		goto out;
+	if (cc->dev->id.revision < 5)
+		goto out;
+
 	ssb_chipco_set_clockmode(cc, SSB_CLKMODE_SLOW);
 	err = ssb_pci_xtal(bus, SSB_GPIO_XTAL | SSB_GPIO_PLL, 0);
 	if (err)
 
 
--

Ciao
Stefano
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Signature · 1 line
Greetings Michael.
#2 lore raw
Quoted 4 lines · On Sun, 6 Apr 2008 17:20:02 +0200 Michael Buesch <[email protected]> wrote:
Quoted 3 lines · On Sunday 06 April 2008 17:05:07 Stefano Brivio wrote:

This fixes an hard crash which happened upon driver loading on bcm4303 rev. 2 devices.

Quoted 8 lines
Quoted 1 line

ACK

Quoted 2 lines

---
John, this is for 2.6.26.

Why not 2.6.25?

Sorry, typo. Yes, i meant 2.6.25.

--
Ciao
Stefano