Skip to contentSkip to conversation

Fix kernel-doc for skb_segment

PATCH Applied Ben Hutchings 2 participants 2 messages Apr 7, 2008 – Apr 14, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ben Hutchings

author
#0 lore raw

PATCH 1/1 Fix kernel-doc for skb_segment

The kernel-doc comment for skb_segment is clearly wrong. This states what it actually does.

Signed-off-by Ben Hutchings <[email protected]>
net/core/skbuff.c +2 -2
index 0d0fd28..6087013 100644
@@ -2131,8 +2131,8 @@ EXPORT_SYMBOL_GPL(skb_pull_rcsum);
  *	@features: features for the output path (see dev->features)
  *
  *	This function performs segmentation on the given skb.  It returns
- *	the segment at the given position.  It returns NULL if there are
- *	no more segments to generate, or when an error is encountered.
+ *	a pointer to the first in a list of new skbs for the segments.
+ *	In case of error it returns ERR_PTR(err).
  */
 struct sk_buff *skb_segment(struct sk_buff *skb, int features)
 {
Signature · 2 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.