Skip to contentSkip to conversation

sky2: missing chip name for Yukon Supreme

PATCH Applied Stephen Hemminger 3 participants 4 messages Apr 10, 2008 – Apr 12, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 sky2: missing chip name for Yukon Supreme

Any usage of sky2 on new Yukon Supreme would cause a NULL dereference. The chip is very new, so the support is still untested; vendor has not sent any eval hardware.

Signed-off-by Stephen Hemminger <[email protected]>

---
Please apply for 2.6.25

drivers/net/sky2.c +1 -0
@@ -154,6 +154,7 @@ static const char *yukon2_name[] = {
 	"EC",		/* 0xb6 */
 	"FE",		/* 0xb7 */
 	"FE+",		/* 0xb8 */
+	"Supreme",	/* 0xb9 */
 };
 
 static void sky2_set_multicast(struct net_device *dev);
#1 lore raw
Quoted 3 lines · Stephen Hemminger

Any usage of sky2 on new Yukon Supreme would cause a NULL dereference. The chip is very new, so the support is still untested; vendor has not sent any eval hardware.

What about also making the driver not oops in case another variant is added?

author
#2 lore raw
Quoted 6 lines · On Thu, 10 Apr 2008 16:14:21 -0400 Christoph Hellwig <[email protected]> wrote:
Quoted 3 lines · Stephen Hemminger

Any usage of sky2 on new Yukon Supreme would cause a NULL dereference. The chip is very new, so the support is still untested; vendor has not sent any eval hardware.

What about also making the driver not oops in case another variant is added?

Many more changes will be needed for the next new variant. They never do the same thing.

Applied
#3 lore raw
In reply to Stephen Hemminger
Quoted 19 lines · Stephen Hemminger

Any usage of sky2 on new Yukon Supreme would cause a NULL dereference. The chip is very new, so the support is still untested; vendor has not sent any eval hardware.

Signed-off-by Stephen Hemminger <[email protected]>

---
Please apply for 2.6.25

drivers/net/sky2.c +1 -1
@@ -154,6 +154,7 @@ static const char *yukon2_name[] = {
 	"EC",		/* 0xb6 */
 	"FE",		/* 0xb7 */
 	"FE+",		/* 0xb8 */
+	"Supreme",	/* 0xb9 */
 };
 
 static void sky2_set_multicast(struct net_device *dev);
--
Quoted 1 line

To unsubscribe from this list: send the line "unsubscribe netdev" in

applied