Skip to contentSkip to conversation

lm-sensors crash on non x86 hardware

PATCH In review Christian Krafft 2 participants 3 messages Apr 10, 2008 – Apr 12, 2008

lore
Share & tools
lore

Christian Krafft

author
#0 lore raw

PATCH 1/1 lm-sensors crash on non x86 hardware

Hi,

Please consider this tiny patch for inclusion.
It provides the user with more precise info.

prog/detect/sensors-detect +2 -2
Index: lm_sensors-2.10.0/prog/detect/sensors-detect
===================================================================
@@ -5153,7 +5153,7 @@ sub main
 
   print "\nSome chips are also accessible through the ISA bus. ISA probes are\n".
         "typically a bit more dangerous, as we have to write to I/O ports to do\n".
-        "this. This is usually safe though.\n\n";
+        "this. This is usually safe on x86 acrhitecture.\n\n";
   if ($> != 0) {
     print "As you are not root, we shall skip this step.\n";
   } else {

@@ -5167,7 +5167,7 @@ sub main
 
   print "\nSome Super I/O chips may also contain sensors. Super I/O probes are\n".
         "typically a bit more dangerous, as we have to write to I/O ports to do\n".
-        "this. This is usually safe though.\n\n";
+        "this. This is usually safe on x86 acrhitecture.\n\n";
   if ($> != 0) {
     print "As you are not root, we shall skip this step.\n";
   } else {
Signature · 13 lines
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Martin Jetter
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Hi Christian,

Quoted 8 lines · Christian Krafft

Hi,

Please consider this tiny patch for inclusion.
It provides the user with more precise info.

Index: lm_sensors-2.10.0/prog/detect/sensors-detect =================================> --- lm_sensors-2.10.0.orig/prog/detect/sensors-detect +++ lm_sensors-2.10.0/prog/detect/sensors-detect

2.10.0 is old...

Quoted 10 lines
prog/detect/sensors-detect +1 -1
@@ -5153,7 +5153,7 @@ sub main
 
   print "\nSome chips are also accessible through the ISA bus. ISA probes are\n".
         "typically a bit more dangerous, as we have to write to I/O ports to do\n".
-        "this. This is usually safe though.\n\n";
+        "this. This is usually safe on x86 acrhitecture.\n\n";
   if ($> != 0) {
     print "As you are not root, we shall skip this step.\n";
   } else {

prog/detect/sensors-detect sub main · line 5173

Quoted 8 lines
prog/detect/sensors-detect +1 -1
@@ -5167,7 +5167,7 @@ sub main
 
   print "\nSome Super I/O chips may also contain sensors. Super I/O probes are\n".
         "typically a bit more dangerous, as we have to write to I/O ports to do\n".
-        "this. This is usually safe though.\n\n";
+        "this. This is usually safe on x86 acrhitecture.\n\n";
   if ($> != 0) {
     print "As you are not root, we shall skip this step.\n";
   } else {

We already skip these probes on PPC:
http://www.lm-sensors.org/changeset/5125
Isn't it sufficient?

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
author
#2 lore raw
In reply to Christian Krafft

Hi Jean,

Quoted 8 lines · On Thu, 10 Apr 2008 18:14:46 +0200 Jean Delvare <[email protected]> wrote:

Hi Christian,

Quoted 5 lines · Christian Krafft

Hi,

Please consider this tiny patch for inclusion.
It provides the user with more precise info.

Quoted 6 lines

prog/detect/sensors-detect

Quoted 4 lines

Index: lm_sensors-2.10.0/prog/detect/sensors-detect
===================================================================

prog/detect/sensors-detect +0 -0

2.10.0 is old...

Ups, Next time I'll check before posting ;-)

Quoted 13 lines
Quoted 13 lines
prog/detect/sensors-detect +0 -0
@@ -5153,7 +5153,7 @@ sub main
 
   print "\nSome chips are also accessible through the ISA bus. ISA probes

are\n". "typically a bit more dangerous, as we have to write to I/O ports to do\n".

prog/detect/sensors-detect +1 -1
-        "this. This is usually safe though.\n\n";
+        "this. This is usually safe on x86 acrhitecture.\n\n";
   if ($> != 0) {
     print "As you are not root, we shall skip this step.\n";
   } else {

@@ -5167,7 +5167,7 @@ sub main
Quoted 13 lines

prog/detect/sensors-detect sub main · line 5159

Quoted 8 lines
prog/detect/sensors-detect +0 -0
   print "\nSome Super I/O chips may also contain sensors. Super I/O probes

are\n". "typically a bit more dangerous, as we have to write to I/O ports to do\n".

prog/detect/sensors-detect +1 -1
-        "this. This is usually safe though.\n\n";
+        "this. This is usually safe on x86 acrhitecture.\n\n";
   if ($> != 0) {
     print "As you are not root, we shall skip this step.\n";
   } else {

We already skip these probes on PPC:
http://www.lm-sensors.org/changeset/5125
Isn't it sufficient?

Thats perfect, more than I expected. Thanks!

Signature · 13 lines
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Martin Jetter
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors