Skip to contentSkip to conversation

gpio_keys irq handling

PATCH RESEND Applied David Brownell 2 participants 2 messages Apr 11, 2008 – Apr 15, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 gpio_keys irq handling

From: David Brownell <[email protected]>

Cleanup IRQ handling in gpio_keys: bail after handling the IRQ, and report IRQ_NONE if we never handle it.

Cc Phil Blundell <[email protected]>
Cc Dmitry Torokhov <[email protected]>

---
No functional changes since the version sent 27-Dec-2007. MAINTAINERS says "linux-input@vger" but the only archives I could find seems to say "@atrey.karlin.mff.cuni.cz"...

 drivers/input/keyboard/gpio_keys.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/input/keyboard/gpio_keys.c +2 -1
@@ -43,10 +43,11 @@ static irqreturn_t gpio_keys_isr(int irq
 
 			input_event(input, type, button->code, !!state);
 			input_sync(input);
+			return IRQ_HANDLED;
 		}
 	}
 
-	return IRQ_HANDLED;
+	return IRQ_NONE;
 }
 
 static int __devinit gpio_keys_probe(struct platform_device *pdev)