Skip to contentSkip to conversation

x86: Cleanup prose of Documentation/i386/IO-APIC.txt

RFC Nick Andrew 2 participants 6 messages Apr 11, 2008 – Apr 14, 2008

lore
Share & tools
lore
#0 lore raw

I'm doing a couple of cleanups to Documentation/i386/IO-APIC.txt and I have a problem with this line, which is supposed to compute a sample pirq= kernel parameter:

echo -n pirq=; echo scanpci | grep T_L | cut -c56- | sed 's/ /,/g'

The 'scanpci' command used to be part of xutils and/or XFree86. Xorg implements "Xorg -scanpci" but the output is different and it won't run while X is running.

Firstly I propose using the $( ) construct rather than backticks, since it is easier to read:

   echo -n pirq=; echo $( scanpci | grep T_L | cut -c56- ) | sed 's/ /,/g'

Inside the backtics, instead of scanpci, I could do:

lspci -v | grep IRQ | sed -e 's/.* IRQ \(\w\+\)/\1/'

Is this an acceptable substitution?

Nick.

Signature · 2 lines
PGP Key ID = 0x418487E7                      http://www.nick-andrew.net/
PGP Key fingerprint = B3ED 6894 8E49 1770 C24A  67E3 6266 6EB9 4184 87E7
#1 lore raw
Quoted 13 lines · Nick Andrew

I'm doing a couple of cleanups to Documentation/i386/IO-APIC.txt and I have a problem with this line, which is supposed to compute a sample pirq= kernel parameter:

   echo -n pirq=; echo `scanpci | grep T_L | cut -c56-` | sed 's/ /,/g'

The 'scanpci' command used to be part of xutils and/or XFree86. Xorg implements "Xorg -scanpci" but the output is different and it won't run while X is running.

Firstly I propose using the $( ) construct rather than backticks, since it is easier to read:

Quoted 7 lines
   echo -n pirq=; echo $( scanpci | grep T_L | cut -c56- ) | sed 's/ /,/g'

Inside the backtics, instead of scanpci, I could do:

   lspci -v | grep IRQ | sed -e 's/.* IRQ \(\w\+\)/\1/'

Is this an acceptable substitution?

yeah, i guess so.

Btw., that's rather arcane text - do people still have to use pirq= boot lines to get their boxes to boot?

Ingo

#2 lore raw
Quoted 6 lines · Ingo Molnar
Quoted 4 lines · Nick Andrew
   echo -n pirq=; echo $( scanpci | grep T_L | cut -c56- ) | sed 's/ /,/g'

Inside the backtics, instead of scanpci, I could do:

Quoted 8 lines
Quoted 3 lines
   lspci -v | grep IRQ | sed -e 's/.* IRQ \(\w\+\)/\1/'

Is this an acceptable substitution?

yeah, i guess so.

Btw., that's rather arcane text - do people still have to use pirq= boot lines to get their boxes to boot?

I wouldn't know that, but I still have to use 'noapic' to get my AMD box to boot :-(

Nick.

Signature · 2 lines
PGP Key ID = 0x418487E7                      http://www.nick-andrew.net/
PGP Key fingerprint = B3ED 6894 8E49 1770 C24A  67E3 6266 6EB9 4184 87E7
#3 lore raw
Quoted 5 lines · Nick Andrew
Quoted 2 lines

Btw., that's rather arcane text - do people still have to use pirq= boot lines to get their boxes to boot?

I wouldn't know that, but I still have to use 'noapic' to get my AMD box to boot :-(

oh. If "noapic" is still necessary with x86/latest:

http://people.redhat.com/mingo/x86.git/README

is there any bugreport i could have a look at, with full dmesg and config included, and with a description of how it fails to boot? cfs-debug-info output would be useful too:

http://people.redhat.com/mingo/cfs-scheduler/tools/cfs-debug-info.sh

Ingo

#4 lore raw
Quoted 7 lines · Ingo Molnar
Quoted 2 lines · Nick Andrew

I wouldn't know that, but I still have to use 'noapic' to get my AMD box to boot :-(

oh. If "noapic" is still necessary with x86/latest:

http://people.redhat.com/mingo/x86.git/README

Thanks; I'll retest on latest then. I didn't realise the problem was fixed.

Nick.

Signature · 2 lines
PGP Key ID = 0x418487E7                      http://www.nick-andrew.net/
PGP Key fingerprint = B3ED 6894 8E49 1770 C24A  67E3 6266 6EB9 4184 87E7
#5 lore raw
Quoted 11 lines · Nick Andrew
Quoted 7 lines · Ingo Molnar
Quoted 2 lines · Nick Andrew

I wouldn't know that, but I still have to use 'noapic' to get my AMD box to boot :-(

oh. If "noapic" is still necessary with x86/latest:

http://people.redhat.com/mingo/x86.git/README

Thanks; I'll retest on latest then. I didn't realise the problem was fixed.

just to make sure: nothing _specific_ was done in this area, this is just to make sure we'll both deal with the same codebase. But in general, if a box needs "noapic", that signals a bug we should try to solve in the kernel automatically (even if it's BIOS inflicted damage).

Ingo