Skip to contentSkip to conversation

leds: fix platform driver hotplug/coldplug

PATCH In review David Brownell 3 participants 3 messages Apr 11, 2008 – Apr 12, 2008

Subsystems (3)
Arm Samsung Exynos Arm/Microchip (AT91) SoC support LED
lore
Share & tools
lore

David Brownell

author
#0 lore raw

PATCH 1/1 leds: fix platform driver hotplug/coldplug

From: Kay Sievers <[email protected]>

Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable platform LED drivers, to re-enable auto loading.

[ [email protected]: more drivers, registration fixes ]
Signed-off-by Kay Sievers <[email protected]>
Signed-off-by David Brownell <[email protected]>
---
 drivers/leds/leds-ams-delta.c   |    2 ++
 drivers/leds/leds-atmel-pwm.c   |    3 +++
 drivers/leds/leds-clevo-mail.c  |    1 +
 drivers/leds/leds-cm-x270.c     |    2 ++
 drivers/leds/leds-cobalt-qube.c |    3 +++
 drivers/leds/leds-corgi.c       |    2 ++
 drivers/leds/leds-gpio.c        |    1 +
 drivers/leds/leds-h1940.c       |    2 ++
 drivers/leds/leds-hp6xx.c       |    4 ++++
 drivers/leds/leds-s3c24xx.c     |    1 +
 drivers/leds/leds-spitz.c       |    2 ++
 drivers/leds/leds-tosa.c        |    2 ++
 12 files changed, 25 insertions(+)
drivers/leds/leds-ams-delta.c +2 -0
@@ -140,6 +140,7 @@ static struct platform_driver ams_delta_
 	.resume		= ams_delta_led_resume,
 	.driver		= {
 		.name = "ams-delta-led",
+		.owner = THIS_MODULE,
 	},
 };
 

@@ -159,3 +160,4 @@ module_exit(ams_delta_led_exit);
 MODULE_AUTHOR("Jonathan McDowell <[email protected]>");
 MODULE_DESCRIPTION("Amstrad Delta LED driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:ams-delta-led");
drivers/leds/leds-cm-x270.c +2 -0
@@ -101,6 +101,7 @@ static struct platform_driver cmx270led_
 #endif
 	.driver		= {
 		.name		= "cm-x270-led",
+		.owner		= THIS_MODULE,
 	},
 };
 

@@ -120,3 +121,4 @@ module_exit(cmx270led_exit);
 MODULE_AUTHOR("Mike Rapoport <[email protected]>");
 MODULE_DESCRIPTION("CM-x270 LED driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:cm-x270-led");
drivers/leds/leds-corgi.c +2 -0
@@ -99,6 +99,7 @@ static struct platform_driver corgiled_d
 #endif
 	.driver		= {
 		.name		= "corgi-led",
+		.owner		= THIS_MODULE,
 	},
 };
 

@@ -118,3 +119,4 @@ module_exit(corgiled_exit);
 MODULE_AUTHOR("Richard Purdie <[email protected]>");
 MODULE_DESCRIPTION("Corgi LED driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:corgi-led");
drivers/leds/leds-gpio.c +1 -0
@@ -199,3 +199,4 @@ module_exit(gpio_led_exit);
 MODULE_AUTHOR("Raphael Assenat <[email protected]>");
 MODULE_DESCRIPTION("GPIO LED driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:leds-gpio");
drivers/leds/leds-h1940.c +2 -0
@@ -139,6 +139,7 @@ static int h1940leds_remove(struct platf
 static struct platform_driver h1940leds_driver = {
 	.driver		= {
 		.name	= "h1940-leds",
+		.owner	= THIS_MODULE,
 	},
 	.probe		= h1940leds_probe,
 	.remove		= h1940leds_remove,

@@ -161,3 +162,4 @@ module_exit(h1940leds_exit);
 MODULE_AUTHOR("Arnaud Patard <[email protected]>");
 MODULE_DESCRIPTION("LED driver for the iPAQ H1940");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:h1940-leds");
drivers/leds/leds-s3c24xx.c +1 -0
@@ -160,3 +160,4 @@ module_exit(s3c24xx_led_exit);
 MODULE_AUTHOR("Ben Dooks <[email protected]>");
 MODULE_DESCRIPTION("S3C24XX LED driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:s3c24xx_led");
drivers/leds/leds-spitz.c +2 -0
@@ -105,6 +105,7 @@ static struct platform_driver spitzled_d
 #endif
 	.driver		= {
 		.name		= "spitz-led",
+		.owner		= THIS_MODULE,
 	},
 };
 

@@ -124,3 +125,4 @@ module_exit(spitzled_exit);
 MODULE_AUTHOR("Richard Purdie <[email protected]>");
 MODULE_DESCRIPTION("Spitz LED driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:spitz-led");
drivers/leds/leds-tosa.c +2 -0
@@ -109,6 +109,7 @@ static struct platform_driver tosaled_dr
 	.resume		= tosaled_resume,
 	.driver		= {
 		.name		= "tosa-led",
+		.owner		= THIS_MODULE,
 	},
 };
 

@@ -128,3 +129,4 @@ module_exit(tosaled_exit);
 MODULE_AUTHOR("Dirk Opfer <[email protected]>");
 MODULE_DESCRIPTION("Tosa LED driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:tosa-led");
drivers/leds/leds-atmel-pwm.c +3 -0
@@ -132,6 +132,9 @@ static int __exit pwmled_remove(struct p
 	return 0;
 }
 
+/* work with hotplug and coldplug */
+MODULE_ALIAS("platform:leds-atmel-pwm");
+
 static struct platform_driver pwmled_driver = {
 	.driver = {
 		.name =		"leds-atmel-pwm",
drivers/leds/leds-clevo-mail.c +1 -0
@@ -170,6 +170,7 @@ static struct platform_driver clevo_mail
 	.resume		= clevo_mail_led_resume,
 	.driver		= {
 		.name		= KBUILD_MODNAME,
+		.owner		= THIS_MODULE,
 	},
 };
drivers/leds/leds-cobalt-qube.c +3 -0
@@ -75,6 +75,9 @@ static int __devexit cobalt_qube_led_rem
 	return 0;
 }
 
+/* work with hotplug and coldplug */
+MODULE_ALIAS("platform:cobalt-qube-leds");
+
 static struct platform_driver cobalt_qube_led_driver = {
 	.probe	= cobalt_qube_led_probe,
 	.remove	= __devexit_p(cobalt_qube_led_remove),
drivers/leds/leds-hp6xx.c +4 -0
@@ -90,6 +90,9 @@ static int hp6xxled_remove(struct platfo
 	return 0;
 }
 
+/* work with hotplug and coldplug */
+MODULE_ALIAS("platform:hp6xx-led");
+
 static struct platform_driver hp6xxled_driver = {
 	.probe		= hp6xxled_probe,
 	.remove		= hp6xxled_remove,

@@ -99,6 +102,7 @@ static struct platform_driver hp6xxled_d
 #endif
 	.driver		= {
 		.name		= "hp6xx-led",
+		.owner		= THIS_MODULE,
 	},
 };
#1 lore raw
Quoted 5 lines · On Fri, 11 Apr 2008 10:38:34 -0700 David Brownell <[email protected]> wrote:

From: Kay Sievers <[email protected]>

Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable platform LED drivers, to re-enable auto loading.

Richard, I'm pushing as many of these into 2.6.25 as I reasonably can. A swift ack would be good, please.

Of course, we can always go the backport-it-to-2.6.25.1 route as well. Apparently these problems are also present in 2.6.24.

Acked-by
#2 lore raw
Quoted 8 lines · Andrew Morton
Quoted 5 lines · On Fri, 11 Apr 2008 10:38:34 -0700 David Brownell <[email protected]> wrote:

From: Kay Sievers <[email protected]>

Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias is prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable platform LED drivers, to re-enable auto loading.

Quoted 5 lines

Richard, I'm pushing as many of these into 2.6.25 as I reasonably can. A swift ack would be good, please.

Of course, we can always go the backport-it-to-2.6.25.1 route as well. Apparently these problems are also present in 2.6.24.

Acked-by Richard Purdie <[email protected]>

Cheers,

Richard