rt2x00: cleanup Kconfig help

PATCH NAK Filipus Klutiero 2 participants 9 messages Apr 12, 2008 – Apr 20, 2008

Subsystems (2)

Networking drivers (wireless) 802.11 (including cfg80211/NL80211)

lore

Share & tools

lore

Filipus Klutiero

author

2008-04-12 19:10 UTC #0 lore raw

Clarify in CONFIG_RT2500USB that proper RT2500 (PCI) is not supported. While at it, capitalize "rt" in Ralink chipsets names and "usb", "pci". Also clarify what RT61 and RT73 refers to. Finally, update CONFIG_RT2X00 now that this isn't just futureware.

Signed-off-by Filipus Klutiero <[email protected]>

---

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +15 ~~-15~~

@@ -2,10 +2,10 @@
 	tristate "Ralink driver support"
 	depends on MAC80211 && WLAN_80211 && EXPERIMENTAL
 	---help---
-	  This will enable the experimental support for the Ralink drivers,
+	  This enables the experimental support for the Ralink drivers,
 	  developed in the rt2x00 project <http://rt2x00.serialmonkey.com>.
 
-	  These drivers will make use of the Devicescape ieee80211 stack.
+	  These drivers use the mac80211 stack.
 
 	  When building one of the individual drivers, the rt2x00 library
 	  will also be created. That library (when the driver is built as

@@ -38,12 +38,12 @@
 	select INPUT_POLLDEV
 
 config RT2400PCI
-	tristate "Ralink rt2400 pci/pcmcia support"
+	tristate "Ralink RT2400 (PCI/PCMCIA) support"
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt2400 wireless chip.
+	  This is an experimental driver for the Ralink RT2400 wireless chipset.
 
 	  When compiled as a module, this driver will be called "rt2400pci.ko".

@@ -52,17 +52,17 @@
 	depends on RT2400PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt2400 devices that feature a
+	  This adds support for integrated RT2400 devices that feature a
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.
 
 config RT2500PCI
-	tristate "Ralink rt2500 pci/pcmcia support"
+	tristate "Ralink RT2500 PCI/PCMCIA support"
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless chip.
+	  This is an experimental driver for the Ralink RT2500 wireless chipset.
 
 	  When compiled as a module, this driver will be called "rt2500pci.ko".

@@ -71,18 +71,18 @@
 	depends on RT2500PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt2500 devices that feature a
+	  This adds support for integrated RT2500 devices that feature a
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.
 
 config RT61PCI
-	tristate "Ralink rt61 pci/pcmcia support"
+	tristate "Ralink RT2561, RT2661 support"
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt61 wireless chip.
+	  This is an experimental driver for the Ralink RT2600 and RT2501 [Turbo] (PCI) wireless chipsets.
 
 	  When compiled as a module, this driver will be called "rt61pci.ko".

@@ -91,26 +91,26 @@
 	depends on RT61PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt61 devices that feature a
+	  This adds support for integrated RT2600 and RT2501 devices that feature a
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.
 
 config RT2500USB
-	tristate "Ralink rt2500 usb support"
+	tristate "Ralink RT2500USB support"
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless chip.
+	  This is an experimental driver for the Ralink RT2500USB wireless chipset.
 
 	  When compiled as a module, this driver will be called "rt2500usb.ko".
 
 config RT73USB
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W (USB) support"
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless chip.
+	  This is an experimental driver for the Ralink RT2501USB and RT5201USB wireless chipsets.
 
 	  When compiled as a module, this driver will be called "rt73usb.ko".

---
I wrote this against 2.6.24. This fixed #10440.

Ivo van Doorn

2008-04-12 19:26 UTC #1 lore raw

Hi,

Please CC either me or the rt2400-devel mailinglist for rt2x00 patches. Thanks

Quoted 1 line

Clarify in CONFIG_RT2500USB that proper RT2500 (PCI) is not supported. While at it, capitalize "rt" in Ralink chipsets names and "usb", "pci". Also clarify what RT61 and RT73 refers to. Finally, update CONFIG_RT2X00 now that this isn't just futureware.

Lots of comments for this patch...
I agree with only a handfull of changes.

net/wireless/rt2x00/Kconfig.USB line 6

Quoted 12 lines

Signed-off-by Filipus Klutiero <[email protected]>

---

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

@@ -2,10 +2,10 @@
 	tristate "Ralink driver support"
 	depends on MAC80211 && WLAN_80211 && EXPERIMENTAL
 	---help---
-	  This will enable the experimental support for the Ralink drivers,
+	  This enables the experimental support for the Ralink drivers,
 	  developed in the rt2x00 project <http://rt2x00.serialmonkey.com>.

Ack.

net/wireless/rt2x00/Kconfig.USB line 8

Quoted 2 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	  These drivers will make use of the Devicescape ieee80211 stack.
+	  These drivers use the mac80211 stack.

Against what tree did you create this patch?
I send a patch that fixed this line several weeks/months ago upstream.

net/wireless/rt2x00/Kconfig.USB line 41

Quoted 8 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	  When building one of the individual drivers, the rt2x00 library
 	  will also be created. That library (when the driver is built as

@@ -38,12 +38,12 @@
 	select INPUT_POLLDEV
 
 config RT2400PCI
-	tristate "Ralink rt2400 pci/pcmcia support"
+	tristate "Ralink RT2400 (PCI/PCMCIA) support"

Can't see a real reason for either capatilizing RT or PCI/PCMCIA ...

net/wireless/rt2x00/Kconfig.USB line 79

Quoted 3 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 config RT61PCI
-	tristate "Ralink rt61 pci/pcmcia support"
+	tristate "Ralink RT2561, RT2661 support"

Since we are setting the bus type clearly everywhere else, we shouldn't remove it here...

tristate "Ralink rt2561 & rt2661 pci/pcmcia support"

net/wireless/rt2x00/Kconfig.USB line 85

Quoted 7 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt61 wireless chip.
+	  This is an experimental driver for the Ralink RT2600 and RT2501 [Turbo] (PCI) wireless chipsets.

This is an experimental driver for the Ralink rt2600 andrt2501(Turbo) wireless chipsets.

net/wireless/rt2x00/Kconfig.USB line 94

Quoted 8 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	  When compiled as a module, this driver will be called "rt61pci.ko".

@@ -91,26 +91,26 @@
 	depends on RT61PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt61 devices that feature a
+	  This adds support for integrated RT2600 and RT2501 devices that feature a

Minus capitilization sounds fine

net/wireless/rt2x00/Kconfig.USB line 99

Quoted 6 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.
 
 config RT2500USB
-	tristate "Ralink rt2500 usb support"
+	tristate "Ralink RT2500USB support"

Original version was fine since it is consistent with the rest...

net/wireless/rt2x00/Kconfig.USB line 103

Quoted 5 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless chip.
+	  This is an experimental driver for the Ralink RT2500USB wireless chipset.

See no point in changing this, the config title already states we are talking about USB.

net/wireless/rt2x00/Kconfig.USB line 108

Quoted 5 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	  When compiled as a module, this driver will be called "rt2500usb.ko".
 
 config RT73USB
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W (USB) support"

consistency and don't forget to add all types.
tristate "Ralink rt2571W & rt2671 usb support"

net/wireless/rt2x00/Kconfig.USB line 113

Quoted 6 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless chip.
+	  This is an experimental driver for the Ralink RT2501USB and RT5201USB wireless chipsets.

Those devices doesn't match the config title, so it should be something like:

This is an experimental driver for the Ralink rt2571W and rt2671 wireless chipsets.

Ivo

Filipus Klutiero

author

2008-04-12 20:12 UTC #2 lore raw

Le April 12, 2008 03:28:11 pm Ivo van Doorn, vous avez =E9crit=A0:

Quoted 3 lines

Hi,
=20
Please CC either me or the rt2400-devel mailinglist for rt2x00 patche=

Quoted 3 lines

Thanks
=20
Quoted 1 line
Clarify in CONFIG_RT2500USB that proper RT2500 (PCI) is not support=

ed. While at it, capitalize "rt" in Ralink chipsets names and "usb", "p= ci". Also clarify what RT61 and RT73 refers to. Finally, update CONFIG_= RT2X00 now that this isn't just futureware.

Quoted 8 lines

=20
Lots of comments for this patch...
I agree with only a handfull of changes.
=20
Quoted 4 lines
Signed-off-by Filipus Klutiero <[email protected]>
---
=20
--- drivers/net/wireless/rt2x00/Kconfig 2008-01-24 17:58:37.0000000=

00 -0500

Quoted 1 line

Quoted 1 line
+++ drivers/net/wireless/rt2x00/Kconfig.USB 2008-04-12 03:22:12.000=

000000 -0400

Quoted 5 lines

net/wireless/rt2x00/Kconfig.USB line 5
Quoted 5 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -1
@@ -2,10 +2,10 @@
 	tristate "Ralink driver support"
 	depends on MAC80211 && WLAN_80211 && EXPERIMENTAL
 	---help---
-	  This will enable the experimental support for the Ralink driver=

Quoted 10 lines

Review line 6
Quoted 2 lines
(quoted diff) +1 -0
+	  This enables the experimental support for the Ralink drivers,
 	  developed in the rt2x00 project <http://rt2x00.serialmonkey.com=
.
=20
Ack.
=20
net/wireless/rt2x00/Kconfig.USB line 8
Quoted 2 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	  These drivers will make use of the Devicescape ieee80211 stack.
+	  These drivers use the mac80211 stack.
=20
Against what tree did you create this patch?

2.6.24, as I wrote.

Quoted 1 line

I send a patch that fixed this line several weeks/months ago upstream=

=2E

Quoted 11 lines

=20
net/wireless/rt2x00/Kconfig.USB line 41
Quoted 8 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -0
 	  When building one of the individual drivers, the rt2x00 library
 	  will also be created. That library (when the driver is built as
@@ -38,12 +38,12 @@
 	select INPUT_POLLDEV
=20
config RT2400PCI
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	tristate "Ralink rt2400 pci/pcmcia support"
+	tristate "Ralink RT2400 (PCI/PCMCIA) support"
=20
Can't see a real reason for either capatilizing RT or PCI/PCMCIA ...

rtxxxx refer to the drivers. "rt" is capitalized in the name of the chi= ps. For PCI and PCMCIA, these are abbreviations.

Quoted 7 lines

=20
net/wireless/rt2x00/Kconfig.USB line 79
Quoted 3 lines
config RT61PCI
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	tristate "Ralink rt61 pci/pcmcia support"
+	tristate "Ralink RT2561, RT2661 support"
=20
Since we are setting the bus type clearly everywhere else, we shouldn't remove it here...

The reason I changed it is because the abbreviations weren't capitalize= d, but I simply removed it since RT2561 and RT2661 are only used in PCI=
(or PCMCIA) devices.

Quoted 9 lines

=20
tristate "Ralink rt2561 & rt2661 pci/pcmcia support" =20
net/wireless/rt2x00/Kconfig.USB
Quoted 6 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -1
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt61 wireless chi=

Quoted 1 line

Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the Ralink RT2600 and RT2501=

[Turbo] (PCI) wireless chipsets.

Quoted 2 lines

=20
This is an experimental driver for the Ralink rt2600 andrt2501(Turbo)=

wireless chipsets.
There is "RT2501" and "RT2501 Turbo". The brackets mean that both are s= upported.

Quoted 2 lines

=20
Quoted 1 line
When compiled as a module, this driver will be called "rt61pci.=

ko".

Quoted 7 lines

net/wireless/rt2x00/Kconfig.USB line 94
Quoted 7 lines
=20
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
@@ -91,26 +91,26 @@
 	depends on RT61PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt61 devices that feature a
+	  This adds support for integrated RT2600 and RT2501 devices that=

feature a

Quoted 11 lines

=20
Minus capitilization sounds fine
=20
net/wireless/rt2x00/Kconfig.USB line 99
Quoted 6 lines
(quoted diff) +0 -0
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.
=20
config RT2500USB
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	tristate "Ralink rt2500 usb support"
+	tristate "Ralink RT2500USB support"
=20
Original version was fine since it is consistent with the rest...

See bug #10440. "RT2500" refers to the RT2500 (PCI or PCMCIA) chipset.

Quoted 5 lines

=20
net/wireless/rt2x00/Kconfig.USB
Quoted 4 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -1
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless c=

hip.

Quoted 1 line

Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the Ralink RT2500USB wireles=

s chipset.

Quoted 2 lines

=20
See no point in changing this, the config title already states we are=

talking about USB.
Same as above.

Quoted 2 lines

=20
Quoted 1 line
When compiled as a module, this driver will be called "rt2500us=

b.ko".

Quoted 7 lines

net/wireless/rt2x00/Kconfig.USB line 108
Quoted 4 lines
=20
config RT73USB
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W (USB) support"
=20
consistency and don't forget to add all types. tristate "Ralink rt2571W & rt2671 usb support"

You must know better than me if RT2671 is also supported. I didn't mean=
that my patch fixed everything.

Quoted 6 lines

=20
net/wireless/rt2x00/Kconfig.USB
Quoted 5 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -1
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless chi=

Quoted 1 line

Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the Ralink RT2501USB and RT5=

201USB wireless chipsets.

Quoted 2 lines

=20
Those devices doesn't match the config title, so it should be somethi=

ng like:

Quoted 2 lines

=20
This is an experimental driver for the Ralink rt2571W and rt2671 wire=

less chipsets.
Other extended descriptions only refer to the chipsets. I think the chi= pset should be mentioned because users are more likely to know it than = the MAC chip. OTOH, nothing prevents us from mentioning both. --
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Ivo van Doorn

2008-04-12 20:51 UTC #3 lore raw

Quoted 5 lines

Quoted 4 lines
net/wireless/rt2x00/Kconfig.USB line 8
Quoted 2 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	  These drivers will make use of the Devicescape ieee80211 stack.
+	  These drivers use the mac80211 stack.
Against what tree did you create this patch?
2.6.24, as I wrote.

Hmm the patch doesn't seem to be completely upstream yet.. Probably pending somewhere in wireless-2.6 or wireless-testing.

Doesn't really matter.

Quoted 7 lines

Quoted 7 lines
I send a patch that fixed this line several weeks/months ago upstream.
Quoted 5 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -0
 	  When building one of the individual drivers, the rt2x00 library
 	  will also be created. That library (when the driver is built as
@@ -38,12 +38,12 @@
 	select INPUT_POLLDEV
 

Quoted 6 lines

Quoted 5 lines
net/wireless/rt2x00/Kconfig.USB line 41
Quoted 3 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 config RT2400PCI
-	tristate "Ralink rt2400 pci/pcmcia support"
+	tristate "Ralink RT2400 (PCI/PCMCIA) support"
Can't see a real reason for either capatilizing RT or PCI/PCMCIA ...
rtxxxx refer to the drivers. "rt" is capitalized in the name of the chips. For PCI and PCMCIA, these are abbreviations.

Well the names of the drivers are after the names of the chipset. So the rt can stay as it is now.

Convention seems to be that PCI, PCMCIA and USB are capilitized so that change is fine,
but please make it consistent for all drivers like it currently is. So either put them all between braces or none of them.

Quoted 7 lines

Quoted 6 lines
net/wireless/rt2x00/Kconfig.USB line 79
Quoted 3 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 config RT61PCI
-	tristate "Ralink rt61 pci/pcmcia support"
+	tristate "Ralink RT2561, RT2661 support"
Since we are setting the bus type clearly everywhere else, we shouldn't remove it here...
The reason I changed it is because the abbreviations weren't capitalized, but I simply removed it since RT2561 and RT2661 are only used in PCI (or PCMCIA) devices.

So? rt2400 is only for PCI and rt73 is only for USB. That doesn't matter. This way it is clearer to everybody what kind of device we are talking about. It is also consistent with the other rt2x00 driver entries.

Quoted 11 lines

Quoted 11 lines
tristate "Ralink rt2561 & rt2661 pci/pcmcia support"
net/wireless/rt2x00/Kconfig.USB line 85
Quoted 7 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt61 wireless chip.
+	  This is an experimental driver for the Ralink RT2600 and RT2501 [Turbo] (PCI) wireless chipsets.
This is an experimental driver for the Ralink rt2600 andrt2501(Turbo) wireless chipsets.

Quoted 1 line

There is "RT2501" and "RT2501 Turbo". The brackets mean that both are supported.

Fine.

Quoted 14 lines

Quoted 14 lines
net/wireless/rt2x00/Kconfig.USB line 94
Quoted 8 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 	  When compiled as a module, this driver will be called "rt61pci.ko".
@@ -91,26 +91,26 @@
 	depends on RT61PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt61 devices that feature a
+	  This adds support for integrated RT2600 and RT2501 devices that feature a
Minus capitilization sounds fine
Quoted 3 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -0
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.
 

Quoted 6 lines

Quoted 5 lines
net/wireless/rt2x00/Kconfig.USB line 99
Quoted 3 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 config RT2500USB
-	tristate "Ralink rt2500 usb support"
+	tristate "Ralink RT2500USB support"
Original version was fine since it is consistent with the rest...
See bug #10440. "RT2500" refers to the RT2500 (PCI or PCMCIA) chipset.

So you mean that stating "rt2500 usb" makes people confused to think it is a pci device? The usb label is already mentioned in the subject....

rt2500 is _not_ PCI only, the USB version is the same chipset pasted on a different busconnector.

Quoted 8 lines

Quoted 7 lines
net/wireless/rt2x00/Kconfig.USB line 103
Quoted 5 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless chip.
+	  This is an experimental driver for the Ralink RT2500USB wireless chipset.
See no point in changing this, the config title already states we are talking about USB.
Same as above.

And my comment remains the same.

Quoted 10 lines

Quoted 9 lines
net/wireless/rt2x00/Kconfig.USB line 108
Quoted 6 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 	  When compiled as a module, this driver will be called "rt2500usb.ko".
 
 config RT73USB
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W (USB) support"
consistency and don't forget to add all types.
tristate "Ralink rt2571W & rt2671 usb support"
You must know better than me if RT2671 is also supported. I didn't mean that my patch fixed everything.

I just added it so you can add it when you rebase your patch based on my comments. It is just for completeness.

Quoted 11 lines

Quoted 10 lines
net/wireless/rt2x00/Kconfig.USB line 113
Quoted 6 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless chip.
+	  This is an experimental driver for the Ralink RT2501USB and RT5201USB wireless chipsets.
Those devices doesn't match the config title, so it should be something like:
This is an experimental driver for the Ralink rt2571W and rt2671 wireless chipsets.
Other extended descriptions only refer to the chipsets. I think the chipset should be mentioned because users are more likely to know it than the MAC chip. OTOH, nothing prevents us from mentioning both.

What I am saying is that it will be confusing when the config option subject mentions chip A while the help text mentions chip B. And this patch was focussed on making the text more clear.

Ivo

Filipus Klutiero

author

2008-04-12 22:18 UTC #4 lore raw

Le April 12, 2008 04:53:16 pm Ivo van Doorn, vous avez =E9crit=A0:
[...]

Quoted 2 lines

=20
Quoted 1 line
Quoted 1 line
I send a patch that fixed this line several weeks/months ago upst=

ream.

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
=20
Quoted 1 line
When building one of the individual drivers, the rt2x00 lib=

rary

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
will also be created. That library (when the driver is buil=

t as

Quoted 8 lines

Quoted 8 lines
Quoted 8 lines
net/wireless/rt2x00/Kconfig.USB line 41
Quoted 6 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -0
@@ -38,12 +38,12 @@
 	select INPUT_POLLDEV
=20
config RT2400PCI
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	tristate "Ralink rt2400 pci/pcmcia support"
+	tristate "Ralink RT2400 (PCI/PCMCIA) support"
=20
Can't see a real reason for either capatilizing RT or PCI/PCMCIA =

=2E..

Quoted 1 line

Quoted 1 line
rtxxxx refer to the drivers. "rt" is capitalized in the name of the=

chips. For PCI and PCMCIA, these are abbreviations.

Quoted 2 lines

=20
Well the names of the drivers are after the names of the chipset. So =

the rt can stay as it is now.
They are, but all driver names are lowercase, so capitalization was los= t. The chip names really use capitals.

Quoted 2 lines

=20
Convention seems to be that PCI, PCMCIA and USB are capilitized so th=

at change is fine,

Quoted 1 line

but please make it consistent for all drivers like it currently is. S=

o either put them all between braces or none of them. OK, I put all in parentheses in the following update.

Quoted 8 lines

=20
Quoted 7 lines
Quoted 6 lines
net/wireless/rt2x00/Kconfig.USB line 79
Quoted 3 lines
config RT61PCI
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	tristate "Ralink rt61 pci/pcmcia support"
+	tristate "Ralink RT2561, RT2661 support"
=20
Since we are setting the bus type clearly everywhere else, we shouldn't remove it here...
The reason I changed it is because the abbreviations weren't capita=

lized, but I simply removed it since RT2561 and RT2661 are only used in=
PCI (or PCMCIA) devices.

Quoted 2 lines

=20
So? rt2400 is only for PCI and rt73 is only for USB. That doesn't mat=

ter.

Quoted 1 line

This way it is clearer to everybody what kind of device we are talkin=

g about.
It should already be clear to experienced people if the device is USB o= r PCI. For simple users, they know what they own.

Quoted 1 line

It is also consistent with the other rt2x00 driver entries.

[...]

Quoted 10 lines

Quoted 10 lines
Quoted 9 lines
=20
net/wireless/rt2x00/Kconfig.USB line 99
Quoted 6 lines
(quoted diff) +0 -0
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.
=20
config RT2500USB
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	tristate "Ralink rt2500 usb support"
+	tristate "Ralink RT2500USB support"
=20
Original version was fine since it is consistent with the rest...
See bug #10440. "RT2500" refers to the RT2500 (PCI or PCMCIA) chips=

et.

Quoted 2 lines

=20
So you mean that stating "rt2500 usb" makes people confused to think =

it is a pci device?

Quoted 3 lines

The usb label is already mentioned in the subject....
=20
rt2500 is _not_ PCI only, the USB version is the same chipset pasted =

on a different busconnector.
I'm not really knowledgeable in Ralink, but according to http://ralink.=
rapla.net/ RT2500USB uses different RF and MAC chips than RT2500. Maybe=
you know better.

[...]

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
=20
Quoted 1 line
When compiled as a module, this driver will be called "rt25=

00usb.ko".

Quoted 8 lines

Quoted 8 lines
Quoted 7 lines
net/wireless/rt2x00/Kconfig.USB line 108
Quoted 4 lines
=20
config RT73USB
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W (USB) support"
=20
consistency and don't forget to add all types.
tristate "Ralink rt2571W & rt2671 usb support"
You must know better than me if RT2671 is also supported. I didn't =

mean that my patch fixed everything.

Quoted 2 lines

=20
I just added it so you can add it when you rebase your patch based on=

my comments.

Quoted 1 line

It is just for completeness.

I added it, but I don't know which chipset(s) use RT2671, so the new pa= tch is somewhat incomplete.

Quoted 6 lines

=20
Quoted 5 lines
Quoted 5 lines
net/wireless/rt2x00/Kconfig.USB
Quoted 5 lines
net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -1
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless=

chip.

Quoted 1 line

Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the Ralink RT2501USB and=

RT5201USB wireless chipsets.

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
=20
Those devices doesn't match the config title, so it should be som=

ething like:

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
=20
This is an experimental driver for the Ralink rt2571W and rt2671 =

wireless chipsets.

Quoted 1 line

Quoted 1 line
Other extended descriptions only refer to the chipsets. I think the=

chipset should be mentioned because users are more likely to know it t=
han the MAC chip. OTOH, nothing prevents us from mentioning both.

Quoted 2 lines

=20
What I am saying is that it will be confusing when the config option =

subject mentions chip A while

Quoted 1 line

the help text mentions chip B. And this patch was focussed on making =

the text more clear.
Yes, but it's IMHO more important that users that only know the chipset=
can find the driver. Anyway, I added the supported chips too.
---

--- drivers/net/wireless/rt2x00/Kconfig 2008-01-24 17:58:37.000000000 -=
0500
+++ drivers/net/wireless/rt2x00/Kconfig.USB 2008-04-12 18:12:06.0000000=
00 -0400
@@ -2,10 +2,10 @@
tristate "Ralink driver support"
depends on MAC80211 && WLAN_80211 && EXPERIMENTAL ---help---
- This will enable the experimental support for the Ralink drivers,
+ This enables the experimental support for the Ralink drivers,
developed in the rt2x00 project <http://rt2x00.serialmonkey.com>.
=20
- These drivers will make use of the Devicescape ieee80211 stack.
+ These drivers use the mac80211 stack.
=20
When building one of the individual drivers, the rt2x00 library will also be created. That library (when the driver is built as
@@ -38,12 +38,12 @@
select INPUT_POLLDEV
=20
config RT2400PCI
- tristate "Ralink rt2400 pci/pcmcia support"
+ tristate "Ralink RT2400 (PCI/PCMCIA) support"
depends on RT2X00 && PCI
select RT2X00_LIB_PCI
select EEPROM_93CX6
---help---
- This is an experimental driver for the Ralink rt2400 wireless chip.
+ This is an experimental driver for the Ralink RT2400 wireless chips=
et.
=20
When compiled as a module, this driver will be called "rt2400pci.ko=
".
=20
@@ -52,17 +52,17 @@
depends on RT2400PCI
select RT2X00_LIB_RFKILL
---help---
- This adds support for integrated rt2400 devices that feature a
+ This adds support for integrated RT2400 devices that feature a
hardware button to control the radio state.
This feature depends on the RF switch subsystem rfkill.
=20
config RT2500PCI
- tristate "Ralink rt2500 pci/pcmcia support"
+ tristate "Ralink RT2500 (PCI/PCMCIA) support"
depends on RT2X00 && PCI
select RT2X00_LIB_PCI
select EEPROM_93CX6
---help---
- This is an experimental driver for the Ralink rt2500 wireless chip.
+ This is an experimental driver for the Ralink RT2500 wireless chips=
et.
=20
When compiled as a module, this driver will be called "rt2500pci.ko=
".
=20
@@ -71,18 +71,18 @@
depends on RT2500PCI
select RT2X00_LIB_RFKILL
---help---
- This adds support for integrated rt2500 devices that feature a
+ This adds support for integrated RT2500 devices that feature a
hardware button to control the radio state.
This feature depends on the RF switch subsystem rfkill.
=20
config RT61PCI
- tristate "Ralink rt61 pci/pcmcia support"
+ tristate "Ralink RT2561 and RT2661 (PCI) support"
depends on RT2X00 && PCI
select RT2X00_LIB_PCI
select RT2X00_LIB_FIRMWARE
select EEPROM_93CX6
---help---
- This is an experimental driver for the Ralink rt61 wireless chip.
+ This is an experimental driver for the Ralink RT2600 and RT2501 [Tu=
rbo] (PCI) wireless chipsets.
=20
When compiled as a module, this driver will be called "rt61pci.ko".
=20
@@ -91,26 +91,26 @@
depends on RT61PCI
select RT2X00_LIB_RFKILL
---help---
- This adds support for integrated rt61 devices that feature a
+ This adds support for integrated RT2600 and RT2501 devices that fea=
ture a
hardware button to control the radio state.
This feature depends on the RF switch subsystem rfkill.
=20
config RT2500USB
- tristate "Ralink rt2500 usb support"
+ tristate "Ralink RT2500USB support"
depends on RT2X00 && USB
select RT2X00_LIB_USB
---help---
- This is an experimental driver for the Ralink rt2500 wireless chip.
+ This is an experimental driver for the Ralink RT2500USB wireless ch=
ipset.
=20
When compiled as a module, this driver will be called "rt2500usb.ko=
".
=20
config RT73USB
- tristate "Ralink rt73 usb support"
+ tristate "Ralink RT2571W and RT2671 (USB) support"
depends on RT2X00 && USB
select RT2X00_LIB_USB
select RT2X00_LIB_FIRMWARE
---help---
- This is an experimental driver for the Ralink rt73 wireless chip.
+ This is an experimental driver for the RT2571W and RT2671 MAC/BBP c=
hips. It supports Ralink RT2501USB and RT5201USB wireless chipsets. =20
When compiled as a module, this driver will be called "rt73usb.ko".
=20
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Ivo van Doorn

2008-04-13 10:41 UTC #5 lore raw

Quoted 5 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -0
@@ -2,10 +2,10 @@
 	tristate "Ralink driver support"
 	depends on MAC80211 && WLAN_80211 && EXPERIMENTAL

net/wireless/rt2x00/Kconfig.USB line 11

Quoted 10 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +2 -2

 	---help---
-	  This will enable the experimental support for the Ralink drivers,
+	  This enables the experimental support for the Ralink drivers,
 	  developed in the rt2x00 project <http://rt2x00.serialmonkey.com>.
 
-	  These drivers will make use of the Devicescape ieee80211 stack.
+	  These drivers use the mac80211 stack.
 
 	  When building one of the individual drivers, the rt2x00 library
 	  will also be created. That library (when the driver is built as

These 2 changes are fine.

Quoted 4 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +0 -0
@@ -38,12 +38,12 @@
 	select INPUT_POLLDEV
 
 config RT2400PCI

net/wireless/rt2x00/Kconfig.USB line 48

Quoted 10 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +2 -2

-	tristate "Ralink rt2400 pci/pcmcia support"
+	tristate "Ralink RT2400 (PCI/PCMCIA) support"
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt2400 wireless chip.
+	  This is an experimental driver for the Ralink RT2400 wireless chipset.
 
 	  When compiled as a module, this driver will be called "rt2400pci.ko".

I ask again, please keep the RT lowercase.

net/wireless/rt2x00/Kconfig.USB

Quoted 3 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1
 config RT61PCI
-	tristate "Ralink rt61 pci/pcmcia support"
+	tristate "Ralink RT2561 and RT2661 (PCI) support"

I can't see why you are overly obsessed with changing the device type here. There are rt61 PCMCIA cards so make it:

+ tristate "Ralink rt2561 and rt2661 (PCI/PCMCIA) support"

net/wireless/rt2x00/Kconfig.USB

Quoted 7 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt61 wireless chip.
+	  This is an experimental driver for the Ralink RT2600 and RT2501 [Turbo] (PCI) wireless chipsets.

Again: It doesn't make any sense to claim support for chip A in the subject and chip B in the help text. Furthermore you don't need to repeat the (PCI) here, since it is already clear from the subject and it isn't in the help text for the other drivers either.

net/wireless/rt2x00/Kconfig.USB line 94

Quoted 8 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	  When compiled as a module, this driver will be called "rt61pci.ko".

@@ -91,26 +91,26 @@
 	depends on RT61PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt61 devices that feature a
+	  This adds support for integrated RT2600 and RT2501 devices that feature a

Same here, the driver is for rt2561 and rt2661

net/wireless/rt2x00/Kconfig.USB line 99

Quoted 6 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.
 
 config RT2500USB
-	tristate "Ralink rt2500 usb support"
+	tristate "Ralink RT2500USB support"

Again:
- tristate "Ralink rt2500 (USB) support"
This is consistent with the rest where (PCI) is used.
A space between rt2500 and usb should not give people the impression we are suddenly talking about PCI hardware.

Another option if that makes you happy is that you could rename it to rt2570 if you really want to differentiate between rt2500 usb and rt2500 pci.

net/wireless/rt2x00/Kconfig.USB line 103

Quoted 5 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +1 -1

 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless chip.
+	  This is an experimental driver for the Ralink RT2500USB wireless chipset.

Again:
+ This is an experimental driver for the Ralink RT2500 wireless chipset.

net/wireless/rt2x00/Kconfig.USB line 113

Quoted 12 lines

net/wireless/rt2x00/Kconfig.USB renamed from net/wireless/rt2x00/Kconfig +2 -2

 	  When compiled as a module, this driver will be called "rt2500usb.ko".
 
 config RT73USB
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W and RT2671 (USB) support"
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless chip.
+	  This is an experimental driver for the RT2571W and RT2671 MAC/BBP chips. It supports Ralink RT2501USB and RT5201USB wireless chipsets.
 	  When compiled as a module, this driver will be called "rt73usb.ko".

*sigh* you seem to be absolutely sure you want to break any form of consistency in the rt2x00 KConfig entry. So to show how I would like to see it I have the following patch. Unless you have objections against below changes I will push this forward.

---

drivers/net/wireless/rt2x00/Kconfig +13 ~~-14~~

index a1e3938..7f093cc 100644
@@ -40,12 +40,12 @@ config RT2X00_LIB_LEDS
 	depends on RT2X00_LIB
 
 config RT2400PCI
-	tristate "Ralink rt2400 pci/pcmcia support"
+	tristate "Ralink rt2400 (PCI/PCMCIA) support"
 	depends on PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt2400 wireless chip.
+	  This is the experimental rt2400pci driver for the Ralink rt2460 wireless chip.
 
 	  When compiled as a module, this driver will be called "rt2400pci.ko".

@@ -54,7 +54,7 @@ config RT2400PCI_RFKILL
 	depends on RT2400PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt2400 devices that feature a
+	  This adds support for integrated rt2400 hardware that features a
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.

@@ -66,12 +66,12 @@ config RT2400PCI_LEDS
 	  This adds support for led triggers provided my mac80211.
 
 config RT2500PCI
-	tristate "Ralink rt2500 pci/pcmcia support"
+	tristate "Ralink rt2500 (PCI/PCMCIA) support"
 	depends on PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless chip.
+	  This is the experimental rt2500pci driver for the Ralink rt2560 wireless chip.
 
 	  When compiled as a module, this driver will be called "rt2500pci.ko".

@@ -80,7 +80,7 @@ config RT2500PCI_RFKILL
 	depends on RT2500PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt2500 devices that feature a
+	  This adds support for integrated rt2500 hardware that feature a
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.

@@ -92,14 +92,14 @@ config RT2500PCI_LEDS
 	  This adds support for led triggers provided my mac80211.
 
 config RT61PCI
-	tristate "Ralink rt61 pci/pcmcia support"
+	tristate "Ralink rt61 (PCI/PCMCIA) support"
 	depends on PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select CRC_ITU_T
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt61 wireless chip.
+	  This is the experimental rt61pci driver for the Ralink rt2561 and rt2661 wireless chips.
 
 	  When compiled as a module, this driver will be called "rt61pci.ko".

@@ -108,7 +108,7 @@ config RT61PCI_RFKILL
 	depends on RT61PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt61 devices that feature a
+	  This adds support for integrated rt61 hardware that feature a
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.

@@ -120,11 +120,11 @@ config RT61PCI_LEDS
 	  This adds support for led triggers provided my mac80211.
 
 config RT2500USB
-	tristate "Ralink rt2500 usb support"
+	tristate "Ralink rt2500 (USB) support"
 	depends on USB
 	select RT2X00_LIB_USB
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless chip.
+	  This is the experimental rt2500usb driver for the Ralink rt2570 wireless chip.
 
 	  When compiled as a module, this driver will be called "rt2500usb.ko".

@@ -136,14 +136,13 @@ config RT2500USB_LEDS
 	  This adds support for led triggers provided my mac80211.
 
 config RT73USB
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink rt73 (USB) support"
 	depends on USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	select CRC_ITU_T
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless chip.
-
+	  This is the experimental rt73usb driver for the Ralink rt2571W and rt2671 wireless chips.
 	  When compiled as a module, this driver will be called "rt73usb.ko".
 
 config RT73USB_LEDS

Filipus Klutiero

author

2008-04-14 06:37 UTC #6 lore raw

Le April 13, 2008 06:44:05 am Ivo van Doorn, vous avez =E9crit=A0:
[...]

Quoted 12 lines

=20
drivers/net/wireless/rt2x00/Kconfig config RT2X00_LIB_LEDS
Quoted 11 lines
(quoted diff) +0 -0
@@ -38,12 +38,12 @@
 	select INPUT_POLLDEV
=20
config RT2400PCI
drivers/net/wireless/rt2x00/Kconfig +1 -2
-	tristate "Ralink rt2400 pci/pcmcia support"
+	tristate "Ralink RT2400 (PCI/PCMCIA) support"
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt2400 wireless c=

hip.

Quoted 1 line

Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the Ralink RT2400 wireless c=

hipset.

Quoted 2 lines

Quoted 2 lines
=20
When compiled as a module, this driver will be called "rt2400pc=

i.ko".

Quoted 2 lines

=20
I ask again, please keep the RT lowercase.

As I wrote, "rt" is capitalized in the name of the chips. I am not a Ra= link expert though, so feel free to point to a reference where "rt" is = lowercase if both forms are valid.

Quoted 6 lines

=20
Review
Quoted 3 lines
config RT61PCI
(quoted diff) +1 -1
-	tristate "Ralink rt61 pci/pcmcia support"
+	tristate "Ralink RT2561 and RT2661 (PCI) support"
=20
I can't see why you are overly obsessed with changing the device type=

here.

Review

Quoted 3 lines

There are rt61 PCMCIA cards so make it:
=20
(quoted diff) +1 -0
+	tristate "Ralink rt2561 and rt2661 (PCI/PCMCIA) support"

Ah, that's not an obsession but it's the way it was in both versions. I=
removed "pcmcia" because it wasn't capitalized, before we started tryi=
ng to make it consistent. I made it consistent in the new patch.

Quoted 7 lines

=20
drivers/net/wireless/rt2x00/Kconfig config RT2500PCI_LEDS
Quoted 6 lines
drivers/net/wireless/rt2x00/Kconfig +0 -1
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt61 wireless chi=

Quoted 1 line

Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the Ralink RT2600 and RT2501=

[Turbo] (PCI) wireless chipsets.

Quoted 2 lines

=20
Again: It doesn't make any sense to claim support for chip A in the s=

ubject and chip B in the help text.
A is the MAC chip, B is the chipset. Anyway, I forgot that entry when d= oing the version which was supposed to be consistent. I changed it in t= he new patch.

Quoted 1 line

Furthermore you don't need to repeat the (PCI) here, since it is alre=

ady clear from the subject and

Quoted 1 line

it isn't in the help text for the other drivers either.

Right.

Quoted 2 lines

=20
Quoted 1 line
When compiled as a module, this driver will be called "rt61pci.=

ko".

Quoted 7 lines

drivers/net/wireless/rt2x00/Kconfig config RT61PCI_RFKILL · line 94
Quoted 7 lines
=20
drivers/net/wireless/rt2x00/Kconfig +1 -1
@@ -91,26 +91,26 @@
 	depends on RT61PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt61 devices that feature a
+	  This adds support for integrated RT2600 and RT2501 devices that=

feature a

Quoted 2 lines

=20
Same here, the driver is for rt2561 and rt2661

Changed.

Quoted 10 lines

=20

Review

Quoted 6 lines

(quoted diff) +0 -0

 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.

=20
config RT2500USB

(quoted diff) +1 -1

-	tristate "Ralink rt2500 usb support"
+	tristate "Ralink RT2500USB support"

=20
Again:

(quoted diff) +0 -1

-	tristate "Ralink rt2500 (USB) support"

Quoted 2 lines

This is consistent with the rest where (PCI) is used.
A space between rt2500 and usb should not give people the impression =

we are

Quoted 3 lines

suddenly talking about PCI hardware.
=20
Another option if that makes you happy is that you could rename it to=

rt2570

Quoted 1 line

if you really want to differentiate between rt2500 usb and rt2500 pci=

=2E
We already discussed that in previous messages.

Quoted 5 lines

=20
drivers/net/wireless/rt2x00/Kconfig config RT61PCI_LEDS
Quoted 4 lines
drivers/net/wireless/rt2x00/Kconfig +0 -1
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless c=

hip.

Quoted 1 line

Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the Ralink RT2500USB wireles=

s chipset.

Review

Quoted 3 lines

=20
Again:

(quoted diff) +1 -0

+	  This is an experimental driver for the Ralink RT2500 wireless chi=

pset.
As above.

Quoted 1 line

Quoted 1 line
When compiled as a module, this driver will be called "rt2500us=

b.ko".

Quoted 9 lines

drivers/net/wireless/rt2x00/Kconfig config RT2500USB_LEDS
Quoted 9 lines
=20
config RT73USB
drivers/net/wireless/rt2x00/Kconfig +1 -2
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W and RT2671 (USB) support"
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless chi=

Quoted 1 line

Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the RT2571W and RT2671 MAC/B=

BP chips. It supports Ralink RT2501USB and RT5201USB wireless chipsets.

Quoted 1 line

Quoted 1 line
When compiled as a module, this driver will be called "rt73usb.=

ko".

Quoted 2 lines

=20
*sigh* you seem to be absolutely sure you want to break any form of c=

onsistency in the rt2x00 KConfig entry.

Quoted 1 line

So to show how I would like to see it I have the following patch. Unl=

ess you have objections against below changes

Quoted 1 line

I will push this forward.

No objection, but note that:
* this has both "hardware that feature*s*" and "hardware that feature"
* The names of drivers are duplicated and not exactly the same. For exa= mple, "This is the experimental rt2500pci driver [...]" vs "[...] this = driver will be called "rt2500pci.ko"".

Here is the third version of my patch.
---

--- drivers/net/wireless/rt2x00/Kconfig 2008-01-24 17:58:37.000000000 -=
0500
+++ drivers/net/wireless/rt2x00/Kconfig.USB 2008-04-14 02:29:37.0000000=
00 -0400
@@ -2,10 +2,10 @@
tristate "Ralink driver support"
depends on MAC80211 && WLAN_80211 && EXPERIMENTAL ---help---
- This will enable the experimental support for the Ralink drivers,
+ This enables the experimental support for the Ralink drivers,
developed in the rt2x00 project <http://rt2x00.serialmonkey.com>.
=20
- These drivers will make use of the Devicescape ieee80211 stack.
+ These drivers use the mac80211 stack.
=20
When building one of the individual drivers, the rt2x00 library will also be created. That library (when the driver is built as
@@ -38,12 +38,12 @@
select INPUT_POLLDEV
=20
config RT2400PCI
- tristate "Ralink rt2400 pci/pcmcia support"
+ tristate "Ralink RT2400 (PCI/PCMCIA) support"
depends on RT2X00 && PCI
select RT2X00_LIB_PCI
select EEPROM_93CX6
---help---
- This is an experimental driver for the Ralink rt2400 wireless chip.
+ This is an experimental driver for the Ralink RT2400 wireless chips=
et.
=20
When compiled as a module, this driver will be called "rt2400pci.ko=
".
=20
@@ -52,17 +52,17 @@
depends on RT2400PCI
select RT2X00_LIB_RFKILL
---help---
- This adds support for integrated rt2400 devices that feature a
+ This adds support for integrated RT2400 devices that feature a
hardware button to control the radio state.
This feature depends on the RF switch subsystem rfkill.
=20
config RT2500PCI
- tristate "Ralink rt2500 pci/pcmcia support"
+ tristate "Ralink RT2500 (PCI/PCMCIA) support"
depends on RT2X00 && PCI
select RT2X00_LIB_PCI
select EEPROM_93CX6
---help---
- This is an experimental driver for the Ralink rt2500 wireless chip.
+ This is an experimental driver for the Ralink RT2500 wireless chips=
et.
=20
When compiled as a module, this driver will be called "rt2500pci.ko=
".
=20
@@ -71,18 +71,18 @@
depends on RT2500PCI
select RT2X00_LIB_RFKILL
---help---
- This adds support for integrated rt2500 devices that feature a
+ This adds support for integrated RT2500 devices that feature a
hardware button to control the radio state.
This feature depends on the RF switch subsystem rfkill.
=20
config RT61PCI
- tristate "Ralink rt61 pci/pcmcia support"
+ tristate "Ralink RT2561 and RT2661 (PCI/PCMCIA) support"
depends on RT2X00 && PCI
select RT2X00_LIB_PCI
select RT2X00_LIB_FIRMWARE
select EEPROM_93CX6
---help---
- This is an experimental driver for the Ralink rt61 wireless chip.
+ This is an experimental driver for the Ralink RT2561 and RT2661 MAC=
/BBP chips. It supports RT2600 and RT2501 [Turbo] wireless chipsets. =20
When compiled as a module, this driver will be called "rt61pci.ko".
=20
@@ -91,26 +91,26 @@
depends on RT61PCI
select RT2X00_LIB_RFKILL
---help---
- This adds support for integrated rt61 devices that feature a
+ This adds support for integrated RT2561 and RT2661 devices that fea=
ture a
hardware button to control the radio state.
This feature depends on the RF switch subsystem rfkill.
=20
config RT2500USB
- tristate "Ralink rt2500 usb support"
+ tristate "Ralink RT2500USB support"
depends on RT2X00 && USB
select RT2X00_LIB_USB
---help---
- This is an experimental driver for the Ralink rt2500 wireless chip.
+ This is an experimental driver for the Ralink RT2500USB wireless ch=
ipset.
=20
When compiled as a module, this driver will be called "rt2500usb.ko=
".
=20
config RT73USB
- tristate "Ralink rt73 usb support"
+ tristate "Ralink RT2571W and RT2671 (USB) support"
depends on RT2X00 && USB
select RT2X00_LIB_USB
select RT2X00_LIB_FIRMWARE
---help---
- This is an experimental driver for the Ralink rt73 wireless chip.
+ This is an experimental driver for the Ralink RT2571W and RT2671 MA=
C/BBP chips. It supports RT2501USB and RT5201USB wireless chipsets. =20
When compiled as a module, this driver will be called "rt73usb.ko".
=20
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Ivo van Doorn

NAK

2008-04-14 11:30 UTC #7 lore raw

Quoted 1 line

Quoted 1 line
Quoted 1 line
When compiled as a module, this driver will be called "rt2500=

usb.ko".

Quoted 9 lines

Quoted 9 lines
drivers/net/wireless/rt2x00/Kconfig config RT2500USB_LEDS
Quoted 9 lines
=20
config RT73USB
drivers/net/wireless/rt2x00/Kconfig +1 -2
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W and RT2671 (USB) support"
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless c=

hip.

Quoted 1 line

Quoted 1 line
Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the RT2571W and RT2671 MAC=

/BBP chips. It supports Ralink RT2501USB and RT5201USB wireless chipset= s.

Quoted 1 line

Quoted 1 line
Quoted 1 line
When compiled as a module, this driver will be called "rt73us=

b.ko".

Quoted 2 lines

Quoted 2 lines
=20
*sigh* you seem to be absolutely sure you want to break any form of=

consistency in the rt2x00 KConfig entry.

Quoted 1 line

Quoted 1 line
So to show how I would like to see it I have the following patch. U=

nless you have objections against below changes

Quoted 3 lines

Quoted 1 line
I will push this forward.
No objection, but note that:
* this has both "hardware that feature*s*" and "hardware that featur=

I'll fix that.

Quoted 1 line

* The names of drivers are duplicated and not exactly the same. For e=

xample, "This is the experimental rt2500pci driver [...]" vs "[...] thi= s driver will be called "rt2500pci.ko"".

I'll change that to:
This is the experimental rt2500pci driver [...]" vs "[...] the module w= ill be called "rt2500pci.ko"".

Quoted 1 line

Here is the third version of my patch.

NACK

All my complaints about your previous patch still aplies to this new on= e,
and I am not going to repeat myself over and over again for exactly the=
same.

As for the bug this patch is supposedly going to fix,
the config option is named:
tristate "Ralink rt2500 usb support"
How can people confuse that with pci support?
=DDour patch suggests the confusion is to blame because there is a spac= e
between rt2500 and usb, and that usb isn't capitalized...

I'll update my previous patch with some additional chipset notices and = send that upstream in a few days.
I'll consider this issue (including the bug report) closed after that.

Ivo

Quoted 3 lines

---
=20
--- drivers/net/wireless/rt2x00/Kconfig 2008-01-24 17:58:37.000000000=

-0500

Quoted 1 line

+++ drivers/net/wireless/rt2x00/Kconfig.USB 2008-04-14 02:29:37.00000=

0000 -0400

Quoted 17 lines

(quoted diff) +1 -1

@@ -2,10 +2,10 @@
 	tristate "Ralink driver support"
 	depends on MAC80211 && WLAN_80211 && EXPERIMENTAL
 	---help---
-	  This will enable the experimental support for the Ralink drivers,
+	  This enables the experimental support for the Ralink drivers,
 	  developed in the rt2x00 project <http://rt2x00.serialmonkey.com>.

=20

(quoted diff) +1 -1

-	  These drivers will make use of the Devicescape ieee80211 stack.
+	  These drivers use the mac80211 stack.

=20

(quoted diff) +0 -0

 	  When building one of the individual drivers, the rt2x00 library
 	  will also be created. That library (when the driver is built as

@@ -38,12 +38,12 @@
 	select INPUT_POLLDEV

=20
config RT2400PCI

drivers/net/wireless/rt2x00/Kconfig config RT2X00_LIB_LEDS

Quoted 7 lines

drivers/net/wireless/rt2x00/Kconfig +1 -2

-	tristate "Ralink rt2400 pci/pcmcia support"
+	tristate "Ralink RT2400 (PCI/PCMCIA) support"
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt2400 wireless chi=

Review

Quoted 1 line

(quoted diff) +1 -0

+	  This is an experimental driver for the Ralink RT2400 wireless chi=

pset.

Quoted 2 lines

=20
When compiled as a module, this driver will be called "rt2400pci.=

ko".

Quoted 11 lines

=20

drivers/net/wireless/rt2x00/Kconfig +1 -1

@@ -52,17 +52,17 @@
 	depends on RT2400PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt2400 devices that feature a
+	  This adds support for integrated RT2400 devices that feature a
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.

=20
config RT2500PCI

drivers/net/wireless/rt2x00/Kconfig config RT2400PCI_LEDS

Quoted 7 lines

drivers/net/wireless/rt2x00/Kconfig +1 -2

-	tristate "Ralink rt2500 pci/pcmcia support"
+	tristate "Ralink RT2500 (PCI/PCMCIA) support"
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless chi=

Review

Quoted 1 line

(quoted diff) +1 -0

+	  This is an experimental driver for the Ralink RT2500 wireless chi=

pset.

Quoted 2 lines

=20
When compiled as a module, this driver will be called "rt2500pci.=

ko".

Quoted 11 lines

=20

drivers/net/wireless/rt2x00/Kconfig +1 -1

@@ -71,18 +71,18 @@
 	depends on RT2500PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt2500 devices that feature a
+	  This adds support for integrated RT2500 devices that feature a
 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.

=20
config RT61PCI

drivers/net/wireless/rt2x00/Kconfig config RT2500PCI_LEDS

Quoted 9 lines

drivers/net/wireless/rt2x00/Kconfig +2 -2

-	tristate "Ralink rt61 pci/pcmcia support"
+	tristate "Ralink RT2561 and RT2661 (PCI/PCMCIA) support"
 	depends on RT2X00 && PCI
 	select RT2X00_LIB_PCI
 	select RT2X00_LIB_FIRMWARE
 	select EEPROM_93CX6
 	---help---
-	  This is an experimental driver for the Ralink rt61 wireless chip.
+	  This is an experimental driver for the Ralink RT2561 and RT2661 M=

AC/BBP chips. It supports RT2600 and RT2501 [Turbo] wireless chipsets.

Quoted 2 lines

=20
When compiled as a module, this driver will be called "rt61pci.ko=

drivers/net/wireless/rt2x00/Kconfig config RT61PCI_RFKILL · line 94

Quoted 7 lines

=20

drivers/net/wireless/rt2x00/Kconfig +1 -1

@@ -91,26 +91,26 @@
 	depends on RT61PCI
 	select RT2X00_LIB_RFKILL
 	---help---
-	  This adds support for integrated rt61 devices that feature a
+	  This adds support for integrated RT2561 and RT2661 devices that f=

eature a

drivers/net/wireless/rt2x00/Kconfig config RT61PCI_LEDS

Quoted 10 lines

(quoted diff) +0 -0

 	  hardware button to control the radio state.
 	  This feature depends on the RF switch subsystem rfkill.

=20
config RT2500USB

drivers/net/wireless/rt2x00/Kconfig +1 -2

-	tristate "Ralink rt2500 usb support"
+	tristate "Ralink RT2500USB support"
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	---help---
-	  This is an experimental driver for the Ralink rt2500 wireless chi=

Review

Quoted 1 line

(quoted diff) +1 -0

+	  This is an experimental driver for the Ralink RT2500USB wireless =

chipset.

Quoted 2 lines

=20
When compiled as a module, this driver will be called "rt2500usb.=

ko".

drivers/net/wireless/rt2x00/Kconfig config RT2500USB_LEDS

Quoted 10 lines

=20
config RT73USB

drivers/net/wireless/rt2x00/Kconfig +2 -2

-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W and RT2671 (USB) support"
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless chip.
+	  This is an experimental driver for the Ralink RT2571W and RT2671 =

MAC/BBP chips. It supports RT2501USB and RT5201USB wireless chipsets.

Quoted 2 lines

=20
When compiled as a module, this driver will be called "rt73usb.ko=

Quoted 3 lines

=20
=20
---------------------------------------------------------------------=

----

Quoted 2 lines

This SF.net email is sponsored by the 2008 JavaOne(SM) Conference=20 Don't miss this year's exciting event. There's still time to save $10=

0.=20

Quoted 2 lines

Use priority code J8TL2D2.=20
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.co=

m/javaone

Quoted 5 lines

_______________________________________________
Rt2400-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/rt2400-devel
=20

--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Filipus Klutiero

author

2008-04-20 18:20 UTC #8 lore raw

Le April 14, 2008 07:33:32 am Ivo van Doorn, vous avez =E9crit=A0:

Quoted 11 lines

Quoted 11 lines
Quoted 11 lines
drivers/net/wireless/rt2x00/Kconfig config RT2500USB_LEDS
Quoted 11 lines
When compiled as a module, this driver will be called
"rt2500usb.ko".
config RT73USB
drivers/net/wireless/rt2x00/Kconfig +1 -2
-	tristate "Ralink rt73 usb support"
+	tristate "Ralink RT2571W and RT2671 (USB) support"
 	depends on RT2X00 && USB
 	select RT2X00_LIB_USB
 	select RT2X00_LIB_FIRMWARE
 	---help---
-	  This is an experimental driver for the Ralink rt73 wireless=

chip.

Quoted 1 line

Quoted 1 line
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +1 -0
+	  This is an experimental driver for the RT2571W and RT2671 M=

AC/BBP

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
chips. It supports Ralink RT2501USB and RT5201USB wireless chip=

sets.

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
When compiled as a module, this driver will be called "rt73usb.=

ko".

Quoted 2 lines

Quoted 2 lines
Quoted 2 lines
*sigh* you seem to be absolutely sure you want to break any form =

Quoted 1 line

Quoted 1 line
Quoted 1 line
consistency in the rt2x00 KConfig entry. So to show how I would l=

ike to

Quoted 1 line

Quoted 1 line
Quoted 1 line
see it I have the following patch. Unless you have objections aga=

inst

Quoted 4 lines

Quoted 4 lines
Quoted 1 line
below changes I will push this forward.
No objection, but note that:
* this has both "hardware that feature*s*" and "hardware that feat=

ure"

Quoted 5 lines

I'll fix that.
Quoted 2 lines
* The names of drivers are duplicated and not exactly the same. For example, "This is the experimental rt2500pci driver [...]" vs "[...=

] this

Quoted 4 lines

Quoted 1 line
driver will be called "rt2500pci.ko"".
I'll change that to:
This is the experimental rt2500pci driver [...]" vs "[...] the module=

will

Quoted 7 lines

be called "rt2500pci.ko"".
Quoted 1 line
Here is the third version of my patch.
NACK
All my complaints about your previous patch still aplies to this new =

one,

Quoted 1 line

and I am not going to repeat myself over and over again for exactly t=

Quoted 1 line

same.

Certainly not; my last update was specifically to address some of your=20 complaints. Which one(s) did I forget to address?

Quoted 6 lines

As for the bug this patch is supposedly going to fix,
the config option is named:
tristate "Ralink rt2500 usb support"
How can people confuse that with pci support?
=DDour patch suggests the confusion is to blame because there is a sp=

ace

Quoted 1 line

between rt2500 and usb, and that usb isn't capitalized...

It's the text quoted in the bug report which *might* be confusing. Lack=
of=20
capitalization isn't going to confuse anyone, of course.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html