b43legacy: fix initvals loading on bcm4303

PATCH In review Stefano Brivio 1 participant 2 messages Apr 6, 2008 – Apr 13, 2008 Networking drivers (wireless)

Share & tools

Stefano Brivio

author

2008-04-06 15:11 UTC #0 lore raw

PATCH 1/1 b43legacy: fix initvals loading on bcm4303

This allows for the correct initial values to be uploaded to bcm4303 devices. It should be correct, but I can't reliably test this as I suspect there's something going wrong with an hardware rfkill switch on my laptop. Please test.

Signed-off-by Stefano Brivio <[email protected]>

---
Please note that for this patch to be tested a previous patch:
'b43legacy: fix bcm4303 crash'
needs to be applied.
---

drivers/net/wireless/b43legacy/main.c +2 -0

Index: bcm-testing/drivers/net/wireless/b43legacy/main.c
===================================================================
@@ -1516,6 +1516,7 @@ static int b43legacy_request_firmware(st
 	}
 	if (!fw->initvals) {
 		switch (dev->phy.type) {
+		case B43legacy_PHYTYPE_B:
 		case B43legacy_PHYTYPE_G:
 			if ((rev >= 5) && (rev <= 10))
 				filename = "b0g0initvals5";

@@ -1533,6 +1534,7 @@ static int b43legacy_request_firmware(st
 	}
 	if (!fw->initvals_band) {
 		switch (dev->phy.type) {
+		case B43legacy_PHYTYPE_B:
 		case B43legacy_PHYTYPE_G:
 			if ((rev >= 5) && (rev <= 10))
 				filename = "b0g0bsinitvals5";

--
Ciao
Stefano

Stefano Brivio

author

2008-04-13 23:12 UTC #1 lore raw

Quoted 8 lines · On Sun, 6 Apr 2008 17:10:53 +0200 Stefano Brivio <[email protected]>…

This allows for the correct initial values to be uploaded to bcm4303 devices. It should be correct, but I can't reliably test this as I suspect there's something going wrong with an hardware rfkill switch on my laptop. Please test.
Signed-off-by Stefano Brivio <[email protected]>
---
[...]

John, please go ahead with this, as it makes bcm4303 devices partially working.

Thanks.

--
Ciao
Stefano