pnpacpi: reduce printk severity for "pnpacpi: exceeded the max number of ..."

PATCH New Len Brown 1 participant 1 message Apr 15, 2008 ACPI

lore

Share & tools

lore

Len Brown

author reviewer

2008-04-15 07:17 UTC #0 lore raw

PATCH 1/1 pnpacpi: reduce printk severity for "pnpacpi: exceeded the max number of ..."

From: Len Brown <[email protected]>

We have been printing these messages at KERN_ERR since 2.6.24, per http://bugzilla.kernel.org/show_bug.cgi?id=9535

But KERN_ERR pops up on a console booted with "quiet" and causes users to get alarmed and file bugs about the message itself:
https://bugzilla.redhat.com/show_bug.cgi?id=436589

So reduce the severity of these messages to KERN_WARNING, which is not printed by "quiet".

This message will still be seen without "quiet", but a lot of messages are printed in that mode and it will be less likely to cause undue alarm.

We could go all the way to KERN_DEBUG, but this is a real warning after all, so it seems prudent not to require "debug" to see it.

Signed-off-by Len Brown <[email protected]>

---

upsptream commit 33fd7afd66ffdc6addf1b085fe6403b6af532f8e

 drivers/pnp/pnpacpi/rsparser.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

drivers/pnp/pnpacpi/rsparser.c +4 -4

index 6aa231e..2dcd196 100644
@@ -85,7 +85,7 @@ static void pnpacpi_parse_allocated_irqresource(struct pnp_resource_table *res,
 	       i < PNP_MAX_IRQ)
 		i++;
 	if (i >= PNP_MAX_IRQ && !warned) {
-		printk(KERN_ERR "pnpacpi: exceeded the max number of IRQ "
+		printk(KERN_WARNING "pnpacpi: exceeded the max number of IRQ "
 				"resources: %d \n", PNP_MAX_IRQ);
 		warned = 1;
 		return;

@@ -187,7 +187,7 @@ static void pnpacpi_parse_allocated_dmaresource(struct pnp_resource_table *res,
 		res->dma_resource[i].start = dma;
 		res->dma_resource[i].end = dma;
 	} else if (!warned) {
-		printk(KERN_ERR "pnpacpi: exceeded the max number of DMA "
+		printk(KERN_WARNING "pnpacpi: exceeded the max number of DMA "
 				"resources: %d \n", PNP_MAX_DMA);
 		warned = 1;
 	}

@@ -213,7 +213,7 @@ static void pnpacpi_parse_allocated_ioresource(struct pnp_resource_table *res,
 		res->port_resource[i].start = io;
 		res->port_resource[i].end = io + len - 1;
 	} else if (!warned) {
-		printk(KERN_ERR "pnpacpi: exceeded the max number of IO "
+		printk(KERN_WARNING "pnpacpi: exceeded the max number of IO "
 				"resources: %d \n", PNP_MAX_PORT);
 		warned = 1;
 	}

@@ -241,7 +241,7 @@ static void pnpacpi_parse_allocated_memresource(struct pnp_resource_table *res,
 		res->mem_resource[i].start = mem;
 		res->mem_resource[i].end = mem + len - 1;
 	} else if (!warned) {
-		printk(KERN_ERR "pnpacpi: exceeded the max number of mem "
+		printk(KERN_WARNING "pnpacpi: exceeded the max number of mem "
 				"resources: %d\n", PNP_MAX_MEM);
 		warned = 1;
 	}

Signature · 1 line

1.5.5.49.gf43e2