Skip to contentSkip to conversation

libata: add HAVE_PATA_PLATFORM

PATCH In review Ben Dooks 2 participants 4 messages Apr 15, 2008

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

cover libata: add HAVE_PATA_PLATFORM

This is an update set, without the PPC modifications for adding HAVE_PATA_PLATFORM for selecting the availability of the driver.

If this is acceptable and be queued, I will enqueue the patches to remove the old bast-ide driver from the simtec boards in arch/arm/mach-*/ and the base-ide driver.

Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
author
#1 lore raw

PATCH 1/2 LIBATA: Add HAVE_PATA_PLATFORM to select PATA_PLATFORM driver

Add HAVE_PATA_PLATFORM to select the pata platform driver to ensure that we do not end up with a long 'depends on' list when other users of this driver turn up.

drivers/ata/Kconfig +9 -1
Index: linux-2.6.25-rc9-ata1/drivers/ata/Kconfig
===================================================================
@@ -624,9 +624,17 @@ config PATA_WINBOND_VLB
 	  Support for the Winbond W83759A controller on Vesa Local Bus
 	  systems.
 
+config HAVE_PATA_PLATFORM
+	bool
+	help
+	  This is an internal configuration node for any machine that
+	  uses pata-platform driver to enable the relevant driver in the
+	  configuration structure without having to submit endless patches
+	  to update the PATA_PLATFORM entry.
+
 config PATA_PLATFORM
 	tristate "Generic platform device PATA support"
-	depends on EMBEDDED || ARCH_RPC || PPC
+	depends on EMBEDDED || ARCH_RPC || PPC || HAVE_PATA_PLATFORM
 	help
 	  This option enables support for generic directly connected ATA
 	  devices commonly found on embedded systems.
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
author
#2 lore raw

PATCH 2/2 ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver

In reply to Ben Dooks

Use HAVE_PATA_PLATFORM for ARCH_RPC

Cc Linux ARM Kernel <[email protected]>
Cc Russell King <[email protected]>

PATCH FOLLOWS
KernelVersion: 2.6.24-git12

arch/arm/Kconfig +1 -0
Index: linux-2.6.25-rc9-ata1/arch/arm/Kconfig
===================================================================
@@ -411,6 +411,7 @@ config ARCH_RPC
 	select FIQ
 	select TIMER_ACORN
 	select ARCH_MAY_HAVE_PC_FDC
+	select HAVE_PATA_PLATFORM
 	select ISA_DMA_API
 	select NO_IOPORT
 	select HAVE_IDE
drivers/ata/Kconfig +1 -1
Index: linux-2.6.25-rc9-ata1/drivers/ata/Kconfig
===================================================================
@@ -634,7 +634,7 @@ config HAVE_PATA_PLATFORM
 
 config PATA_PLATFORM
 	tristate "Generic platform device PATA support"
-	depends on EMBEDDED || ARCH_RPC || PPC || HAVE_PATA_PLATFORM
+	depends on EMBEDDED || PPC || HAVE_PATA_PLATFORM
 	help
 	  This option enables support for generic directly connected ATA
 	  devices commonly found on embedded systems.
Signature · 8 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
Acked-by Russell King on v1 2/2
#3 lore raw

Re: [patch 2/2] ARM/RPC: Use HAVE_PATA_PLATFORM to select pata platform driver

Quoted 4 lines · Ben Dooks

Use HAVE_PATA_PLATFORM for ARCH_RPC

Cc Linux ARM Kernel <[email protected]>
Quoted 38 lines

PATCH FOLLOWS
KernelVersion: 2.6.24-git12

Index: linux-2.6.25-rc9-ata1/arch/arm/Kconfig
===================================================================

arch/arm/Kconfig +1 -0
@@ -411,6 +411,7 @@ config ARCH_RPC
 	select FIQ
 	select TIMER_ACORN
 	select ARCH_MAY_HAVE_PC_FDC
+	select HAVE_PATA_PLATFORM
 	select ISA_DMA_API
 	select NO_IOPORT
 	select HAVE_IDE

Index: linux-2.6.25-rc9-ata1/drivers/ata/Kconfig
===================================================================

drivers/ata/Kconfig +1 -1
@@ -634,7 +634,7 @@ config HAVE_PATA_PLATFORM
 
 config PATA_PLATFORM
 	tristate "Generic platform device PATA support"
-	depends on EMBEDDED || ARCH_RPC || PPC || HAVE_PATA_PLATFORM
+	depends on EMBEDDED || PPC || HAVE_PATA_PLATFORM
 	help
 	  This option enables support for generic directly connected ATA
 	  devices commonly found on embedded systems.
Signature · 9 lines
-- 
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php