Skip to contentSkip to conversation

tty: fix routine name in ptmx_open()

PATCH In review Hiroshi Shimamoto 3 participants 3 messages Apr 15, 2008 Char and misc drivers

lore
Share & tools
lore

Hiroshi Shimamoto

author
#0 lore raw

PATCH 1/1 tty: fix routine name in ptmx_open()

From: Hiroshi Shimamoto <[email protected]>

At ptmx_open(), the 2nd parameter for check_tty_count() should be "ptmx_open".

Signed-off-by Hiroshi Shimamoto <[email protected]>
---
 drivers/char/tty_io.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/tty_io.c +1 -1
index 613ec81..546217d 100644
@@ -2774,7 +2774,7 @@ static int ptmx_open(struct inode *inode, struct file *filp)
 	if (devpts_pty_new(tty->link))
 		goto out1;
 
-	check_tty_count(tty, "tty_open");
+	check_tty_count(tty, "ptmx_open");
 	retval = ptm_driver->open(tty, filp);
 	if (!retval) {
 		tty_audit_opening();
Signature · 1 line
1.5.4.1
#2 lore raw
In reply to Hiroshi Shimamoto
Quoted 15 lines · On Mon, 14 Apr 2008 17:55:49 -0700 Hiroshi Shimamoto…

From: Hiroshi Shimamoto <[email protected]>

At ptmx_open(), the 2nd parameter for check_tty_count() should be "ptmx_open".

Signed-off-by Hiroshi Shimamoto <[email protected]>
---
 drivers/char/tty_io.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/tty_io.c +0 -0
index 613ec81..546217d 100644

drivers/char/tty_io.c static int ptmx_open(struct inode *inode, struct file *filp) · line 2780

Quoted 8 lines
drivers/char/tty_io.c +1 -1
@@ -2774,7 +2774,7 @@ static int ptmx_open(struct inode *inode, struct file *filp)
 	if (devpts_pty_new(tty->link))
 		goto out1;
 
-	check_tty_count(tty, "tty_open");
+	check_tty_count(tty, "ptmx_open");
 	retval = ptm_driver->open(tty, filp);
 	if (!retval) {
 		tty_audit_opening();

Of course, using __func__ prevents this sort of bitrot.

Or even #define check_tty_count(tty) __check_tty_count(tty, __func__)