Skip to contentSkip to conversation

genetlink: export genl_unregister_mc_group()

PATCH In review Inaky Perez-Gonzalez 2 participants 3 messages Apr 17, 2008 – Apr 18, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Inaky Perez-Gonzalez

author
#0 lore raw

PATCH 1/1 genetlink: export genl_unregister_mc_group()

Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow unregistering groups on the run.

Cleanup is currently done when unregistering a family, but there is no way to unregister a single multicast group due to that function not being exported. Seems to be a mistake as it is documented as for external consumption.

Signed-off-by Inaky Perez-Gonzalez <[email protected]>

---

net/netlink/genetlink.c +1 -0
diff -r ec7efeb20531 net/netlink/genetlink.c
@@ -225,6 +225,7 @@ void genl_unregister_mc_group(struct gen
 	__genl_unregister_mc_group(family, grp);
 	genl_unlock();
 }
+EXPORT_SYMBOL(genl_unregister_mc_group);
 
 static void genl_unregister_mc_groups(struct genl_family *family)
 {
maintainer
#1 lore raw

From: Inaky Perez-Gonzalez <[email protected]>
Date: Thu, 17 Apr 2008 12:54:01 -0700

Quoted 9 lines

Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow unregistering groups on the run.

Cleanup is currently done when unregistering a family, but there is no way to unregister a single multicast group due to that function not being exported. Seems to be a mistake as it is documented as for external consumption.

Signed-off-by Inaky Perez-Gonzalez <[email protected]>

We export functions with in-tree modular users.

The only reason that genl_register_mc_group() is exported is because there are in-tree modular users, ACPI and the NL80211 wireless code.

Please add this export when code you are writing that needs this is merged into the tree.

Thank you.

author
#2 lore raw
Quoted 10 lines · David Miller
Quoted 3 lines

Add an EXPORT_SYMBOL() to genl_unregister_mc_group(), to allow unregistering groups on the run.
..

We export functions with in-tree modular users.

The only reason that genl_register_mc_group() is exported is because there are in-tree modular users, ACPI and the NL80211 wireless code.

Please add this export when code you are writing that needs this is merged into the tree.

Sure,

Signature · 1 line
Inaky