Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c

Hi,

In drivers\usb\usb_ohci.c file, SHOW_INFO is undef at 2 locations. @line 77 and @line 112. Below patch removes them for code size savings.

comments welcome.

Thanks in advance

@@ -109,7 +109,6 @@ static struct pci_device_id ohci_pci_ids
 #define dbg(format, arg...) do {} while(0)
 #endif /* DEBUG */
 #define err(format, arg...) printf("ERROR: " format "\n", ## arg)
-#undef SHOW_INFO
 #ifdef SHOW_INFO
 #define info(format, arg...) printf("INFO: " format "\n", ## arg)
 #else

Regards
Gururaja
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080402/08ece611/attachment.htm

Dear Gururaja,

Thank you, well spotted.

But, git-am fails for for two reasons:

1. It chokes on your HTML mail. Please send plain text.

2. Please send a real diff containing the full path. Check the section "Submitting Patches" in the README if unsure.

Please cleanup and resubmit.

Thanks!

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de

Applied, thanks, but *please* provide proper patches with usable file name information next time. I recommend to use git-format-patch to create the patches.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
On the subject of C program indentation: "In My Egotistical  Opinion,
most  people's  C  programs  should be indented six feet downward and
covered with dirt."                               - Blair P. Houghton

Hi,

Thanks and sorry for the mistake. will sure make it a point not to repeat this.

Regards
Gururaja

-----Original Message-----
From: [email protected] [mailto:wd at denx.de]
Sent: Thursday, April 17, 2008 9:14 PM
To: Gururaja Hebbar K R
Cc: u-boot-users at lists.sourceforge.net
Subject: Re: [PATCH] Remove duplicate #undef SHOW_INFO inside drivers\usb\usb_ohci.c

In message <[email protected]> you

Applied, thanks, but *please* provide proper patches with usable file name information next time. I recommend to use git-format-patch to create the patches.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de On
the subject of C program indentation: "In My Egotistical  Opinion, most
people's  C  programs  should be indented six feet downward and
covered with dirt."                               - Blair P. Houghton