Skip to contentSkip to conversation

Use __weak macro for smp_setup_processor_id

PATCH In review Benjamin Herrenschmidt 2 participants 4 messages Apr 18, 2008 Generic include/asm header files

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 Use __weak macro for smp_setup_processor_id

Use the __weak macro instead of the longer __attribute__ ((weak)) form

--

 init/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
init/main.c +1 -1
@@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
 	cpu_set(cpu, cpu_possible_map);
 }
 
-void __init __attribute__((weak)) smp_setup_processor_id(void)
+void __init __weak smp_setup_processor_id(void)
 {
 }
 
#1 lore raw
Quoted 11 lines · On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt…

Use the __weak macro instead of the longer __attribute__ ((weak)) form

--

 init/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

init/main.c static void __init boot_cpu_init(void) · line 505

Quoted 7 lines
init/main.c +1 -1
@@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
 	cpu_set(cpu, cpu_possible_map);
 }
 
-void __init __attribute__((weak)) smp_setup_processor_id(void)
+void __init __weak smp_setup_processor_id(void)
 {
 }

ack on all three. Please fold #3 into #1 and add both to git-powerpc.

#2 lore raw
Quoted 16 lines · Andrew Morton
Quoted 14 lines · On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt…

Use the __weak macro instead of the longer __attribute__ ((weak)) form

--

 init/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
init/main.c +0 -0
@@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
 	cpu_set(cpu, cpu_possible_map);
 }
 
Quoted 6 lines

init/main.c static void __init boot_cpu_init(void) · line 505

Quoted 4 lines
init/main.c +1 -1
-void __init __attribute__((weak)) smp_setup_processor_id(void)
+void __init __weak smp_setup_processor_id(void)
 {
 }

ack on all three. Please fold #3 into #1 and add both to git-powerpc.

Damn ! I took 5mn to actually split it out in order to not do two different things in one patch :-)

Will do.

Cheers,
Ben.

#3 lore raw
Quoted 25 lines · On Fri, 18 Apr 2008 18:19:07 +1000 Benjamin Herrenschmidt…
Quoted 16 lines · Andrew Morton
Quoted 14 lines · On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt…

Use the __weak macro instead of the longer __attribute__ ((weak)) form

--

 init/main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
init/main.c +0 -0
@@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
 	cpu_set(cpu, cpu_possible_map);
 }
 
Quoted 6 lines

init/main.c static void __init boot_cpu_init(void) · line 505

Quoted 4 lines
init/main.c +1 -1
-void __init __attribute__((weak)) smp_setup_processor_id(void)
+void __init __weak smp_setup_processor_id(void)
 {
 }

ack on all three. Please fold #3 into #1 and add both to git-powerpc.

Quoted 2 lines

Damn ! I took 5mn to actually split it out in order to not do two different things in one patch :-)

ah, I misread it. I thought this was changing the __attribute__((weak)) which patch #1 added. But it's changing a different one. I though that was odd.

Quoted 1 line

Will do.

whatever ;)