ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol
PATCH 1/1 ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol
Recent commit a4986459 adds reference to dcache_enable, thus breaking the build on PPC440. This patch adds a stub for dcache_enable, similarly to what's being done for other cache operations.
---
cpu/ppc4xx/cache.S | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
cpu/ppc4xx/cache.S +2 -0
@@ -166,9 +166,11 @@ _GLOBAL(invalidate_dcache) #ifdef CONFIG_440 .globl dcache_disable + .globl dcache_enable .globl icache_disable .globl icache_enable dcache_disable: +dcache_enable: icache_disable: icache_enable: blr
PATCH v2 1/1 ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol
Recent commit 017e9b79 adds reference to dcache_enable, thus breaking the build on PPC440. This patch adds a stub for dcache_enable, similarly to what's being done for other cache operations.
---
Fixed an off-by-one error in the commit id -- it should be 017e9b79 instead of a4986459.
cpu/ppc4xx/cache.S | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
cpu/ppc4xx/cache.S +2 -0
@@ -166,9 +166,11 @@ _GLOBAL(invalidate_dcache) #ifdef CONFIG_440 .globl dcache_disable + .globl dcache_enable .globl icache_disable .globl icache_enable dcache_disable: +dcache_enable: icache_disable: icache_enable: blr
PATCH v2 1/1 ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol
Quoted 3 lines · Bartlomiej Sieka
Recent commit
017e9b79adds reference todcache_enable, thus breaking the build on PPC440. This patch adds a stub fordcache_enable, similarly to what's being done for other cache operations.
Finally I manage to read the mailing lists. And you fixed the problem too. :) Great, thanks.
BTW: Please keep me on CC on all ppc4xx (or CFI etc) related patches. This way I "see" the patches earlier.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 1/1 ppc4xx: Fix PPC440 build breakage due to missing dcache_enable symbol
In reply to Bartlomiej SiekaQuoted 16 lines · In message <[email protected]> you wrote:
Recent commit
a4986459adds reference todcache_enable, thus breaking the build on PPC440. This patch adds a stub fordcache_enable, similarly to what's being done for other cache operations.Signed-off-by Bartlomiej Sieka <[email protected]>---
cpu/ppc4xx/cache.S | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)cpu/ppc4xx/cache.S +0
-0@@ -166,9 +166,11 @@ _GLOBAL(invalidate_dcache) #ifdef CONFIG_440
cpu/ppc4xx/cache.S _GLOBAL(invalidate_dcache) · line 176
Quoted 10 lines
cpu/ppc4xx/cache.S +2
-0.globl dcache_disable + .globl dcache_enable .globl icache_disable .globl icache_enable dcache_disable: +dcache_enable: icache_disable: icache_enable: blr
Thanks, but as mentiuoned before (in my message to Stafan as the 4xx custodian), the whole idea of having such "stubs" (I'd rather call it "bad and evil fakes") seems not acceptable to me.
I want to see this cleaned up.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Question: How does one get fresh air into a Russian church? Answer: One clicks on an icon, and a window opens!