Skip to contentSkip to conversation

ssb: Fix all-ones boardflags

PATCH New Michael Buesch 1 participant 1 message Apr 19, 2008 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ssb: Fix all-ones boardflags

From: Larry Finger <[email protected]>

In the SSB SPROM a field set to all ones means the value is not defined in the SPROM.
In case of the boardflags, we need to set them to zero to avoid confusing drivers. Drivers will only check the flags by ANDing.

---

Resent without quoted-printable encoding and attachment.

John,

This is 2.6.26 material.

drivers/ssb/pci.c +0 -0
index 904b1a8..57c4ccf 100644
@@ -484,6 +484,11 @@ static int sprom_extract(struct ssb_bus *bus,

struct ssb_sprom *out,
goto unsupported;
}

+ if (out->boardflags_lo == 0xFFFF)
+ out->boardflags_lo = 0; /* per specs */
+ if (out->boardflags_hi == 0xFFFF)
+ out->boardflags_hi = 0; /* per specs */
+
return 0;
unsupported:
ssb_printk(KERN_WARNING PFX "Unsupported SPROM revision %d "

Signature · 1 line
Greetings Michael.