Skip to contentSkip to conversation

rpcgen: include sys/ioctl.h on linux systems

PATCH In review Mike Frysinger 3 participants 3 messages Apr 20, 2008 – Oct 8, 2008

Subsystems (2)
NFS client NFS server
lore
Share & tools
lore

Mike Frysinger

author
#0 lore raw

PATCH 1/1 rpcgen: include sys/ioctl.h on linux systems

the rpcgen tool included with nfs-utils will generate calls to ioctl() but not actually generate the sys/ioctl.h header include. attached patch should fix this.
-mike

rpcgen/rpc_main.c +3 -0
@@ -548,6 +548,9 @@
 #ifndef linux
 	if( !tirpcflag && inetdflag )
 	  f_print(fout, "#include <sys/ttycom.h>/* TIOCNOTTY */\n");
+#else
+	if( !tirpcflag )
+	  f_print(fout, "#include <sys/ioctl.h>/* TIOCNOTTY */\n");
 #endif
 	if( Cflag && (inetdflag || pmflag ) ) {
 	  f_print(fout, "#ifdef __cplusplus\n");

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that [email protected] is being discontinued. Please subscribe to [email protected] instead.
http://vger.kernel.org/vger-lists.html#linux-nfs

#1 lore raw

PATCH 1/1 rpcgen: include sys/ioctl.h on linux systems

Steve-

Resending. Is this valid for nfs-utils 1.1.4?

Begin forwarded message:

Quoted 9 lines

From: Mike Frysinger <[email protected]>
Date: April 20, 2008 6:49:44 AM GMT-04:00
To: [email protected]
Subject: [NFS] [patch] rpcgen: include sys/ioctl.h on linux systems

the rpcgen tool included with nfs-utils will generate calls to ioctl() but not actually generate the sys/ioctl.h header include. attached patch should fix this.
-mike

rpcgen/rpc_main.c +3 -0
@@ -548,6 +548,9 @@
 #ifndef linux
 	if( !tirpcflag && inetdflag )
 	  f_print(fout, "#include <sys/ttycom.h>/* TIOCNOTTY */\n");
+#else
+	if( !tirpcflag )
+	  f_print(fout, "#include <sys/ioctl.h>/* TIOCNOTTY */\n");
 #endif
 	if( Cflag && (inetdflag || pmflag ) ) {
 	  f_print(fout, "#ifdef __cplusplus\n");
Quoted 11 lines

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that [email protected] is being discontinued. Please subscribe to [email protected] instead.
http://vger.kernel.org/vger-lists.html#linux-nfs

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

#2 lore raw
In reply to Mike Frysinger
Quoted 6 lines · Mike Frysinger

the rpcgen tool included with nfs-utils will generate calls to ioctl() but not
actually generate the sys/ioctl.h header include. attached patch should fix
this.
-mike

Committed....

steved.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
_______________________________________________
Please note that [email protected] is being discontinued. Please subscribe to [email protected] instead.
http://vger.kernel.org/vger-lists.html#linux-nfs