fix brd allocation flags
Subsystems (2)
PATCH 1/1 fix brd allocation flags
Hello,
while looking at the implementation of the Ram backed block device driver, I stumbled across a write-only local variable, which makes little sense, so I assume it should actually work like this:
Signed-off-by Petr Tesarik <[email protected]>
drivers/block/brd.c +1 -1
@@ -108,7 +108,7 @@ static struct page *brd_insert_page(struct brd_device *brd, sector_t sector)#ifndef CONFIG_BLK_DEV_XIP gfp_flags |= __GFP_HIGHMEM;#endif - page =alloc_page (GFP_NOIO | __GFP_HIGHMEM | __GFP_ZERO); + page =alloc_page (gfp_flags);if (!page)return NULL ;
Quoted 5 lines · Petr Tesarik
Hello,
while looking at the implementation of the Ram backed block device driver, I stumbled across a write-only local variable, which makes little sense, so I assume it should actually work like this:
Right you are. Good catch, thanks Petr.
Quoted 16 lines
Signed-off-by Petr Tesarik <[email protected]>drivers/block/brd.c +1
-1@@ -108,7 +108,7 @@ static struct page *brd_insert_page(struct brd_device *brd, sector_t sector)#ifndef CONFIG_BLK_DEV_XIP gfp_flags |= __GFP_HIGHMEM;#endif - page =alloc_page (GFP_NOIO | __GFP_HIGHMEM | __GFP_ZERO); + page =alloc_page (gfp_flags);if (!page)return NULL ;