Skip to contentSkip to conversation

i2c: Add Intel SCH I2C SMBus support

PATCH Applied alek du 3 participants 5 messages Apr 22, 2008 – Apr 26, 2008 I2C subsystem host drivers

lore
Share & tools
lore

alek du

author
#0 lore raw

PATCH 2/3 i2c: Add Intel SCH I2C SMBus support

This patch adds Intel SCH chipsets (US15W, US15L, UL11L) i2c bus support.

Signed-off-by Alek Du <[email protected]>
---
 drivers/i2c/busses/Kconfig   |    7 +
 drivers/i2c/busses/Makefile  |    1 +
 drivers/i2c/busses/i2c-sch.c |  419 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 427 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-sch.c
drivers/i2c/busses/Kconfig +7 -0
index 5fa9c3c..7aad5d1 100644
@@ -244,6 +244,13 @@ config I2C_PIIX4
 	  This driver can also be built as a module.  If so, the module
 	  will be called i2c-piix4.
 
+config I2C_SCH
+	tristate "Intel SCH SMBUS 1.0"
+	depends on I2C && PCI
+	help
+	  If you say Y or M to this option, support will be included for the
+	  Intel SCH based systems. Module will be called i2c-sch.ko.
+
 config I2C_IBM_IIC
 	tristate "IBM PPC 4xx on-chip I2C interface"
 	depends on IBM_OCP
drivers/i2c/busses/Makefile +1 -0
index ea7068f..3165bf9 100644
@@ -32,6 +32,7 @@ obj-$(CONFIG_I2C_PASEMI)	+= i2c-pasemi.o
 obj-$(CONFIG_I2C_PCA_ISA)	+= i2c-pca-isa.o
 obj-$(CONFIG_I2C_PIIX4)		+= i2c-piix4.o
 obj-$(CONFIG_I2C_PMCMSP)	+= i2c-pmcmsp.o
+obj-$(CONFIG_I2C_SCH)		+= i2c-sch.o
 obj-$(CONFIG_I2C_PNX)		+= i2c-pnx.o
 obj-$(CONFIG_I2C_PROSAVAGE)	+= i2c-prosavage.o
 obj-$(CONFIG_I2C_PXA)		+= i2c-pxa.o
drivers/i2c/busses/i2c-sch.c new file +419 -0

419 lines not on this page · raw message

Signature · 1 line
1.5.2.5
#1 lore raw

Hi Alek,

Quoted 1 line · alek du

This patch adds Intel SCH chipsets (US15W, US15L, UL11L) i2c bus support.

What kind of machines are these?

Quoted 9 lines
Signed-off-by Alek Du <[email protected]>
---
 drivers/i2c/busses/Kconfig   |    7 +
 drivers/i2c/busses/Makefile  |    1 +
 drivers/i2c/busses/i2c-sch.c |  419 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 427 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-sch.c

(...)

MAINTAINERS says:

I2C SUBSYSTEM
(...)
L: [email protected]

So it would be great if you could send your patch there rather than on LKML.

Thanks,

Signature · 1 line
Jean Delvare
author
#2 lore raw

Jean,

The SCH chipsets were launched during the recent Intel spring IDF. They are chipsets for Intel Atom processor. The chipset and processor are for LPIA embedded systems such as MID, automotive, classmate PC, etc.

I will also post the patch to [email protected]

Thanks,
Alek

Quoted 32 lines · On Wed, 23 Apr 2008 20:32:12 +0800 "Jean Delvare" <[email protected]> wrote:

Re: [PATCH 2/3] i2c: Add Intel SCH I2C SMBus support

Hi Alek,

Quoted 2 lines · alek du

This patch adds Intel SCH chipsets (US15W, US15L, UL11L) i2c bus support.

What kind of machines are these?

Quoted 9 lines
Signed-off-by Alek Du <[email protected]>
---
 drivers/i2c/busses/Kconfig   |    7 +
 drivers/i2c/busses/Makefile  |    1 +
 drivers/i2c/busses/i2c-sch.c |  419

++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 427 insertions(+), 0 deletions(-) create mode 100644 drivers/i2c/busses/i2c-sch.c (...)

MAINTAINERS says:

I2C SUBSYSTEM
(...)
L: [email protected]

So it would be great if you could send your patch there rather than on LKML.

Thanks,
--
Jean Delvare

#3 lore raw
In reply to Jean Delvare
Quoted 18 lines · On Wed, 23 Apr 2008 14:32:12 +0200 Jean Delvare <[email protected]> wrote:

Hi Alek,

Quoted 1 line · alek du

This patch adds Intel SCH chipsets (US15W, US15L, UL11L) i2c bus support.

What kind of machines are these?

Quoted 9 lines
Signed-off-by Alek Du <[email protected]>
---
 drivers/i2c/busses/Kconfig   |    7 +
 drivers/i2c/busses/Makefile  |    1 +
 drivers/i2c/busses/i2c-sch.c |  419 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 427 insertions(+), 0 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-sch.c

(...)

Quoted 9 lines

MAINTAINERS says:

I2C SUBSYSTEM
(...)
L: [email protected]

So it would be great if you could send your patch there rather than on LKML.

"as well as" would be better than "rather than", please.

I worry about the inclusion of apm_bios.h. The driver is configured to be available on all architectures but apm_bios.h is surely x86-specific (and maybe mips).

But afaict the inclusion is not needed?

#4 lore raw
Quoted 5 lines · Andrew Morton

I worry about the inclusion of apm_bios.h. The driver is configured to be available on all architectures but apm_bios.h is surely x86-specific (and maybe mips).

But afaict the inclusion is not needed?

Indeed not. It was copied from i2c-piix4, which includes it since the beginning of times for no good reason. I just posted a patch fixing i2c-piix4:
http://lists.lm-sensors.org/pipermail/i2c/2008-April/003414.html

Signature · 1 line
Jean Delvare