x86: vm86 - hide X86_VM_MASK from userland programs
PATCH 1/1 x86: vm86 - hide X86_VM_MASK from userland programs
X86_VM_MASK is a kernel specific flag so lets hide it from userland programs
Signed-off-by Cyrill Gorcunov <[email protected]>
---
include/asm-x86/vm86.h +4 -0
@@ -14,12 +14,16 @@#include <asm/processor-flags.h> +#ifdef __KERNEL__ +#ifdef CONFIG_VM86 #define X86_VM_MASK X86_EFLAGS_VM#else #define X86_VM_MASK 0/* No VM86 support */ #endif +#endif /* __KERNEL__ */ +#define BIOSSEG 0x0f000#define CPU_086 0
Quoted 4 lines · Cyrill Gorcunov
X86_VM_MASKis a kernel specific flag so lets hide it from userland programsSigned-off-by Cyrill Gorcunov <[email protected]>
Since and there's already an #ifdef __KERNEL__ section later on in the file, and since X86_VM_MASK isn't used before that, I probably would have been inclined to shift it down there instead of adding a new #ifdef.
But maybe I should just stop heckling... :)
Signature · 1 line
dwmw2
[David Woodhouse - Thu, Apr 24, 2008 at 09:39:24AM +0100]
| On Thu, 2008-04-24 at 12:35 +0400, Cyrill Gorcunov wrote: | > X86_VM_MASK is a kernel specific flag so lets hide it from | > userland programs | > | > Signed-off-by: Cyrill Gorcunov <[email protected]> | | Since and there's already an #ifdef __KERNEL__ section later on in the | file, and since X86_VM_MASK isn't used before that, I probably would | have been inclined to shift it down there instead of adding a new | #ifdef. | | But maybe I should just stop heckling... :) | | -- | dwmw2 |
I was thought about that too ;) David, I'll recheck this all today evening (have to go to office now). And please continue heckling - it allows to make this file in particular *better*, so I think it's ok ;)
- Cyrill -