Skip to contentSkip to conversation

fix typo in net/ipv6/Kconfig

PATCH In review Michael Beasley 3 participants 4 messages Apr 24, 2008 – Apr 26, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix typo in net/ipv6/Kconfig

net/ipv6/Kconfig +1 -1
index eb0b808..56b4d86 100644
@@ -172,7 +172,7 @@ config IPV6_SIT
          Tunneling means encapsulating data of one protocol type within
          another protocol and sending it over a channel that understands the
          encapsulating protocol. This driver implements encapsulation of IPv6
-         into IPv4 packets. This is useful if you want to connect two IPv6
+         into IPv4 packets. This is useful if you want to connect to IPv6
          networks over an IPv4-only path.
 
          Saying M here will produce a module called sit.ko. If unsure, say Y.

Two is used in the wrong context here, as you are connecting to an IPv6 network over IPv4; not connecting two IPv6 networks to an IPv4 one.

maintainer
#1 lore raw

From: Michael Beasley <[email protected]>
Date: Thu, 24 Apr 2008 06:39:50 -0400

net/ipv6/Kconfig config IPV6_SIT · line 178

Quoted 13 lines
net/ipv6/Kconfig +1 -1
index eb0b808..56b4d86 100644
@@ -172,7 +172,7 @@ config IPV6_SIT
          Tunneling means encapsulating data of one protocol type within
          another protocol and sending it over a channel that understands the
          encapsulating protocol. This driver implements encapsulation of IPv6
-         into IPv4 packets. This is useful if you want to connect two IPv6
+         into IPv4 packets. This is useful if you want to connect to IPv6
          networks over an IPv4-only path.
 
          Saying M here will produce a module called sit.ko. If unsure, say Y.

Your email client corrupted the patch, it has turned tab characters into spaces.

You should also be sure to post your networking patches to [email protected] as that's where the networking developers listen.

Please also provide a proper Signed-off-by: line for your patch (see linux/Docuemtnation/SubmittingPatches, section 5).

Thanks.

#2 lore raw
In reply to Michael Beasley
Quoted 14 lines · Michael Beasley
net/ipv6/Kconfig +1 -1
index eb0b808..56b4d86 100644
@@ -172,7 +172,7 @@ config IPV6_SIT
          Tunneling means encapsulating data of one protocol type within
          another protocol and sending it over a channel that understands the
          encapsulating protocol. This driver implements encapsulation of IPv6
-         into IPv4 packets. This is useful if you want to connect two IPv6
+         into IPv4 packets. This is useful if you want to connect to IPv6
          networks over an IPv4-only path.
 
          Saying M here will produce a module called sit.ko. If unsure, say Y.
Quoted 2 lines

Two is used in the wrong context here, as you are connecting to an IPv6 network over IPv4; not connecting two IPv6 networks to an IPv4 one.

NAK. The text correctly describes the scenario. You have two IPv6
networks, between which you set up a SIT tunnel which transmits data between the two networks encapsulated in IPv4 packets. If you find the text not self-explanatory, then perhaps the sentence could be rewritten as follows:

"This is useful if you want to connect two IPv6 networks to each other over an IPv4-only path."

Maciej

maintainer
#3 lore raw

From: "Maciej W. Rozycki" <[email protected]>
Date: Sat, 26 Apr 2008 00:58:49 +0100 (BST)

Quoted 25 lines · Michael Beasley
Quoted 15 lines
net/ipv6/Kconfig +1 -1
index eb0b808..56b4d86 100644
@@ -172,7 +172,7 @@ config IPV6_SIT
          Tunneling means encapsulating data of one protocol type within
          another protocol and sending it over a channel that understands the
          encapsulating protocol. This driver implements encapsulation of IPv6
-         into IPv4 packets. This is useful if you want to connect two IPv6
+         into IPv4 packets. This is useful if you want to connect to IPv6
          networks over an IPv4-only path.
 
          Saying M here will produce a module called sit.ko. If unsure, say Y.
Quoted 2 lines

Two is used in the wrong context here, as you are connecting to an IPv6 network over IPv4; not connecting two IPv6 networks to an IPv4 one.

NAK. The text correctly describes the scenario. You have two IPv6
networks, between which you set up a SIT tunnel which transmits data between the two networks encapsulated in IPv4 packets. If you find the text not self-explanatory, then perhaps the sentence could be rewritten as follows:

Quoted 2 lines

"This is useful if you want to connect two IPv6 networks to each other over an IPv4-only path."

This patch is already in Linus's tree, someone send me a revert if they want it changed back.