Skip to contentSkip to conversation

latest git: DEV_BLK_4DRIVES should be a tristate

PATCH In review Frederik Deweerdt 3 participants 3 messages Apr 24, 2008 – Apr 26, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 latest git: DEV_BLK_4DRIVES should be a tristate

Hello Bartlomiej,

The 4drives should be a tristate, the following breakage occurs otherwise:
ERROR: "probe_4drives" [drivers/ide/ide-core.ko] undefined!

The following (compile tested) patch fixes it for me.

Regards,
Frederik

drivers/ide/Kconfig +1 -1
index 8753203..3f9e100 100644
@@ -1031,7 +1031,7 @@ comment "Other IDE chipsets support"
 comment "Note: most of these also require special kernel boot parameters"
 
 config BLK_DEV_4DRIVES
-	bool "Generic 4 drives/port support"
+	tristate "Generic 4 drives/port support"
 	help
 	  Certain older chipsets, including the Tekram 690CD, use a single set
 	  of I/O ports at 0x1f0 to control up to four drives, instead of the
#1 lore raw
Quoted 6 lines · Frederik Deweerdt

Hello Bartlomiej,

The 4drives should be a tristate, the following breakage occurs otherwise:
ERROR: "probe_4drives" [drivers/ide/ide-core.ko] undefined!
...

"ide: remove obsoleted "idex=" kernel parameters" will already fix this breakage.

Bart, can you push this patch?

Quoted 3 lines

Regards,
Frederik
...

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
Quoted 8 lines · Adrian Bunk
Quoted 6 lines · Frederik Deweerdt

Hello Bartlomiej,

The 4drives should be a tristate, the following breakage occurs otherwise:
ERROR: "probe_4drives" [drivers/ide/ide-core.ko] undefined!
...

Quoted 4 lines

"ide: remove obsoleted "idex=" kernel parameters" will already fix this breakage.

Bart, can you push this patch?

I applied Frederik's fix ("ide: remove obsoleted "idex=" kernel parameters" depends on some other patches that need to pushed first).

Thanks,
Bart