Hauppauge WinTV regreession from 2.6.24 to 2.6.25

I am testing a kernel upgrade from 2.6.24.to 2.6.25, and the drivers for
the Hauppauge WinTV appear to have suffered some regression between
the two kernel versions.

The problem is that the tuner is not being detected and set correctly for either the video or the radio device on the card.

Details are below - the problem appears to be in the detection of the tuner type from the tda9887 chip not then being picked up by the tuner module. So, in 2.6.24 it successfully gets:

tuner-simple 4-0061: type set to 38 (Philips PAL/SECAM multi (FM1216ME MK3))

but in 2.6.25 it seems to fail:

tuner' 4-0061: tuner type not set

I'm not sure what more information I can provide - if anything will help diagnose the problem better please shout. I am just using the stock Gentoo kernel by the way - drivers are as they come with the kernel release in both cases.

Regards
Ian

For kernel 2.6.25, the system log shows:

---------------

[   43.473742] Linux video capture interface: v2.00
[   43.485230] cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
[   43.485529] ACPI: PCI Interrupt Link [LNK1] enabled at IRQ 11
[   43.485532] ACPI: PCI Interrupt 0000:01:0a.0[A] -> Link [LNK1] -> GSI 11 (level, low) -> IRQ 11
[   43.485697] cx88[0]: subsystem: 0070:3401, board: Hauppauge WinTV 34xxx models [card=1,autodetected]
[   43.485700] cx88[0]: TV tuner type -1, Radio tuner type -1
[   43.695400] tuner' 4-0043: chip found @ 0x86 (cx88[0])
[   43.695406] tda9887 4-0043: tda988[5/6/7] found
[   43.699724] tuner' 4-0061: chip found @ 0xc2 (cx88[0])
[   43.754465] tveeprom 4-0050: Hauppauge model 34519, rev J157, serial# 2906136
[   43.754470] tveeprom 4-0050: tuner model is Philips FM1216 ME MK3 (idx 57, type 38)
[   43.754473] tveeprom 4-0050: TV standards PAL(B/G) PAL(I) SECAM(L/L') PAL(D/D1/K) (eeprom 0x74)
[   43.754476] tveeprom 4-0050: audio processor is CX881 (idx 31)
[   43.754478] tveeprom 4-0050: has radio
[   43.754480] cx88[0]: hauppauge eeprom: model=34519
[   43.771239] input: cx88 IR (Hauppauge WinTV 34xxx  as /class/input/input7
[   43.800173] cx88[0]/0: found at 0000:01:0a.0, rev: 5, irq: 11, latency: 32, mmio: 0xe9000000
[   43.800237] cx88[0]/0: registered device video0 [v4l2]
[   43.800253] cx88[0]/0: registered device vbi0
[   43.800270] cx88[0]/0: registered device radio0
[   43.800342] tuner' 4-0061: tuner type not set
[   43.834391] cx2388x alsa driver version 0.0.6 loaded
[   43.834450] ACPI: PCI Interrupt 0000:01:0a.1[A] -> Link [LNK1] -> GSI 11 (level, low) -> IRQ 11
[   43.834477] cx88[0]/1: CX88x/0: ALSA support for cx2388x boards

-----------------------------

and for 2.6.24 it shows:
----------------------

Apr 19 16:59:24 ian2 kernel: [   92.488289] Linux video capture interface: v2.00
Apr 19 16:59:24 ian2 kernel: [   92.498392] cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
Apr 19 16:59:24 ian2 kernel: [   92.498688] ACPI: PCI Interrupt Link [LNK1] enabled at IRQ 11
Apr 19 16:59:24 ian2 kernel: [   92.498691] ACPI: PCI Interrupt 0000:01:0a.0[A] -> Link [LNK1] -> GSI 11 (level, low) -> IRQ 11
Apr 19 16:59:24 ian2 kernel: [   92.498738] cx88[0]: subsystem: 0070:3401, board: Hauppauge WinTV 34xxx models [card=1,autodetected]
Apr 19 16:59:24 ian2 kernel: [   92.498740] cx88[0]: TV tuner type -1, Radio tuner type -1
Apr 19 16:59:24 ian2 kernel: [   92.661117] tveeprom 4-0050: Hauppauge model 34519, rev J157, serial# 2906136
Apr 19 16:59:24 ian2 kernel: [   92.661123] tveeprom 4-0050: tuner model is Philips FM1216 ME MK3 (idx 57, type 38)
Apr 19 16:59:24 ian2 kernel: [   92.661126] tveeprom 4-0050: TV standards PAL(B/G) PAL(I) SECAM(L/L') PAL(D/D1/K) (eeprom 0x74)
Apr 19 16:59:24 ian2 kernel: [   92.661129] tveeprom 4-0050: audio processor is CX881 (idx 31)
Apr 19 16:59:24 ian2 kernel: [   92.661131] tveeprom 4-0050: has radio
Apr 19 16:59:24 ian2 kernel: [   92.661133] cx88[0]: hauppauge eeprom: model=34519
Apr 19 16:59:24 ian2 kernel: [   92.677844] input: cx88 IR (Hauppauge WinTV 34xxx  as /devices/pci0000:00/0000:00:08.0/0000:01:0a.0/input/input7
Apr 19 16:59:24 ian2 kernel: [   92.705395] cx88[0]/0: found at 0000:01:0a.0, rev: 5, irq: 11, latency: 32, mmio: 0xe9000000
Apr 19 16:59:24 ian2 kernel: [   92.716039] tuner 4-0043: chip found @ 0x86 (cx88[0])
Apr 19 16:59:24 ian2 kernel: [   92.716064] tda9887 4-0043: tda988[5/6/7] found @ 0x43 (tuner)
Apr 19 16:59:24 ian2 kernel: [   92.716066] tuner 4-0043: type set to tda9887
Apr 19 16:59:24 ian2 kernel: [   92.718643] tuner 4-0061: chip found @ 0xc2 (cx88[0])
Apr 19 16:59:24 ian2 kernel: [   92.718655] tuner-simple 4-0061: type set to 38 (Philips PAL/SECAM multi (FM1216ME MK3))
Apr 19 16:59:24 ian2 kernel: [   92.718658] tuner 4-0061: type set to Philips PAL/SECAM m
Apr 19 16:59:24 ian2 kernel: [   92.718661] tuner-simple 4-0061: type set to 38 (Philips PAL/SECAM multi (FM1216ME MK3))
Apr 19 16:59:24 ian2 kernel: [   92.718663] tuner 4-0061: type set to Philips PAL/SECAM m
Apr 19 16:59:24 ian2 kernel: [   92.740419] cx88[0]/0: registered device video0 [v4l2]
Apr 19 16:59:24 ian2 kernel: [   92.740438] cx88[0]/0: registered device vbi0
Apr 19 16:59:24 ian2 kernel: [   92.740453] cx88[0]/0: registered device radio0
Apr 19 16:59:24 ian2 kernel: [   92.778001] cx2388x alsa driver version 0.0.6 loaded
Apr 19 16:59:24 ian2 kernel: [   92.778064] ACPI: PCI Interrupt 0000:01:0a.1[A] -> Link [LNK1] -> GSI 11 (level, low) -> IRQ 11
Apr 19 16:59:24 ian2 kernel: [   92.778094] cx88[0]/1: CX88x/0: ALSA support for cx2388x boards

-----------------------------

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Hi Ian,

Am Samstag, den 19.04.2008, 21:57 +0100 schrieb Ian Pickworth:

nice to hear from you!

I don't have that tuner in any box currently and the variant I had was always a _little_ bit critical in standard PCI slots.

Ian, are you sure that it is the released 2.6.25 showing that?

Than we should have some alert around.

Cheers,
Hermann

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

(Should have posted CC to the list - I really am rusty! sorry.)

Hello Hermann,

......

Likewise! Same old gang on cx88 then :-) .

I'm not sure how to pin down the version Gentoo provides. The syslog on bootup says:

Linux version 2.6.25-gentoo (root@ian2) (gcc version 4.1.2 (Gentoo 4.1.2 p1.0.2)) #1 PREEMPT Sat Apr 19 09:29:59 BST 2008

The gentoo-sources changelog doesn't say which version of the Kernel they picked up to make the release. I can see from the package manifest that they use linux-2.6.25.tar.bz2 as the base source, but then apply patches to make the Gentoo release. I've dug around the drivers/media/video/cx88 source a bit, but all the version comments appear to be stripped out.

Gentoo usually provide a "masked" version of the kernel for several iterations before making it "stable" in their package tree, so I would guess that this is probably an early kernel source release, if that helps.

I'm a bit rusty at this stuff, sorry.

I'd be happy to do whatever is needed to pin down the problem. As I say though, I am a bit rusty. If you tell me what to do I'll have a go.

Thanks
Regards
Ian

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Similar issue here with a Leadtek Winfast 2000XP card. Video works, but radio doesn't. For my card I can workaround the issue by adding the "tuner=38" option to the cx88xx module.

Gert

2.6.25 log:

cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
ACPI: PCI Interrupt 0000:00:0a.0[A] -> GSI 18 (level, low) -> IRQ 18 cx88[0]: subsystem: 107d:6611, board: Leadtek Winfast 2000XP Expert [card=5,autodetected] cx88[0]: TV tuner type 44, Radio tuner type -1
tuner' 1-0043: chip found @ 0x86 (cx88[0])
tda9887 1-0043: tda988[5/6/7] found
All bytes are equal. It is not a TEA5767
tuner' 1-0060: chip found @ 0xc0 (cx88[0])
tuner-simple 1-0060: type set to 44 (Philips 4 in 1 (ATI TV Wonder Pro/Conexant)) cx88[0]: Leadtek Winfast 2000XP Expert config: tuner=38, eeprom[0]=0x01
input: cx88 IR (Leadtek Winfast 2000XP as /class/input/input6
cx88[0]/0: found at 0000:00:0a.0, rev: 5, irq: 18, latency: 32, mmio: 0xe2000000 cx88[0]/0: registered device video0 [v4l2]
cx88[0]/0: registered device vbi0
cx88[0]/0: registered device radio0

2.6.24 log:

cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
ACPI: PCI Interrupt 0000:00:0a.0[A] -> GSI 18 (level, low) -> IRQ 18 cx88[0]: subsystem: 107d:6611, board: Leadtek Winfast 2000XP Expert [card=5,autodetected] cx88[0]: TV tuner type 44, Radio tuner type -1
cx88[0]: Leadtek Winfast 2000XP Expert config: tuner=38, eeprom[0]=0x01
input: cx88 IR (Leadtek Winfast 2000XP as /class/input/input6
cx88[0]/0: found at 0000:00:0a.0, rev: 5, irq: 18, latency: 32, mmio: 0xe2000000 tuner 1-0043: chip found @ 0x86 (cx88[0])
tda9887 1-0043: tda988[5/6/7] found @ 0x43 (tuner)
tuner 1-0043: type set to tda9887
All bytes are equal. It is not a TEA5767
tuner 1-0060: chip found @ 0xc0 (cx88[0])
tuner-simple 1-0060: type set to 38 (Philips PAL/SECAM multi (FM1216ME MK3)) tuner 1-0060: type set to Philips PAL/SECAM m
tuner-simple 1-0060: type set to 38 (Philips PAL/SECAM multi (FM1216ME MK3)) tuner 1-0060: type set to Philips PAL/SECAM m
cx88[0]/0: registered device video0 [v4l2]
cx88[0]/0: registered device vbi0
cx88[0]/0: registered device radio0

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

That workaround works for me as well - with "tuner=38" for cx88xx I can now tune to both video and radio channels.

So it looks like its just the auto detection that has regressed in 2.6.25.

Thanks
Regards
Ian

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Hi,

Am Sonntag, den 20.04.2008, 13:26 +0100 schrieb Ian Pickworth:

just read this and that's good, but if all cards with eeprom detection are affected, we have a problem.

I copy in what I had as reply for the previous mail so far.

tuner-simple and tda9885/6/7 support on customizing analog tuner support on this kernel, but that is not the case.

Mauro did something to get the tuner type set earlier to avoid other troubles, but this looks like setting the tuner from eeprom detection fails now, since it is already set previously and a tuner callback with the correct tuner from eeprom doesn't happen.

I can see something similar on saa7134 and a md7134. (card=12, tuner=38) That tuner detection from eeprom was not 100% reliable since a while, but only _sometimes_ a FMD1216ME was set instead the FM1216ME MK3.

Currently this will always fail on 2.6.25 if tuner=38 is not forced.

Since 2.6.25 tda9887 is out of the tuner module again, old tda9887 port and qss options against the tuner module will make it fail to load too, but this gives an error in dmesg, what is not the case here, just to note it for others.

saa7134[3]: found at 0000:01:0a.0, rev: 1, irq: 16, latency: 64, mmio: 0xe8003000 saa7134[3]: subsystem: 16be:0003, board: Medion 7134 [card=12,insmod option] saa7134[3]: board init: gpio is 0
tuner' 5-0043: chip found @ 0x86 (saa7134[3])
tda9887 5-0043: tda988[5/6/7] found
All bytes are equal. It is not a TEA5767
tuner' 5-0060: chip found @ 0xc0 (saa7134[3])
tuner-simple 5-0060: type set to 63 (Philips FMD1216ME MK3 Hybrid Tuner) saa7134[3]: i2c eeprom 00: be 16 03 00 08 20 1c 55 43 43 a9 1c 55 43 43 a9 saa7134[3]: i2c eeprom 10: ff ff ff ff 15 00 0e 01 0c c0 08 00 00 00 00 00 saa7134[3]: i2c eeprom 20: 00 00 00 e3 ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 40: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
saa7134[3] Tuner type is 38 <----------------------

saa7134[3]: registered device video3 [v4l2]
saa7134[3]: registered device vbi3
saa7134[3]: registered device radio2

Gert, do we have more regressions for the WinFast 2000XP?

OT, but do you remember on which kernel your saa7134-empress worked last? There are problems too and Frederic Cand reported a 2.6.9 working or a snapshot around that time ported. That would be odd.

Cheers,
Hermann

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

With the tuner type set manual things seem to work normally.
Teletext does not seem to work, but when I booted into 2.6.24 again, I got the same problem. Haven't used teletext for a long time, so I can't remember the last kernel version where it did work.

I did notice messages caused by the nvidia binary blob:

NVRM: bad caching on address 0xffff810039654000: actual 0x173 != expected 0x17b
NVRM: please see the README section on Cache Aliasing for more information cx88[0]: video y / packed - dma channel status dump

cx88[0]:   cmds: initial risc: 0x1ec19000
cx88[0]:   cmds: cdt base    : 0x00180440
cx88[0]:   cmds: cdt size    : 0x0000000c
cx88[0]:   cmds: iq base     : 0x00180400
cx88[0]:   cmds: iq size     : 0x00000010
cx88[0]:   cmds: risc pc     : 0x1ec6c5d8
cx88[0]:   cmds: iq wr ptr   : 0x00000109
cx88[0]:   cmds: iq rd ptr   : 0x0000010d
cx88[0]:   cmds: cdt current : 0x00000458
cx88[0]:   cmds: pci target  : 0x1ec6ab80
cx88[0]:   cmds: line / byte : 0x00900000
cx88[0]:   risc0: 0x80008200 [ sync resync count=512 ]
cx88[0]:   risc1: 0x1c000480 [ write sol eol count=1152 ]
cx88[0]:   risc2: 0x1ec1a480 [ arg #1 ]
cx88[0]:   risc3: 0x18000280 [ write sol count=640 ]
cx88[0]:   iq 0: 0x1ec1ad80 [ write sol eol irq2 23 22 cnt0 resync 13 count=3456 ]
cx88[0]:   iq 1: 0x14000200 [ arg #1 ]
cx88[0]:   iq 2: 0x1ec1b000 [ write sol eol irq2 23 22 cnt0 resync 13 12 count=0 ]
cx88[0]:   iq 3: 0x1c000480 [ arg #1 ]
cx88[0]:   iq 4: 0x1ec1b680 [ write sol eol irq2 23 22 cnt0 resync 13 12 count=1664 ]
cx88[0]:   iq 5: 0x18000080 [ arg #1 ]
cx88[0]:   iq 6: 0x1ec1bf80 [ write sol eol irq2 23 22 cnt0 resync 13 12 count=3968 ]
cx88[0]:   iq 7: 0x14000400 [ arg #1 ]
cx88[0]:   iq 8: 0x1ec1c000 [ write sol eol irq2 23 22 cnt0 resync 14 count=0 ]
cx88[0]:   iq 9: 0x1ec6a000 [ arg #1 ]
cx88[0]:   iq a: 0x1c000480 [ write sol eol count=1152 ]
cx88[0]:   iq b: 0x1ec6a700 [ arg #1 ]
cx88[0]:   iq c: 0x80008200 [ sync resync count=512 ]
cx88[0]:   iq d: 0x1c000480 [ write sol eol count=1152 ]
cx88[0]:   iq e: 0x1ec1a480 [ arg #1 ]
cx88[0]:   iq f: 0x18000280 [ write sol count=640 ]
cx88[0]:   iq 10: 0x00180c00 [ arg #1 ]
cx88[0]: fifo: 0x00180c00 -> 0x183400
cx88[0]: ctrl: 0x00180400 -> 0x180460
cx88[0]:   ptr1_reg: 0x00181680
cx88[0]:   ptr2_reg: 0x00180468
cx88[0]:   cnt1_reg: 0x00000038
cx88[0]:   cnt2_reg: 0x00000000

cx88[0]/0: [ffff810026028600/1] timeout - dma=0x1ec6c000

When using the xorg nv driver, these message do not occur.

Can't remember at which kernel version I've used it last. Since I left Philips Research about 3 years ago, I do not have access anymore to a board with a empress MPEG-2 encoder.

Gert

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Am Sonntag, den 20.04.2008, 18:18 +0200 schrieb Gert Vervoort:

Still all slots are full with saa713x stuff we recently added support for or needs some fixes, but yes, at least Mauro had it working on cx88.

On the saa7134 and ATI fglrx no issues so far, else I'm using also the xorg nv driver without issues.

Ah, thanks, didn't know that. There have been always only _very few_ people with these cards and you did pretty much work on them.

There are currently some Creatix CTX946 around. (creatix.de) They seem to come with some of the recent Medion Multimedia PCs and there are also some traders on ebay, with obviously substantial quantities, one selling them as cheap as 29€ plus shipping and declared as new.

The cards do already support analog and DVB-T, but I don't know yet from what point the driver bugs start and where the physical configuration of the card and encoder is not yet sufficient. The latter is very likely the case as well, since I have been back to 2.6.12 already.

There is also the new Behold M6 Extra now, also without safe ground for the encoder currently.

At least the potential mute problem Nickolay and me introduced by adding digital mute support for the new cards without analog audio out is fixed.

Mauro, Mike and all, you are aware of the just reported tuner detection issues. They seem to be also on current v4l-dvb.

Thanks,
Hermann

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Am Sonntag, den 20.04.2008, 23:16 +0200 schrieb hermann pitton:

Hi,

do you see the auto detection issue?

Either tell it is just nothing, what I very seriously doubt, or please comment.

I don't like to end up on LKML again getting told that written rules don't exist ;)

Cheers,
Hermann

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Sorry for now answer earlier. Too busy here, due to the merge window.

This seems to be an old bug. On several cases, tuner_type information came from some sort of autodetection schema, but the proper setup is not sent to tuner.

Please test the enclosed patch. It warrants that TUNER_SET_TYPE_ADDR is called at saa7134_board_init2() for all those boards:

SAA7134_BOARD_ADS_DUO_CARDBUS_PTV331
SAA7134_BOARD_ASUS_EUROPA2_HYBRID
SAA7134_BOARD_ASUSTeK_P7131_DUAL
SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA
SAA7134_BOARD_AVERMEDIA_SUPER_007
SAA7134_BOARD_BEHOLD_COLUMBUS_TVFM
SAA7134_BOARD_BMK_MPEX_NOTUNER
SAA7134_BOARD_BMK_MPEX_TUNER
SAA7134_BOARD_CINERGY_HT_PCI
SAA7134_BOARD_CINERGY_HT_PCMCIA
SAA7134_BOARD_CREATIX_CTX953
SAA7134_BOARD_FLYDVBT_HYBRID_CARDBUS
SAA7134_BOARD_FLYDVB_TRIO
SAA7134_BOARD_HAUPPAUGE_HVR1110
SAA7134_BOARD_KWORLD_ATSC110
SAA7134_BOARD_KWORLD_DVBT_210
SAA7134_BOARD_MD7134
SAA7134_BOARD_MEDION_MD8800_QUADRO
SAA7134_BOARD_PHILIPS_EUROPA
SAA7134_BOARD_PHILIPS_TIGER
SAA7134_BOARD_PHILIPS_TIGER_S
SAA7134_BOARD_PINNACLE_PCTV_310i
SAA7134_BOARD_TEVION_DVBT_220RF
SAA7134_BOARD_TWINHAN_DTV_DVB_3056
SAA7134_BOARD_VIDEOMATE_DVBT_200
SAA7134_BOARD_VIDEOMATE_DVBT_200A
SAA7134_BOARD_VIDEOMATE_DVBT_300

It is important to test the above boards, to be sure that no regression is caused.

diff -r 60110897e86a linux/drivers/media/video/saa7134/saa7134-cards.c
@@ -5688,16 +5688,19 @@
 int saa7134_board_init2(struct saa7134_dev *dev)
 {
 	unsigned char buf;
-	int board;
+	int board, need_init_tuner = 1;
 	struct tuner_setup tun_setup;
 	tun_setup.config = 0;
 	tun_setup.tuner_callback = saa7134_tuner_callback;
+	tun_setup.mode_mask = T_RADIO     |
+			      T_ANALOG_TV |
+			      T_DIGITAL_TV;
 
 	switch (dev->board) {
 	case SAA7134_BOARD_BMK_MPEX_NOTUNER:
 	case SAA7134_BOARD_BMK_MPEX_TUNER:
 		dev->i2c_client.addr = 0x60;
-		board = (i2c_master_recv(&dev->i2c_client,&buf,0) < 0)
+		board = (i2c_master_recv(&dev->i2c_client, &buf, 0) < 0)
 			? SAA7134_BOARD_BMK_MPEX_NOTUNER
 			: SAA7134_BOARD_BMK_MPEX_TUNER;
 		if (board == dev->board)

@@ -5707,21 +5710,9 @@
 		saa7134_boards[dev->board].name);
 		dev->tuner_type = saa7134_boards[dev->board].tuner_type;
 
-		if (TUNER_ABSENT != dev->tuner_type) {
-			tun_setup.mode_mask = T_RADIO     |
-					      T_ANALOG_TV |
-					      T_DIGITAL_TV;
-			tun_setup.type = dev->tuner_type;
-			tun_setup.addr = ADDR_UNSET;
-			tun_setup.tuner_callback = saa7134_tuner_callback;
-
-			saa7134_i2c_call_clients(dev,
-						 TUNER_SET_TYPE_ADDR,
-						 &tun_setup);
-		}
 		break;
 	case SAA7134_BOARD_MD7134:
-		{
+	{
 		u8 subaddr;
 		u8 data[3];
 		int ret, tuner_t;

@@ -5787,17 +5778,8 @@
 			saa7134_i2c_call_clients(dev, TUNER_SET_CONFIG,
 						 &tda9887_cfg);
 		}
-
-		tun_setup.mode_mask = T_RADIO     |
-				      T_ANALOG_TV |
-				      T_DIGITAL_TV;
-		tun_setup.type = dev->tuner_type;
-		tun_setup.addr = ADDR_UNSET;
-
-		saa7134_i2c_call_clients(dev,
-					 TUNER_SET_TYPE_ADDR, &tun_setup);
-		}
-		break;
+		break;
+	}
 	case SAA7134_BOARD_PHILIPS_EUROPA:
 		if (dev->autodetected && (dev->eedata[0x41] == 0x1c)) {
 			/* Reconfigure board as Snake reference design */

@@ -5809,24 +5791,20 @@
 		}
 	case SAA7134_BOARD_VIDEOMATE_DVBT_300:
 	case SAA7134_BOARD_ASUS_EUROPA2_HYBRID:
+	{
+
 		/* The Philips EUROPA based hybrid boards have the tuner connected through
 		 * the channel decoder. We have to make it transparent to find it
 		 */
-		{
 		u8 data[] = { 0x07, 0x02};
 		struct i2c_msg msg = {.addr=0x08, .flags=0, .buf=data, .len = sizeof(data)};
 		i2c_transfer(&dev->i2c_adap, &msg, 1);
 
-		tun_setup.mode_mask = T_ANALOG_TV | T_DIGITAL_TV;
-		tun_setup.type = dev->tuner_type;
-		tun_setup.addr = dev->tuner_addr;
-
-		saa7134_i2c_call_clients (dev, TUNER_SET_TYPE_ADDR,&tun_setup);
-		}
-		break;
+		break;
+	}
 	case SAA7134_BOARD_PHILIPS_TIGER:
 	case SAA7134_BOARD_PHILIPS_TIGER_S:
-		{
+	{
 		u8 data[] = { 0x3c, 0x33, 0x60};
 		struct i2c_msg msg = {.addr=0x08, .flags=0, .buf=data, .len = sizeof(data)};
 		if(dev->autodetected && (dev->eedata[0x49] == 0x50)) {

@@ -5835,17 +5813,23 @@
 				dev->name, saa7134_boards[dev->board].name);
 		}
 		if(dev->board == SAA7134_BOARD_PHILIPS_TIGER_S) {
-			tun_setup.mode_mask = T_ANALOG_TV | T_DIGITAL_TV;
-			tun_setup.type = TUNER_PHILIPS_TDA8290;
-			tun_setup.addr = 0x4b;
+			dev->tuner_type = TUNER_PHILIPS_TDA8290;
+			dev->tuner_addr = 0x4b;
+
+			tun_setup.type = dev->tuner_type;
+			tun_setup.addr = dev->tuner_addr;
 			tun_setup.config = 2;
 
-			saa7134_i2c_call_clients (dev, TUNER_SET_TYPE_ADDR,&tun_setup);
+			saa7134_i2c_call_clients(dev, TUNER_SET_TYPE_ADDR,
+						 &tun_setup);
+			need_init_tuner = 0;
+
 			data[2] = 0x68;
 		}
 		i2c_transfer(&dev->i2c_adap, &msg, 1);
-		}
-		break;
+
+		break;
+	}
 	case SAA7134_BOARD_HAUPPAUGE_HVR1110:
 		hauppauge_eeprom(dev, dev->eedata+0x80);
 		/* break intentionally omitted */

@@ -5858,52 +5842,55 @@
 	case SAA7134_BOARD_AVERMEDIA_SUPER_007:
 	case SAA7134_BOARD_TWINHAN_DTV_DVB_3056:
 	case SAA7134_BOARD_CREATIX_CTX953:
+	{
 		/* this is a hybrid board, initialize to analog mode
 		 * and configure firmware eeprom address
 		 */
-		{
 		u8 data[] = { 0x3c, 0x33, 0x60};
 		struct i2c_msg msg = {.addr=0x08, .flags=0, .buf=data, .len = sizeof(data)};
 		i2c_transfer(&dev->i2c_adap, &msg, 1);
-		}
-		break;
+		break;
+	}
 	case SAA7134_BOARD_FLYDVB_TRIO:
-		{
+	{
 		u8 data[] = { 0x3c, 0x33, 0x62};
 		struct i2c_msg msg = {.addr=0x09, .flags=0, .buf=data, .len = sizeof(data)};
 		i2c_transfer(&dev->i2c_adap, &msg, 1);
-		}
-		break;
+		break;
+	}
 	case SAA7134_BOARD_ADS_DUO_CARDBUS_PTV331:
 	case SAA7134_BOARD_FLYDVBT_HYBRID_CARDBUS:
+	{
 		/* initialize analog mode  */
-		{
 		u8 data[] = { 0x3c, 0x33, 0x6a};
 		struct i2c_msg msg = {.addr=0x08, .flags=0, .buf=data, .len = sizeof(data)};
 		i2c_transfer(&dev->i2c_adap, &msg, 1);
-		}
-		break;
+		break;
+	}
 	case SAA7134_BOARD_CINERGY_HT_PCMCIA:
 	case SAA7134_BOARD_CINERGY_HT_PCI:
+	{
 		/* initialize analog mode */
-		{
 		u8 data[] = { 0x3c, 0x33, 0x68};
 		struct i2c_msg msg = {.addr=0x08, .flags=0, .buf=data, .len = sizeof(data)};
 		i2c_transfer(&dev->i2c_adap, &msg, 1);
-		}
-		break;
+		break;
+	}
 	case SAA7134_BOARD_KWORLD_ATSC110:
-		{
-			/* enable tuner */
-			int i;
-			static const u8 buffer [] = { 0x10,0x12,0x13,0x04,0x16,0x00,0x14,0x04,0x017,0x00 };
-			dev->i2c_client.addr = 0x0a;
-			for (i = 0; i < 5; i++)
-				if (2 != i2c_master_send(&dev->i2c_client,&buffer[i*2],2))
-					printk(KERN_WARNING "%s: Unable to enable tuner(%i).\n",
-					       dev->name, i);
-		}
-		break;
+	{
+		/* enable tuner */
+		int i;
+		static const u8 buffer [] = { 0x10, 0x12, 0x13, 0x04, 0x16,
+					      0x00, 0x14, 0x04, 0x17, 0x00 };
+		dev->i2c_client.addr = 0x0a;
+		for (i = 0; i < 5; i++)
+			if (2 != i2c_master_send(&dev->i2c_client,
+						 &buffer[i*2], 2))
+				printk(KERN_WARNING
+				       "%s: Unable to enable tuner(%i).\n",
+				       dev->name, i);
+		break;
+	}
 	case SAA7134_BOARD_VIDEOMATE_DVBT_200:
 	case SAA7134_BOARD_VIDEOMATE_DVBT_200A:
 		/* The T200 and the T200A share the same pci id.  Consequently,

@@ -5928,7 +5915,7 @@
 		}
 		break;
 	case SAA7134_BOARD_BEHOLD_COLUMBUS_TVFM:
-		{
+	{
 		struct v4l2_priv_tun_config tea5767_cfg;
 		struct tea5767_ctrl ctl;
 

@@ -5939,8 +5926,20 @@
 		tea5767_cfg.tuner = TUNER_TEA5767;
 		tea5767_cfg.priv  = &ctl;
 		saa7134_i2c_call_clients(dev, TUNER_SET_CONFIG, &tea5767_cfg);
-		}
-		break;
+
+		tun_setup.mode_mask &= ~T_RADIO;
+		break;
+	}
+	default:
+		need_init_tuner = 0;
+	} /* switch() */
+
+	if ((TUNER_ABSENT != dev->tuner_type) && need_init_tuner) {
+		tun_setup.type = dev->tuner_type;
+		tun_setup.addr = dev->tuner_addr;
+		tun_setup.tuner_callback = saa7134_tuner_callback;
+
+		saa7134_i2c_call_clients(dev, TUNER_SET_TYPE_ADDR, &tun_setup);
 	}
 
 	if (dev->tuner_type == TUNER_XC2028) {

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Mauro,

I didn't review your patch yet, and it needs to be tested, however, the bug reported in this thread deals with the same regression that you are attempting to repair, but on the cx88 driver -- not the saa7134 driver.

Both drivers need to be tested to make sure that this regression has been fixed.

-Mike

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Hmm... it seems that people merged two similar issues together, on different drivers. At least, part of the reports at the thread were with saa7134 driver.

I'll investigate if this solution will also work for cx88.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

drivers

regression

please

came from

tuner.

called

is

08:04:54 2008 -0300

10:44:16 2008 -0300

different

driver.

Mauro,

"...people merged two similar issues together, on different drivers..." It was you -- did you forget?

cx88: http://linuxtv.org/hg/v4l-dvb/rev/2eb392c86745

saa7134: http://linuxtv.org/hg/v4l-dvb/rev/e7668fc3666c

I'm surprised that you don't remember this -- you pushed this to Linus late in the 2.6.25-rcX, after I had strongly advised against this -- I warned you that this may create regressions, needed thorough testing, and was too risky a change to push into the middle of 2.6.25-rc

I hate to say, "I told you so" .... but.............

;-)

Lets get your fixes tested ASAP so we can fix 2.6.25-stable.

Regards,

Mike

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Hi,

Am Freitag, den 25.04.2008, 11:06 -0400 schrieb [email protected]:

I started already yesterday evening to test if the tuner eeprom detection will come back for one of the md7134 cards on saa7134 by reverting the above changeset.

To my surprise not. Only reloading the tuner stuff detects the right tuner.

Since it became too late then, I have now repeated it on a 2.6.25 and get the same. Can't say when it started, since no free slots for such cards during the last months.

Will try with Mauro's saa7134-cards.c patch later.

Cheers,
Hermann

Linux video capture interface: v2.00
saa7130/34: v4l2 driver version 0.2.14 loaded
saa7133[0]: setting pci latency timer to 64
saa7133[0]: found at 0000:01:07.0, rev: 208, irq: 19, latency: 64, mmio: 0xe8000000 saa7133[0]: subsystem: 1043:4857, board: Philips Tiger reference design [card=81,insmod option] saa7133[0]: board init: gpio is 200000
saa7133[0]: i2c eeprom 00: 43 10 57 48 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[0]: i2c eeprom 10: 00 01 20 00 ff 20 ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 20: 01 40 01 02 03 01 01 03 08 ff 00 cb ff ff ff ff saa7133[0]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 40: ff 21 00 c2 96 10 03 32 15 00 ff ff ff ff ff ff saa7133[0]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff tuner' 2-004b: chip found @ 0x96 (saa7133[0])
tda829x 2-004b: setting tuner address to 61
tda829x 2-004b: type set to tda8290+75a
saa7133[0]: registered device video0 [v4l2]
saa7133[0]: registered device vbi0
saa7133[0]: registered device radio0
saa7133[1]: setting pci latency timer to 64
saa7133[1]: found at 0000:01:08.0, rev: 208, irq: 18, latency: 64, mmio: 0xe8001000 saa7133[1]: subsystem: 1043:4862, board: ASUSTeK P7131 Dual [card=78,autodetected] saa7133[1]: board init: gpio is 0
input: saa7134 IR (ASUSTeK P7131 Dual) as /class/input/input11
tuner' 3-004b: chip found @ 0x96 (saa7133[1])
tda829x 3-004b: setting tuner address to 61
tda829x 3-004b: type set to tda8290+75a
saa7133[1]: i2c eeprom 00: 43 10 62 48 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[1]: i2c eeprom 10: 00 01 20 00 ff 20 ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 20: 01 40 01 02 03 01 01 03 08 ff 00 d6 ff ff ff ff saa7133[1]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 40: ff 21 00 c2 96 10 03 32 15 00 ff ff ff ff ff ff saa7133[1]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: registered device video1 [v4l2]
saa7133[1]: registered device vbi1
saa7133[1]: registered device radio1
saa7133[2]: setting pci latency timer to 64
saa7133[2]: found at 0000:01:09.0, rev: 209, irq: 17, latency: 64, mmio: 0xe8002000 saa7133[2]: subsystem: 16be:0010, board: Medion/Creatix CTX953 Hybrid [card=134,autodetected] saa7133[2]: board init: gpio is 0
tuner' 4-004b: chip found @ 0x96 (saa7133[2])
tda829x 4-004b: setting tuner address to 60
tda829x 4-004b: type set to tda8290+75a
saa7133[2]: i2c eeprom 00: be 16 10 00 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[2]: i2c eeprom 10: 00 ff 86 0f ff 20 ff 00 01 50 32 79 01 3c ca 50 saa7133[2]: i2c eeprom 20: 01 40 01 02 02 03 01 00 06 ff 00 2c 02 51 96 2b saa7133[2]: i2c eeprom 30: a7 58 7a 1f 03 8e 84 5e da 7a 04 b3 05 87 b2 3c saa7133[2]: i2c eeprom 40: ff 21 00 c0 96 10 03 22 15 00 fd 79 44 9f c2 8f saa7133[2]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: registered device video2 [v4l2]
saa7133[2]: registered device vbi2
saa7134[3]: setting pci latency timer to 64
saa7134[3]: found at 0000:01:0a.0, rev: 1, irq: 16, latency: 64, mmio: 0xe8003000 saa7134[3]: subsystem: 16be:0003, board: Medion 7134 [card=12,autodetected] saa7134[3]: board init: gpio is 0
tuner' 5-0043: chip found @ 0x86 (saa7134[3])
tda9887 5-0043: creating new instance
tda9887 5-0043: tda988[5/6/7] found
All bytes are equal. It is not a TEA5767
tuner' 5-0060: chip found @ 0xc0 (saa7134[3])
tuner-simple 5-0060: creating new instance
tuner-simple 5-0060: type set to 63 (Philips FMD1216ME MK3 Hybrid Tuner) saa7134[3]: i2c eeprom 00: be 16 03 00 08 20 1c 55 43 43 a9 1c 55 43 43 a9 saa7134[3]: i2c eeprom 10: ff ff ff ff 15 00 0e 01 0c c0 08 00 00 00 00 00 saa7134[3]: i2c eeprom 20: 00 00 00 e3 ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 40: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3] Tuner type is 38
saa7134[3]: registered device video3 [v4l2]
saa7134[3]: registered device vbi3
saa7134[3]: registered device radio2
DVB: registering new adapter (saa7133[0])
DVB: registering frontend 0 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 29 -- ok
DVB: registering new adapter (saa7133[1])
DVB: registering frontend 1 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 29 -- ok
DVB: registering new adapter (saa7133[2])
DVB: registering frontend 2 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 26 -- ok
saa7134[3]/dvb: frontend initialization failed
tda9887 5-0043: destroying instance
tuner-simple 5-0060: destroying instance
tuner' 2-004b: chip found @ 0x96 (saa7133[0])
tda829x 2-004b: setting tuner address to 61
tda829x 2-004b: type set to tda8290+75a
tuner' 3-004b: chip found @ 0x96 (saa7133[1])
tda829x 3-004b: setting tuner address to 61
tda829x 3-004b: type set to tda8290+75a
tuner' 4-004b: chip found @ 0x96 (saa7133[2])
tda829x 4-004b: setting tuner address to 60
tda829x 4-004b: type set to tda8290+75a
tuner' 5-0043: chip found @ 0x86 (saa7134[3])
tda9887 5-0043: creating new instance
tda9887 5-0043: tda988[5/6/7] found
All bytes are equal. It is not a TEA5767
tuner' 5-0060: chip found @ 0xc0 (saa7134[3])
tuner-simple 5-0060: creating new instance
tuner-simple 5-0060: type set to 38 (Philips PAL/SECAM multi (FM1216ME MK3)) [root@pc10 v4l-dvb-init2-reverted]# hg diff

diff -r 5c9a4decb57b linux/drivers/media/video/saa7134/saa7134-core.c
@@ -1089,13 +1089,12 @@ static int __devinit saa7134_initdev(str
        saa7134_i2c_register(dev);
 
        /* initialize hardware #2 */
-       if (TUNER_ABSENT != dev->tuner_type)
-               request_module("tuner");
        saa7134_board_init2(dev);
-
        saa7134_hwinit2(dev);
 
        /* load i2c helpers */
+       if (TUNER_ABSENT != dev->tuner_type)
+               request_module("tuner");
        if (card_is_empress(dev)) {
                request_module("saa6752hs");
        }

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Am Freitag, den 25.04.2008, 23:48 +0200 schrieb hermann pitton:

[snip]

With a new v4l-dvb copy and only Mauro's saa7134-cards.c patch applied, it is the same as previously for now. Seems tuner-simple doesn't act on it.

I had to replace the previous md7134 with tuner=38 with another one with tuner=5. The first one has a second PCI bridge for ISDN and most machines don't like that ;)

Logs attached including tuner reload.

Cheers,
Hermann

Linux video capture interface: v2.00
saa7130/34: v4l2 driver version 0.2.14 loaded
saa7133[0]: setting pci latency timer to 64
saa7133[0]: found at 0000:01:07.0, rev: 208, irq: 19, latency: 64, mmio: 0xe8000000 saa7133[0]: subsystem: 1043:4857, board: Philips Tiger reference design [card=81,insmod option] saa7133[0]: board init: gpio is 200000
saa7133[0]/core: hwinit1
tuner' 2-004b: tda829x detected
tuner' 2-004b: Setting mode_mask to 0x0e
tuner' 2-004b: chip found @ 0x96 (saa7133[0])
tuner' 2-004b: tuner 0x4b: Tuner type absent
tuner' 2-004b: Calling set_type_addr for type=54, addr=0xff, mode=0x04, config=0x00 tuner' 2-004b: set addr for type -1
tuner' 2-004b: defining GPIO callback
tda829x 2-004b: setting tuner address to 61
tda829x 2-004b: type set to tda8290+75a
tuner' 2-004b: type set to tda8290+75a
tuner' 2-004b: tv freq set to 400.00
tuner' 2-004b: saa7133[0] tuner' I2C addr 0x96 with type 54 used for 0x0e saa7133[0]: i2c eeprom 00: 43 10 57 48 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[0]: i2c eeprom 10: 00 01 20 00 ff 20 ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 20: 01 40 01 02 03 01 01 03 08 ff 00 cb ff ff ff ff saa7133[0]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 40: ff 21 00 c2 96 10 03 32 15 00 ff ff ff ff ff ff saa7133[0]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff tuner' 2-004b: Calling set_type_addr for type=54, addr=0x00, mode=0x0e, config=0x00 tuner' 2-004b: set addr for type 54
saa7133[0]/core: hwinit2
tuner' 2-004b: switching to v4l2
tuner' 2-004b: tv freq set to 400.00
tuner' 2-004b: tv freq set to 400.00
saa7133[0]: registered device video0 [v4l2]
saa7133[0]: registered device vbi0
saa7133[0]: registered device radio0
tuner' 2-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
saa7133[1]: setting pci latency timer to 64
saa7133[1]: found at 0000:01:08.0, rev: 208, irq: 18, latency: 64, mmio: 0xe8001000 saa7133[1]: subsystem: 1043:4862, board: ASUSTeK P7131 Dual [card=78,autodetected] saa7133[1]: board init: gpio is 0
saa7133[1]/core: hwinit1
input: saa7134 IR (ASUSTeK P7131 Dual) as /class/input/input10
tuner' 3-004b: tda829x detected
tuner' 3-004b: Setting mode_mask to 0x0e
tuner' 3-004b: chip found @ 0x96 (saa7133[1])
tuner' 3-004b: tuner 0x4b: Tuner type absent
tuner' 3-004b: Calling set_type_addr for type=54, addr=0xff, mode=0x04, config=0x00 tuner' 3-004b: set addr for type -1
tuner' 3-004b: defining GPIO callback
tda829x 3-004b: setting tuner address to 61
tda829x 3-004b: type set to tda8290+75a
tuner' 3-004b: type set to tda8290+75a
tuner' 3-004b: tv freq set to 400.00
tuner' 3-004b: saa7133[1] tuner' I2C addr 0x96 with type 54 used for 0x0e saa7133[1]: i2c eeprom 00: 43 10 62 48 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[1]: i2c eeprom 10: 00 01 20 00 ff 20 ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 20: 01 40 01 02 03 01 01 03 08 ff 00 d6 ff ff ff ff saa7133[1]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 40: ff 21 00 c2 96 10 03 32 15 00 ff ff ff ff ff ff saa7133[1]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff tuner' 3-004b: Calling set_type_addr for type=54, addr=0x00, mode=0x0e, config=0x00 tuner' 3-004b: set addr for type 54
saa7133[1]/core: hwinit2
tuner' 3-004b: switching to v4l2
tuner' 3-004b: tv freq set to 400.00
tuner' 3-004b: tv freq set to 400.00
saa7133[1]: registered device video1 [v4l2]
saa7133[1]: registered device vbi1
saa7133[1]: registered device radio1
tuner' 3-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
saa7133[2]: setting pci latency timer to 64
saa7133[2]: found at 0000:01:09.0, rev: 209, irq: 17, latency: 64, mmio: 0xe8002000 saa7133[2]: subsystem: 16be:0010, board: Medion/Creatix CTX953 Hybrid [card=134,autodetected] saa7133[2]: board init: gpio is 0
saa7133[2]/core: hwinit1
tuner' 4-004b: tda829x detected
tuner' 4-004b: Setting mode_mask to 0x0e
tuner' 4-004b: chip found @ 0x96 (saa7133[2])
tuner' 4-004b: tuner 0x4b: Tuner type absent
tuner' 4-004b: Calling set_type_addr for type=54, addr=0xff, mode=0x04, config=0x00 tuner' 4-004b: set addr for type -1
tuner' 4-004b: defining GPIO callback
tda829x 4-004b: setting tuner address to 60
tda829x 4-004b: type set to tda8290+75a
tuner' 4-004b: type set to tda8290+75a
tuner' 4-004b: tv freq set to 400.00
tuner' 4-004b: saa7133[2] tuner' I2C addr 0x96 with type 54 used for 0x0e saa7133[2]: i2c eeprom 00: be 16 10 00 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[2]: i2c eeprom 10: 00 ff 86 0f ff 20 ff 00 01 50 32 79 01 3c ca 50 saa7133[2]: i2c eeprom 20: 01 40 01 02 02 03 01 00 06 ff 00 2c 02 51 96 2b saa7133[2]: i2c eeprom 30: a7 58 7a 1f 03 8e 84 5e da 7a 04 b3 05 87 b2 3c saa7133[2]: i2c eeprom 40: ff 21 00 c0 96 10 03 22 15 00 fd 79 44 9f c2 8f saa7133[2]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff tuner' 4-004b: Calling set_type_addr for type=54, addr=0x00, mode=0x0e, config=0x00 tuner' 4-004b: set addr for type 54
saa7133[2]/core: hwinit2
tuner' 4-004b: switching to v4l2
tuner' 4-004b: tv freq set to 400.00
tuner' 4-004b: tv freq set to 400.00
saa7133[2]: registered device video2 [v4l2]
saa7133[2]: registered device vbi2
tuner' 4-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
saa7134[3]: setting pci latency timer to 64
saa7134[3]: found at 0000:01:0a.0, rev: 1, irq: 16, latency: 64, mmio: 0xe8003000 saa7134[3]: subsystem: 16be:0003, board: Medion 7134 [card=12,autodetected] saa7134[3]: board init: gpio is 0
saa7134[3]/core: hwinit1
All bytes are equal. It is not a TEA5767
tuner' 5-0060: Setting mode_mask to 0x0e
tuner' 5-0060: chip found @ 0xc0 (saa7134[3])
tuner' 5-0060: tuner 0x60: Tuner type absent
tuner' 5-0060: Calling set_type_addr for type=63, addr=0xff, mode=0x04, config=0x00 tuner' 5-0060: set addr for type -1
tuner' 5-0060: defining GPIO callback
tuner-simple 5-0060: creating new instance
tuner-simple 5-0060: type set to 63 (Philips FMD1216ME MK3 Hybrid Tuner) tuner-simple 5-0060: tuner 0 atv rf input will be autoselected
tuner-simple 5-0060: tuner 0 dtv rf input will be autoselected
tuner' 5-0060: type set to Philips FMD1216ME M
tuner' 5-0060: tv freq set to 400.00
tuner-simple 5-0060: using tuner params #0 (pal)
tuner-simple 5-0060: freq = 400.00 (6400), range = 1, config = 0x86, cb = 0x52 tuner-simple 5-0060: Freq= 400.00 MHz, V_IF=38.93 MHz, Offset=0.00 MHz, div=7023 tuner-simple 5-0060: tv 0x1b 0x6f 0x86 0x52
tuner' 5-0060: saa7134[3] tuner' I2C addr 0xc0 with type 63 used for 0x0e saa7134[3]: i2c eeprom 00: be 16 03 00 08 20 1c 55 43 43 a9 1c 55 43 43 a9 saa7134[3]: i2c eeprom 10: ff ff ff ff 15 00 0e 01 03 c0 08 00 00 00 00 00 saa7134[3]: i2c eeprom 20: 00 00 00 da ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 40: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3] Tuner type is 5
tuner' 5-0060: Calling set_type_addr for type=5, addr=0x00, mode=0x0e, config=0x00 tuner' 5-0060: set addr for type 63
saa7134[3]/core: hwinit2
tuner' 5-0060: switching to v4l2
tuner' 5-0060: tv freq set to 400.00
tuner-simple 5-0060: using tuner params #0 (pal)
tuner-simple 5-0060: freq = 400.00 (6400), range = 1, config = 0x86, cb = 0x52 tuner-simple 5-0060: Freq= 400.00 MHz, V_IF=38.93 MHz, Offset=0.00 MHz, div=7023 tuner-simple 5-0060: tv 0x1b 0x6f 0x86 0x52
tuner' 5-0060: tv freq set to 400.00
tuner-simple 5-0060: using tuner params #0 (pal)
tuner-simple 5-0060: freq = 400.00 (6400), range = 1, config = 0x86, cb = 0x52 tuner-simple 5-0060: Freq= 400.00 MHz, V_IF=38.93 MHz, Offset=0.00 MHz, div=7023 tuner-simple 5-0060: tv 0x1b 0x6f 0x86 0x52
saa7134[3]: registered device video3 [v4l2]
saa7134[3]: registered device vbi3
saa7134[3]: registered device radio2
tuner' 5-0060: Cmd TUNER_SET_STANDBY accepted for analog TV
DVB: registering new adapter (saa7133[0])
DVB: registering frontend 0 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 29 -- ok
saa7133[0]/core: setting GPIO21 to static 1
DVB: registering new adapter (saa7133[1])
DVB: registering frontend 1 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 29 -- ok
saa7133[1]/core: setting GPIO21 to static 0
DVB: registering new adapter (saa7133[2])
DVB: registering frontend 2 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 26 -- ok
saa7134[3]/dvb: frontend initialization failed
tuner-simple 5-0060: destroying instance
tuner' 2-004b: chip found @ 0x96 (saa7133[0])
tda829x 2-004b: setting tuner address to 61
tda829x 2-004b: type set to tda8290+75a
tuner' 3-004b: chip found @ 0x96 (saa7133[1])
tda829x 3-004b: setting tuner address to 61
tda829x 3-004b: type set to tda8290+75a
tuner' 4-004b: chip found @ 0x96 (saa7133[2])
tda829x 4-004b: setting tuner address to 60
tda829x 4-004b: type set to tda8290+75a
All bytes are equal. It is not a TEA5767
tuner' 5-0060: chip found @ 0xc0 (saa7134[3])
tuner-simple 5-0060: creating new instance
tuner-simple 5-0060: type set to 5 (Philips PAL_BG (FI1216 and compatibles))

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

The fix weren't caused by the changesets you've pointed, but are much older. If you try to revert both changesets and load tuner before cx88/saa7134, or compile tuner statically, you'll notice exact the same issue.

The issue is that set_type_addr were called at the wrong place.

Anyway, I've just committed a patch that should fix this for cx88. I'll soon use the same logic to fix also saa7134.

I've also added a patch for tuner-core, to improve debug (of course, this doesn't need to go to -stable). This helps to see the bug, if tuner debug is enabled.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Hi Mauro,
I have pulled the latest Mercurial source (at about 13:30 BST), compiled and installed. I also removed the "tuner=38" workaround from my modprobe.conf file. On reboot the WinTV cx88 card was detected correctly
- thus curing the original problem in the standard 2.6.25 drivers.
Also, tvtime works OK with created devices - tuning to all 5 channels OK.
The dmesg trace is below.

About how long would it take for a fix like this to reach the kernel tree - any chance for 2.6.25?

Many thanks
Regards
Ian

[   36.728100] cx88[0]: subsystem: 0070:3401, board: Hauppauge WinTV 34xxx models [card=1,autodetected]
[   36.728100] cx88[0]: TV tuner type -1, Radio tuner type -1
[   37.029329] tuner' 4-0043: chip found @ 0x86 (cx88[0])
[   37.029335] tda9887 4-0043: creating new instance
[   37.029337] tda9887 4-0043: tda988[5/6/7] found
[   37.032817] tuner' 4-0061: chip found @ 0xc2 (cx88[0])
[   37.085829] tveeprom 4-0050: Hauppauge model 34519, rev J157, serial# 2906136
[   37.085834] tveeprom 4-0050: tuner model is Philips FM1216 ME MK3 (idx 57, type 38)
[   37.085838] tveeprom 4-0050: TV standards PAL(B/G) PAL(I) SECAM(L/L') PAL(D/D1/K) (eeprom 0x74)
[   37.085841] tveeprom 4-0050: audio processor is CX881 (idx 31)
[   37.085843] tveeprom 4-0050: has radio
[   37.085845] cx88[0]: hauppauge eeprom: model=34519
[   37.086224] tuner-simple 4-0061: creating new instance
[   37.086227] tuner-simple 4-0061: type set to 38 (Philips PAL/SECAM multi (FM1216ME MK3))
[   37.089686] input: cx88 IR (Hauppauge WinTV 34xxx  as /class/input/input7
[   37.092223] cx88[0]/1: CX88x/0: ALSA support for cx2388x boards
[   37.095311] ACPI: PCI Interrupt 0000:01:0a.0[A] -> Link [LNK1] -> GSI 11 (level, low) -> IRQ 11
[   37.095323] cx88[0]/0: found at 0000:01:0a.0, rev: 5, irq: 11, latency: 32, mmio: 0xe9000000
[   37.095356] cx88[0]/0: registered device video0 [v4l2]
[   37.095375] cx88[0]/0: registered device vbi0
[   37.095391] cx88[0]/0: registered device radio0

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Thanks for your tests. Please try also to load first tuner, and then cx88.

I'll wait for one or two days for more people to test. Then, I'll send to mainstream, together with saa7134 fix for the same issue.

After mainstream merge, we'll send for 2.6.25. I think this should also be sent to 2.6.24, since the same bug is present on older versions, if tuner is loaded before cx88 or saa7134.

Btw, I've just added the corresponding saa7134 patch.

Hermann,

Could you test it please?

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Am Samstag, den 26.04.2008, 11:06 -0300 schrieb Mauro Carvalho Chehab:

Hi,

Mauro, just came back.

Cool stuff!

Works immediately for all tuners again. Analog TV, radio and DVB-T on that machine is tested.

Maybe Hartmut can help too, but I will test also on the triple stuff and the FMD1216ME/I MK3 hybrid tomorrow.

Thanks and cheers,
Hermann

tuner-simple 5-0060: destroying instance
Linux video capture interface: v2.00
saa7130/34: v4l2 driver version 0.2.14 loaded
saa7133[0]: setting pci latency timer to 64
saa7133[0]: found at 0000:01:07.0, rev: 208, irq: 19, latency: 64, mmio: 0xe8000000 saa7133[0]: subsystem: 1043:4857, board: Philips Tiger reference design [card=81,insmod option] saa7133[0]: board init: gpio is 0
saa7133[0]/core: hwinit1
tuner' 2-004b: tda829x detected
tuner' 2-004b: Setting mode_mask to 0x0e
tuner' 2-004b: chip found @ 0x96 (saa7133[0])
tuner' 2-004b: tuner 0x4b: Tuner type absent
saa7133[0]: i2c eeprom 00: 43 10 57 48 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[0]: i2c eeprom 10: 00 01 20 00 ff 20 ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 20: 01 40 01 02 03 01 01 03 08 ff 00 cb ff ff ff ff saa7133[0]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 40: ff 21 00 c2 96 10 03 32 15 00 ff ff ff ff ff ff saa7133[0]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff tuner' 2-004b: Calling set_type_addr for type=54, addr=0xff, mode=0x0e, config=0x00 tuner' 2-004b: defining GPIO callback
tda829x 2-004b: setting tuner address to 61
tda829x 2-004b: type set to tda8290+75a
tuner' 2-004b: type set to tda8290+75a
tuner' 2-004b: tv freq set to 400.00
tuner' 2-004b: saa7133[0] tuner' I2C addr 0x96 with type 54 used for 0x0e saa7133[0]/core: hwinit2
tuner' 2-004b: switching to v4l2
tuner' 2-004b: tv freq set to 400.00
tuner' 2-004b: tv freq set to 400.00
saa7133[0]: registered device video0 [v4l2]
saa7133[0]: registered device vbi0
saa7133[0]: registered device radio0
tuner' 2-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
saa7133[1]: setting pci latency timer to 64
saa7133[1]: found at 0000:01:08.0, rev: 208, irq: 18, latency: 64, mmio: 0xe8001000 saa7133[1]: subsystem: 1043:4862, board: ASUSTeK P7131 Dual [card=78,autodetected] saa7133[1]: board init: gpio is 0
saa7133[1]/core: hwinit1
input: saa7134 IR (ASUSTeK P7131 Dual) as /class/input/input6
tuner' 3-004b: tda829x detected
tuner' 3-004b: Setting mode_mask to 0x0e
tuner' 3-004b: chip found @ 0x96 (saa7133[1])
tuner' 3-004b: tuner 0x4b: Tuner type absent
saa7133[1]: i2c eeprom 00: 43 10 62 48 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[1]: i2c eeprom 10: 00 01 20 00 ff 20 ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 20: 01 40 01 02 03 01 01 03 08 ff 00 d6 ff ff ff ff saa7133[1]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 40: ff 21 00 c2 96 10 03 32 15 00 ff ff ff ff ff ff saa7133[1]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff tuner' 3-004b: Calling set_type_addr for type=54, addr=0xff, mode=0x0e, config=0x00 tuner' 3-004b: defining GPIO callback
tda829x 3-004b: setting tuner address to 61
tda829x 3-004b: type set to tda8290+75a
tuner' 3-004b: type set to tda8290+75a
tuner' 3-004b: tv freq set to 400.00
tuner' 3-004b: saa7133[1] tuner' I2C addr 0x96 with type 54 used for 0x0e saa7133[1]/core: hwinit2
tuner' 3-004b: switching to v4l2
tuner' 3-004b: tv freq set to 400.00
tuner' 3-004b: tv freq set to 400.00
saa7133[1]: registered device video1 [v4l2]
saa7133[1]: registered device vbi1
saa7133[1]: registered device radio1
tuner' 3-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
saa7133[2]: setting pci latency timer to 64
saa7133[2]: found at 0000:01:09.0, rev: 209, irq: 17, latency: 64, mmio: 0xe8002000 saa7133[2]: subsystem: 16be:0010, board: Medion/Creatix CTX953 Hybrid [card=134,autodetected] saa7133[2]: board init: gpio is 0
saa7133[2]/core: hwinit1
tuner' 4-004b: tda829x detected
tuner' 4-004b: Setting mode_mask to 0x0e
tuner' 4-004b: chip found @ 0x96 (saa7133[2])
tuner' 4-004b: tuner 0x4b: Tuner type absent
saa7133[2]: i2c eeprom 00: be 16 10 00 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[2]: i2c eeprom 10: 00 ff 86 0f ff 20 ff 00 01 50 32 79 01 3c ca 50 saa7133[2]: i2c eeprom 20: 01 40 01 02 02 03 01 00 06 ff 00 2c 02 51 96 2b saa7133[2]: i2c eeprom 30: a7 58 7a 1f 03 8e 84 5e da 7a 04 b3 05 87 b2 3c saa7133[2]: i2c eeprom 40: ff 21 00 c0 96 10 03 22 15 00 fd 79 44 9f c2 8f saa7133[2]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff tuner' 4-004b: Calling set_type_addr for type=54, addr=0xff, mode=0x0e, config=0x00 tuner' 4-004b: defining GPIO callback
tda829x 4-004b: setting tuner address to 60
tda829x 4-004b: type set to tda8290+75a
tuner' 4-004b: type set to tda8290+75a
tuner' 4-004b: tv freq set to 400.00
tuner' 4-004b: saa7133[2] tuner' I2C addr 0x96 with type 54 used for 0x0e saa7133[2]/core: hwinit2
tuner' 4-004b: switching to v4l2
tuner' 4-004b: tv freq set to 400.00
tuner' 4-004b: tv freq set to 400.00
saa7133[2]: registered device video2 [v4l2]
saa7133[2]: registered device vbi2
tuner' 4-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
saa7134[3]: setting pci latency timer to 64
saa7134[3]: found at 0000:01:0a.0, rev: 1, irq: 16, latency: 64, mmio: 0xe8003000 saa7134[3]: subsystem: 16be:0003, board: Medion 7134 [card=12,autodetected] saa7134[3]: board init: gpio is 0
saa7134[3]/core: hwinit1
All bytes are equal. It is not a TEA5767
tuner' 5-0060: Setting mode_mask to 0x0e
tuner' 5-0060: chip found @ 0xc0 (saa7134[3])
tuner' 5-0060: tuner 0x60: Tuner type absent
saa7134[3]: i2c eeprom 00: be 16 03 00 08 20 1c 55 43 43 a9 1c 55 43 43 a9 saa7134[3]: i2c eeprom 10: ff ff ff ff 15 00 0e 01 03 c0 08 00 00 00 00 00 saa7134[3]: i2c eeprom 20: 00 00 00 da ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 40: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3] Tuner type is 5
tuner' 5-0060: Calling set_type_addr for type=5, addr=0xff, mode=0x0e, config=0x00 tuner' 5-0060: defining GPIO callback
tuner-simple 5-0060: creating new instance
tuner-simple 5-0060: type set to 5 (Philips PAL_BG (FI1216 and compatibles)) tuner-simple 5-0060: tuner 0 atv rf input will be autoselected
tuner-simple 5-0060: tuner 0 dtv rf input will be autoselected
tuner' 5-0060: type set to Philips PAL_BG (FI1
tuner' 5-0060: tv freq set to 400.00
tuner-simple 5-0060: using tuner params #0 (pal)
tuner-simple 5-0060: freq = 400.00 (6400), range = 1, config = 0x8e, cb = 0x90 tuner-simple 5-0060: Freq= 400.00 MHz, V_IF=38.93 MHz, Offset=0.00 MHz, div=7023 tuner-simple 5-0060: tv 0x1b 0x6f 0x8e 0x90
tuner' 5-0060: saa7134[3] tuner' I2C addr 0xc0 with type 5 used for 0x0e saa7134[3]/core: hwinit2
tuner' 5-0060: switching to v4l2
tuner' 5-0060: tv freq set to 400.00
tuner-simple 5-0060: using tuner params #0 (pal)
tuner-simple 5-0060: freq = 400.00 (6400), range = 1, config = 0x8e, cb = 0x90 tuner-simple 5-0060: Freq= 400.00 MHz, V_IF=38.93 MHz, Offset=0.00 MHz, div=7023 tuner-simple 5-0060: tv 0x1b 0x6f 0x8e 0x90
tuner' 5-0060: tv freq set to 400.00
tuner-simple 5-0060: using tuner params #0 (pal)
tuner-simple 5-0060: freq = 400.00 (6400), range = 1, config = 0x8e, cb = 0x90 tuner-simple 5-0060: Freq= 400.00 MHz, V_IF=38.93 MHz, Offset=0.00 MHz, div=7023 tuner-simple 5-0060: tv 0x1b 0x6f 0x8e 0x90
saa7134[3]: registered device video3 [v4l2]
saa7134[3]: registered device vbi3
saa7134[3]: registered device radio2
tuner' 5-0060: Cmd TUNER_SET_STANDBY accepted for analog TV
DVB: registering new adapter (saa7133[0])
DVB: registering frontend 0 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 29 -- ok
saa7133[0]/core: setting GPIO21 to static 1
DVB: registering new adapter (saa7133[1])
DVB: registering frontend 1 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 29 -- ok
saa7133[1]/core: setting GPIO21 to static 0
DVB: registering new adapter (saa7133[2])
DVB: registering frontend 2 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 26 -- ok
saa7134[3]/dvb: frontend initialization failed

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Thanks. I'll add it to the patch.

Thanks.

It would be helpful if tda9887 conf could also be validated. I didn't touch at the logic, but I saw some weird things:

For example, SAA7134_BOARD_PHILIPS_EUROPA defines this:

	.tda9887_conf   = TDA9887_PRESENT | TDA9887_PORT1_ACTIVE

And SAA7134_BOARD_PHILIPS_SNAKE keep the default values.

However, there's an autodetection code that changes from EUROPA to SNAKE, without cleaning tda9887_conf:

        case SAA7134_BOARD_PHILIPS_EUROPA:
                if (dev->autodetected && (dev->eedata[0x41] == 0x1c)) {
                        /* Reconfigure board as Snake reference design */
                        dev->board = SAA7134_BOARD_PHILIPS_SNAKE;
                        dev->tuner_type = saa7134_boards[dev->board].tuner_type;
                        printk(KERN_INFO "%s: Reconfigured board as %s\n",
                                dev->name, saa7134_boards[dev->board].name);
                        break;

I'm not sure if .tda9887_conf is missing at SNAKE board entry, or if the above code should be doing, instead:

	dev->tda9887_conf = saa7134_boards[dev->board].tda9887_conf;

If the right thing to do is to initialize SNAKE with the same tda9887 parameters as EUROPE, the better would be to add the .tda9887_conf to SNAKE entry.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Hi,

Am Samstag, den 26.04.2008, 20:19 -0300 schrieb Mauro Carvalho Chehab:

Hartmut has the board and knows better, but it looks like it only has DVB-S and external analog video inputs. There is TUNER_ABSENT set, no analog tuner, no tda9887 and also no DVB-T, but it unfortunately shares the subsystem with the Philips Europa.

I notice some unwanted behavior when testing md7134 FMD1216ME hybrid boards.

Unchanged is that the tda9887 is not up for analog after boot. Previously one did reload "tuner" just once and was done.

Now, modprobe vr tuner and modprobe -v tuner results in

tuner' 2-004b: tda829x detected
tuner' 2-004b: Setting mode_mask to 0x0e
tuner' 2-004b: chip found @ 0x96 (saa7133[0])
tuner' 2-004b: tuner 0x4b: Tuner type absent
tuner' 3-004b: tda829x detected
tuner' 3-004b: Setting mode_mask to 0x0e
tuner' 3-004b: chip found @ 0x96 (saa7133[1])
tuner' 3-004b: tuner 0x4b: Tuner type absent
tuner' 4-004b: tda829x detected
tuner' 4-004b: Setting mode_mask to 0x0e
tuner' 4-004b: chip found @ 0x96 (saa7133[2])
tuner' 4-004b: tuner 0x4b: Tuner type absent
tuner' 5-0043: chip found @ 0x86 (saa7134[3])
tda9887 5-0043: creating new instance
tda9887 5-0043: tda988[5/6/7] found
tuner' 5-0043: type set to tda9887
tuner' 5-0043: tv freq set to 0.00
tuner' 5-0043: TV freq (0.00) out of range (44-958) tuner' 5-0043: saa7134[3] tuner' I2C addr 0x86 with type 74 used for 0x0e
tuner' 5-0061: Setting mode_mask to 0x0e
tuner' 5-0061: chip found @ 0xc2 (saa7134[3])
tuner' 5-0061: tuner 0x61: Tuner type absent

So tests were not complete and it is not finished yet ;)

DVB-T still works, but analog of course not.

A "modprobe -vr saa7134-dvb" and then "modprobe -v saa7134" brings them all back, including enabling analog TV on the FMD1216ME and tda9887.

Cheers,
Hermann

Linux video capture interface: v2.00
saa7130/34: v4l2 driver version 0.2.14 loaded
saa7133[0]: setting pci latency timer to 64
saa7133[0]: found at 0000:01:07.0, rev: 208, irq: 19, latency: 64, mmio: 0xe8000000 saa7133[0]: subsystem: 1043:4857, board: Philips Tiger reference design [card=81,insmod option] saa7133[0]: board init: gpio is 0
saa7133[0]: i2c eeprom 00: 43 10 57 48 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[0]: i2c eeprom 10: 00 01 20 00 ff 20 ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 20: 01 40 01 02 03 01 01 03 08 ff 00 cb ff ff ff ff saa7133[0]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 40: ff 21 00 c2 96 10 03 32 15 00 ff ff ff ff ff ff saa7133[0]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[0]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
tuner' 2-004b: tda829x detected
tuner' 2-004b: Setting mode_mask to 0x0e
tuner' 2-004b: chip found @ 0x96 (saa7133[0])
tuner' 2-004b: tuner 0x4b: Tuner type absent
tuner' 2-004b: Calling set_type_addr for type=54, addr=0xff, mode=0x0e, config=0x00 tuner' 2-004b: defining GPIO callback
tda829x 2-004b: setting tuner address to 61
tda829x 2-004b: type set to tda8290+75a
tuner' 2-004b: type set to tda8290+75a
tuner' 2-004b: tv freq set to 400.00
tuner' 2-004b: saa7133[0] tuner' I2C addr 0x96 with type 54 used for 0x0e
tuner' 2-004b: switching to v4l2
tuner' 2-004b: tv freq set to 400.00
tuner' 2-004b: tv freq set to 400.00
saa7133[0]: registered device video0 [v4l2]
saa7133[0]: registered device vbi0
saa7133[0]: registered device radio0
tuner' 2-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
saa7133[1]: setting pci latency timer to 64
saa7133[1]: found at 0000:01:08.0, rev: 208, irq: 18, latency: 64, mmio: 0xe8001000 saa7133[1]: subsystem: 1043:4862, board: ASUSTeK P7131 Dual [card=78,autodetected] saa7133[1]: board init: gpio is 0
input: saa7134 IR (ASUSTeK P7131 Dual) as /class/input/input7
tuner' 3-004b: tda829x detected
tuner' 3-004b: Setting mode_mask to 0x0e
tuner' 3-004b: chip found @ 0x96 (saa7133[1])
tuner' 3-004b: tuner 0x4b: Tuner type absent
saa7133[1]: i2c eeprom 00: 43 10 62 48 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[1]: i2c eeprom 10: 00 01 20 00 ff 20 ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 20: 01 40 01 02 03 01 01 03 08 ff 00 d6 ff ff ff ff saa7133[1]: i2c eeprom 30: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 40: ff 21 00 c2 96 10 03 32 15 00 ff ff ff ff ff ff saa7133[1]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[1]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
tuner' 3-004b: Calling set_type_addr for type=54, addr=0xff, mode=0x0e, config=0x00 tuner' 3-004b: defining GPIO callback
tda829x 3-004b: setting tuner address to 61
tda829x 3-004b: type set to tda8290+75a
tuner' 3-004b: type set to tda8290+75a
tuner' 3-004b: tv freq set to 400.00
tuner' 3-004b: saa7133[1] tuner' I2C addr 0x96 with type 54 used for 0x0e
tuner' 3-004b: switching to v4l2
tuner' 3-004b: tv freq set to 400.00
tuner' 3-004b: tv freq set to 400.00
saa7133[1]: registered device video1 [v4l2]
saa7133[1]: registered device vbi1
saa7133[1]: registered device radio1
tuner' 3-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
saa7133[2]: setting pci latency timer to 64
saa7133[2]: found at 0000:01:09.0, rev: 209, irq: 17, latency: 64, mmio: 0xe8002000 saa7133[2]: subsystem: 16be:0010, board: Medion/Creatix CTX953 Hybrid [card=134,autodetected] saa7133[2]: board init: gpio is 0
tuner' 4-004b: tda829x detected
tuner' 4-004b: Setting mode_mask to 0x0e
tuner' 4-004b: chip found @ 0x96 (saa7133[2])
tuner' 4-004b: tuner 0x4b: Tuner type absent
saa7133[2]: i2c eeprom 00: be 16 10 00 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7133[2]: i2c eeprom 10: 00 ff 86 0f ff 20 ff 00 01 50 32 79 01 3c ca 50 saa7133[2]: i2c eeprom 20: 01 40 01 02 02 03 01 00 06 ff 00 2c 02 51 96 2b saa7133[2]: i2c eeprom 30: a7 58 7a 1f 03 8e 84 5e da 7a 04 b3 05 87 b2 3c saa7133[2]: i2c eeprom 40: ff 21 00 c0 96 10 03 22 15 00 fd 79 44 9f c2 8f saa7133[2]: i2c eeprom 50: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7133[2]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
tuner' 4-004b: Calling set_type_addr for type=54, addr=0xff, mode=0x0e, config=0x00 tuner' 4-004b: defining GPIO callback
tda829x 4-004b: setting tuner address to 60
tda829x 4-004b: type set to tda8290+75a
tuner' 4-004b: type set to tda8290+75a
tuner' 4-004b: tv freq set to 400.00
tuner' 4-004b: saa7133[2] tuner' I2C addr 0x96 with type 54 used for 0x0e
tuner' 4-004b: switching to v4l2
tuner' 4-004b: tv freq set to 400.00
tuner' 4-004b: tv freq set to 400.00
saa7133[2]: registered device video2 [v4l2]
saa7133[2]: registered device vbi2
tuner' 4-004b: Cmd TUNER_SET_STANDBY accepted for analog TV
saa7134[3]: setting pci latency timer to 64
saa7134[3]: found at 0000:01:0a.0, rev: 1, irq: 16, latency: 64, mmio: 0xe8003000 saa7134[3]: subsystem: 16be:0003, board: Medion 7134 [card=12,autodetected] saa7134[3]: board init: gpio is 0
tuner' 5-0043: chip found @ 0x86 (saa7134[3])
tda9887 5-0043: creating new instance
tda9887 5-0043: tda988[5/6/7] found
tuner' 5-0043: type set to tda9887
tuner' 5-0043: tv freq set to 0.00
tuner' 5-0043: TV freq (0.00) out of range (44-958)
tuner' 5-0043: saa7134[3] tuner' I2C addr 0x86 with type 74 used for 0x0e
tuner' 5-0061: Setting mode_mask to 0x0e
tuner' 5-0061: chip found @ 0xc2 (saa7134[3])
tuner' 5-0061: tuner 0x61: Tuner type absent
saa7134[3]: i2c eeprom 00: be 16 03 00 54 20 1c 00 43 43 a9 1c 55 d2 b2 92 saa7134[3]: i2c eeprom 10: 00 ff 86 0f ff 20 ff 00 01 50 32 79 01 3c ca 50 saa7134[3]: i2c eeprom 20: 01 40 01 02 02 03 01 00 06 ff 00 1f 02 51 96 2b saa7134[3]: i2c eeprom 30: a7 58 7a 1f 03 8e 84 5e da 7a 04 b3 05 87 b2 3c saa7134[3]: i2c eeprom 40: ff 1d 00 c2 86 10 01 01 00 00 fd 79 44 9f c2 8f saa7134[3]: i2c eeprom 50: ff ff ff ff ff ff 06 06 0f 00 0f 00 0f 00 0f 00 saa7134[3]: i2c eeprom 60: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 70: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom 90: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom a0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom b0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom c0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom d0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom e0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff saa7134[3]: i2c eeprom f0: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
saa7134[3] Board has DVB-T
saa7134[3] Tuner type is 63
tuner' 5-0043: Calling set_type_addr for type=63, addr=0xff, mode=0x0e, config=0x00 tuner' 5-0043: set addr discarded for type 74, mask e. Asked to change tuner at addr 0xff, with mask e tuner' 5-0061: Calling set_type_addr for type=63, addr=0xff, mode=0x0e, config=0x00 tuner' 5-0061: defining GPIO callback
tuner-simple 5-0061: creating new instance
tuner-simple 5-0061: type set to 63 (Philips FMD1216ME MK3 Hybrid Tuner)
tuner-simple 5-0061: tuner 0 atv rf input will be autoselected
tuner-simple 5-0061: tuner 0 dtv rf input will be autoselected
tuner' 5-0061: type set to Philips FMD1216ME M
tuner' 5-0061: tv freq set to 400.00
tuner-simple 5-0061: using tuner params #0 (pal)
tuner-simple 5-0061: freq = 400.00 (6400), range = 1, config = 0x86, cb = 0x52 tuner-simple 5-0061: Freq= 400.00 MHz, V_IF=38.93 MHz, Offset=0.00 MHz, div=7023 tuner-simple 5-0061: tv 0x1b 0x6f 0x86 0x52
tuner' 5-0061: saa7134[3] tuner' I2C addr 0xc2 with type 63 used for 0x0e
tuner' 5-0043: switching to v4l2
tuner' 5-0061: switching to v4l2
tuner' 5-0061: tv freq set to 400.00
tuner-simple 5-0061: using tuner params #0 (pal)
tuner-simple 5-0061: freq = 400.00 (6400), range = 1, config = 0x86, cb = 0x52 tuner-simple 5-0061: Freq= 400.00 MHz, V_IF=38.93 MHz, Offset=0.00 MHz, div=7023 tuner-simple 5-0061: tv 0x1b 0x6f 0x86 0x52
tuner' 5-0061: tv freq set to 400.00
tuner-simple 5-0061: using tuner params #0 (pal)
tuner-simple 5-0061: freq = 400.00 (6400), range = 1, config = 0x86, cb = 0x52 tuner-simple 5-0061: Freq= 400.00 MHz, V_IF=38.93 MHz, Offset=0.00 MHz, div=7023 tuner-simple 5-0061: tv 0x1b 0x6f 0x86 0x52
saa7134[3]: registered device video3 [v4l2]
saa7134[3]: registered device vbi3
saa7134[3]: registered device radio2
tuner' 5-0043: Cmd TUNER_SET_STANDBY accepted for analog TV
tuner' 5-0061: Cmd TUNER_SET_STANDBY accepted for analog TV
DVB: registering new adapter (saa7133[0])
DVB: registering frontend 0 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 29 -- ok
DVB: registering new adapter (saa7133[1])
DVB: registering frontend 1 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 29 -- ok
DVB: registering new adapter (saa7133[2])
DVB: registering frontend 2 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 48MHz sampling clock
tda1004x: found firmware revision 26 -- ok
tuner-simple 5-0061: attaching existing instance
tuner-simple 5-0061: type set to 63 (Philips FMD1216ME MK3 Hybrid Tuner)
tuner-simple 5-0061: tuner 0 atv rf input will be autoselected
tuner-simple 5-0061: tuner 0 dtv rf input will be autoselected
DVB: registering new adapter (saa7134[3])
DVB: registering frontend 3 (Philips TDA10046H DVB-T)...
tda1004x: setting up plls for 53MHz sampling clock
tda1004x: found firmware revision 26 -- ok

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Hi, Hermann, Mauro

Hermann is right, SNAKE has no analog tuner. These boards indeed share the same PCI ID, This code fragment reads the tuner ID from the eeprom to find out which board is there.

Aha! I modified my board that it no longer runs with the current driver. But i observed something similar

<snip>
Don't have the time today, but lets roll back history: Not absolutely sure but if i remember correcly, the initialization sequence can be critical with hybrid tuners / NIM modules. The tda9887 may only be visible on I2C after a certain bit in the MOPLL is set (in byte4?)

Best regards
Hartmut

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Am Sonntag, den 27.04.2008, 23:18 +0200 schrieb Hartmut Hackmann:

Hi Hartmut,

I remember this exactly, getting older anyway, but you had no chance coming in with that on a quickly changing target, finally all of us shot down as a crowd of lamers, a cheap target for kernel masterminds, claiming we don't had anything in the right place ...

Let them pay for it now :)

Cheers,
Hermann

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

If this is the case, we need to initialize the bit at init1, otherwise, this won't work.

Another option is to migrate saa7134 to the newer i2c probing methods, and let tuner be probed after init2.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

In this case, it would be better to do:

	dev->tda9887_conf = saa7134_boards[dev->board].tda9887_conf;

for SNAKE. This won't produce any effect, but will avoid the overhead of sending tda9887 config commands for a device that doesn't have it.

Later, maybe we can just move the above to the setup tuner subroutine.

We need to fix this. The previous "hacks" like this now stops working.

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Ok, this is a cx88 version. Of course, needs testing.

diff -r 5c9a4decb57b linux/drivers/media/video/cx88/cx88-cards.c
@@ -2495,26 +2495,27 @@
 
 static void cx88_card_setup(struct cx88_core *core)
 {
+	int need_init_tuner = 1;
 	static u8 eeprom[256];
 
 	if (0 == core->i2c_rc) {
 		core->i2c_client.addr = 0xa0 >> 1;
-		tveeprom_read(&core->i2c_client,eeprom,sizeof(eeprom));
+		tveeprom_read(&core->i2c_client, eeprom, sizeof(eeprom));
 	}
 
 	switch (core->boardnr) {
 	case CX88_BOARD_HAUPPAUGE:
 	case CX88_BOARD_HAUPPAUGE_ROSLYN:
 		if (0 == core->i2c_rc)
-			hauppauge_eeprom(core,eeprom+8);
+			hauppauge_eeprom(core, eeprom+8);
 		break;
 	case CX88_BOARD_GDI:
 		if (0 == core->i2c_rc)
-			gdi_eeprom(core,eeprom);
+			gdi_eeprom(core, eeprom);
 		break;
 	case CX88_BOARD_WINFAST2000XP_EXPERT:
 		if (0 == core->i2c_rc)
-			leadtek_eeprom(core,eeprom);
+			leadtek_eeprom(core, eeprom);
 		break;
 	case CX88_BOARD_HAUPPAUGE_NOVASPLUS_S1:
 	case CX88_BOARD_HAUPPAUGE_NOVASE2_S1:

@@ -2524,7 +2525,7 @@
 	case CX88_BOARD_HAUPPAUGE_HVR3000:
 	case CX88_BOARD_HAUPPAUGE_HVR1300:
 		if (0 == core->i2c_rc)
-			hauppauge_eeprom(core,eeprom);
+			hauppauge_eeprom(core, eeprom);
 		break;
 	case CX88_BOARD_KWORLD_DVBS_100:
 		cx_write(MO_GP0_IO, 0x000007f8);

@@ -2605,6 +2606,20 @@
 
 		cx88_call_i2c_clients(core, TUNER_SET_CONFIG, &tea5767_cfg);
 	}
+	default:
+		need_init_tuner = 0;
+	}
+
+	if (need_init_tuner && core->board.tuner_type != TUNER_ABSENT) {
+		struct tuner_setup tun_setup;
+
+		memset (&tun_setup, 0, sizeof(tun_setup));
+
+	        tun_setup.tuner_callback = cx88_tuner_callback;
+	        tun_setup.mode_mask = T_RADIO     |
+        	                      T_ANALOG_TV |
+                	              T_DIGITAL_TV;
+		cx88_call_i2c_clients(core, TUNER_SET_TYPE_ADDR, &tun_setup);
 	}
 
 	if (core->board.tuner_type == TUNER_XC2028) {

@@ -2622,6 +2637,7 @@
 			    ctl.fname);
 		cx88_call_i2c_clients(core, TUNER_SET_CONFIG, &xc2028_cfg);
 	}
+
 }
 
 /* ------------------------------------------------------------------ */

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

The following quick and dirty patch fixes the problem for me:

@@ -2197,12 +2197,13 @@
       cx88_card_setup_pre_i2c(core);
       cx88_i2c_init(core, pci);
 
+       cx88_card_setup(core);
+
       /* load tuner module, if needed */
       if (TUNER_ABSENT != core->board.tuner_type)
               request_module("tuner");
 
       cx88_call_i2c_clients (core, TUNER_SET_STANDBY, NULL);
-       cx88_card_setup(core);
       cx88_ir_init(core, pci);
 
       return core;

It makes sure that cx88_card_setup(), which reads the eeprom, is run before the tuner modules is loaded.

Gert

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Yes, now correctly sets the tuner type:

cx88/0: cx2388x v4l2 driver version 0.0.6 loaded
ACPI: PCI Interrupt 0000:00:0a.0[A] -> GSI 18 (level, low) -> IRQ 18 cx88[0]: subsystem: 107d:6611, board: Leadtek Winfast 2000XP Expert [card=5,autodetected] cx88[0]: TV tuner type 44, Radio tuner type -1
tuner' 4-0043: chip found @ 0x86 (cx88[0])
tda9887 4-0043: creating new instance
tda9887 4-0043: tda988[5/6/7] found
All bytes are equal. It is not a TEA5767
tuner' 4-0060: chip found @ 0xc0 (cx88[0])
cx88[0]: Leadtek Winfast 2000XP Expert config: tuner=38, eeprom[0]=0x01 tuner-simple 4-0060: creating new instance
tuner-simple 4-0060: type set to 38 (Philips PAL/SECAM multi (FM1216ME MK3))
input: cx88 IR (Leadtek Winfast 2000XP as /class/input/input6
cx88[0]/0: found at 0000:00:0a.0, rev: 5, irq: 18, latency: 32, mmio: 0xe2000000 cx88[0]/0: registered device video0 [v4l2]
cx88[0]/0: registered device vbi0
cx88[0]/0: registered device radio0

Gert

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Hi Gert/Ian,

Do you like to add your reviewed-by: tag for this patch?

Cheers,
Mauro

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

Gert

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list