Skip to contentSkip to conversation

annotate a few functions __init in ipconfig.c

PATCH Applied Sam Ravnborg 2 participants 2 messages Apr 29, 2008 – Apr 30, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 annotate a few functions __init in ipconfig.c

A few functions are only used from __init context. So annotate these with __init for consistency and silence the following warnings:

WARNING: net/ipv4/built-in.o(.text+0x2a876): Section mismatch
in reference from the function ic_bootp_init() to the variable .init.data:bootp_packet_type
WARNING: net/ipv4/built-in.o(.text+0x2a907): Section mismatch
in reference from the function ic_bootp_cleanup() to the variable .init.data:bootp_packet_type

Note: The warnings only appear with CONFIG_DEBUG_SECTION_MISMATCH=y

---

Build testet only - but trivial.

net/ipv4/ipconfig.c +4 -4
index 0f42d1c..89dee43 100644
@@ -412,12 +412,12 @@ static struct packet_type rarp_packet_type __initdata = {
 	.func =	ic_rarp_recv,
 };
 
-static inline void ic_rarp_init(void)
+static inline void __init ic_rarp_init(void)
 {
 	dev_add_pack(&rarp_packet_type);
 }
 
-static inline void ic_rarp_cleanup(void)
+static inline void __init ic_rarp_cleanup(void)
 {
 	dev_remove_pack(&rarp_packet_type);
 }
@@ -682,7 +682,7 @@ static void __init ic_bootp_init_ext(u8 *e)
 /*
  *  Initialize the DHCP/BOOTP mechanism.
  */
-static inline void ic_bootp_init(void)
+static inline void __init ic_bootp_init(void)
 {
 	int i;
 
@@ -696,7 +696,7 @@ static inline void ic_bootp_init(void)
 /*
  *  DHCP/BOOTP cleanup.
  */
-static inline void ic_bootp_cleanup(void)
+static inline void __init ic_bootp_cleanup(void)
 {
 	dev_remove_pack(&bootp_packet_type);
 }
maintainer Applied
#1 lore raw

From: Sam Ravnborg <[email protected]>
Date: Tue, 29 Apr 2008 21:50:06 +0200

Quoted 11 lines

A few functions are only used from __init context. So annotate these with __init for consistency and silence the following warnings:

WARNING: net/ipv4/built-in.o(.text+0x2a876): Section mismatch
in reference from the function ic_bootp_init() to the variable .init.data:bootp_packet_type
WARNING: net/ipv4/built-in.o(.text+0x2a907): Section mismatch
in reference from the function ic_bootp_cleanup() to the variable .init.data:bootp_packet_type

Quoted 3 lines

Note: The warnings only appear with CONFIG_DEBUG_SECTION_MISMATCH=y

Applied, thanks a lot Sam.