Skip to contentSkip to conversation

nfsd: remove unnecessary atomic ops

PATCH New J. Bruce Fields 1 participant 1 message Apr 29, 2008

Subsystems (2)
NFS client NFS server
lore
Share & tools
lore

J. Bruce Fields

author
#0 lore raw

PATCH 1/1 nfsd: remove unnecessary atomic ops

From: J. Bruce Fields <[email protected]>

These bit operations don't need to be atomic. They're all done under a single big mutex anyway.

Signed-off-by J. Bruce Fields <[email protected]>
---
 fs/nfsd/nfs4state.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

I'm queuing this up for 2.6.26.

--b.

fs/nfsd/nfs4state.c +2 -2
index 8799b87..5c97d47 100644
@@ -1579,8 +1579,8 @@ nfs4_upgrade_open(struct svc_rqst *rqstp, struct svc_fh *cur_fh, struct nfs4_sta
 	}
 	/* remember the open */
 	filp->f_mode |= open->op_share_access;
-	set_bit(open->op_share_access, &stp->st_access_bmap);
-	set_bit(open->op_share_deny, &stp->st_deny_bmap);
+	__set_bit(open->op_share_access, &stp->st_access_bmap);
+	__set_bit(open->op_share_deny, &stp->st_deny_bmap);
 
 	return nfs_ok;
 }
Signature · 1 line
1.5.5.rc1