Skip to contentSkip to conversation

rtc_valid_tm doesn't check tm_wday

DISCUSSION Uwe Kleine-König 2 participants 3 messages Apr 29, 2008

lore
Share & tools
lore
#0 lore raw

Hello,

I'm currently writing an rtc driver and want to use rtc_valid_tm to assert to have a valid date before writing it to the rtc.

Now I wonder why rtc_valid_tm doesn't check tm_wday for being in the range [0 .. 6]. Is there a reason? I could imagine that you want to be able to check paritial "struct rtc_time"s, too.

So should I check tm_wday myself?

Best regards
Uwe

Signature · 3 lines
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
#1 lore raw
Quoted 7 lines · Uwe Kleine-König

Hello,

I'm currently writing an rtc driver and want to use rtc_valid_tm to assert to have a valid date before writing it to the rtc.

Now I wonder why rtc_valid_tm doesn't check tm_wday for being in the range [0 .. 6]. Is there a reason?

As far as I know, the kernel doesn't use tm_wday, tm_yday, or tm_isdst ... so none of those fields are expected to be valid. See the rtc(4) manpage.

- Dave

#2 lore raw

Hello Dave,

Quoted 6 lines · David Brownell
Quoted 5 lines · Uwe Kleine-König

Hello,

I'm currently writing an rtc driver and want to use rtc_valid_tm to assert to have a valid date before writing it to the rtc.

Quoted 6 lines
Quoted 2 lines

Now I wonder why rtc_valid_tm doesn't check tm_wday for being in the range [0 .. 6]. Is there a reason?

As far as I know, the kernel doesn't use tm_wday, tm_yday, or tm_isdst ... so none of those fields are expected to be valid. See the rtc(4) manpage.

Thanks.

I still want to write the correct value to the rtc, so I will assert dirctly in the driver that it's valid.

Best regards,
Uwe

Signature · 3 lines
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962