Skip to contentSkip to conversation

x86: use defconfigs from x86/configs/*

PATCH In review Sam Ravnborg 2 participants 2 messages Apr 29, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: use defconfigs from x86/configs/*

Daniel Drake <[email protected]> reported:

In 2.6.23, if you unpacked a kernel source tarball and then ran "make menuconfig" you'd be presented with this message:

    # using defaults found in arch/i386/defconfig

and the default options would be set.

The same thing in 2.6.24 does not give you any "using defaults" message, and the default config options within menuconfig are rather blank (e.g. no PCI support). You can work around this by explicitly running "make defconfig" before menuconfig, but it would be nice to have the behaviour the way it was for 2.6.23 (and the way it still is for other archs).

Fixed by adding a x86 specific defconfig list to Kconfig.

---

arch/x86/Kconfig +12 -0
index a12dbb2..91df357 100644
@@ -25,6 +25,18 @@ config X86
 	select HAVE_KVM if ((X86_32 && !X86_VOYAGER && !X86_VISWS && !X86_NUMAQ) || X86_64)
 	select HAVE_ARCH_KGDB if !X86_VOYAGER
 
+config DEFCONFIG_LIST
+        string
+	depends on X86_32
+        option defconfig_list
+        default "arch/x86/configs/i386_defconfig"
+
+config DEFCONFIG_LIST
+        string
+	depends on X86_64
+        option defconfig_list
+        default "arch/x86/configs/x86_64_defconfig"
+
 
 config GENERIC_LOCKBREAK
 	def_bool n
#1 lore raw
Quoted 8 lines · Sam Ravnborg

Daniel Drake <[email protected]> reported:

In 2.6.23, if you unpacked a kernel source tarball and then ran "make menuconfig" you'd be presented with this message:

    # using defaults found in arch/i386/defconfig

and the default options would be set.

Quoted 8 lines

The same thing in 2.6.24 does not give you any "using defaults" message, and the default config options within menuconfig are rather blank (e.g. no PCI support). You can work around this by explicitly running "make defconfig" before menuconfig, but it would be nice to have the behaviour the way it was for 2.6.23 (and the way it still is for other archs).

Fixed by adding a x86 specific defconfig list to Kconfig.

thanks Sam, applied.

Ingo