Skip to contentSkip to conversation

make access_process_vm work on device memory

PATCH In review Rik van Riel 3 participants 6 messages Apr 29, 2008

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 make access_process_vm work on device memory

Make access_process_vm work on VM_IO or VM_PFNMAP VMAs. This allows ptrace and /proc/pid/mem access to work on eg. video card memory mapped by the X server and lays the groundwork for gdb support for PPC Cell SPU memory.

---

 arch/x86/mm/ioremap.c   |    8 ++
 include/asm-x86/io_32.h |    3 +
 include/asm-x86/io_64.h |    3 +
 include/linux/mm.h      |    6 ++
 mm/memory.c             |  134 +++++++++++++++++++++++++++++++++++++++++-------
 5 files changed, 136 insertions(+), 18 deletions(-)
mm/memory.c +116 -18
Index: linux-2.6.25-mm1/mm/memory.c
===================================================================
@@ -2720,6 +2720,86 @@ int in_gate_area_no_task(unsigned long a
 
 #endif	/* __HAVE_ARCH_GATE_AREA */
 
+#ifdef _HAVE_ARCH_IOREMAP_PROT
+static resource_size_t follow_phys(struct vm_area_struct *vma,
+			unsigned long address, unsigned int flags,
+			unsigned long *prot)
+{
+	pgd_t *pgd;
+	pud_t *pud;
+	pmd_t *pmd;
+	pte_t *ptep, pte;
+	spinlock_t *ptl;
+	resource_size_t phys_addr = 0;
+	struct mm_struct *mm = vma->vm_mm;
+
+	VM_BUG_ON(!(vma->vm_flags & (VM_IO | VM_PFNMAP)));
+
+	pgd = pgd_offset(mm, address);
+	if (pgd_none(*pgd) || unlikely(pgd_bad(*pgd)))
+		goto no_page_table;
+
+	pud = pud_offset(pgd, address);
+	if (pud_none(*pud) || unlikely(pud_bad(*pud)))
+		goto no_page_table;
+
+	pmd = pmd_offset(pud, address);
+	if (pmd_none(*pmd) || unlikely(pmd_bad(*pmd)))
+		goto no_page_table;
+
+	/* We cannot handle huge page PFN maps. Luckily they don't exist. */
+	if (pmd_huge(*pmd))
+		goto no_page_table;
+
+	ptep = pte_offset_map_lock(mm, pmd, address, &ptl);
+	if (!ptep)
+		goto out;
+
+	pte = *ptep;
+	if (!pte_present(pte))
+		goto unlock;
+	if ((flags & FOLL_WRITE) && !pte_write(pte))
+		goto unlock;
+	phys_addr = pte_pfn(pte);
+	phys_addr <<= PAGE_SHIFT; /* Shift here to avoid overflow on PAE? */
+
+	*prot = pgprot_val(pte_pgprot(pte));
+
+unlock:
+	pte_unmap_unlock(ptep, ptl);
+out:
+	return phys_addr;
+no_page_table:
+	return 0;
+}
+
+int generic_access_phys(struct vm_area_struct *vma, unsigned long addr,
+			void *buf, int len, int write)
+{
+	resource_size_t phys_addr;
+	unsigned long prot = 0;
+	void *maddr;
+	int offset = addr & (PAGE_SIZE-1);
+
+	if (!(vma->vm_flags & (VM_IO | VM_PFNMAP)))
+		return -EINVAL;
+
+	phys_addr = follow_phys(vma, addr, write, &prot);
+
+	if (!phys_addr)
+		return -EINVAL;
+
+	maddr = ioremap_prot(phys_addr, PAGE_SIZE, prot);
+	if (write)
+		memcpy_toio(maddr + offset, buf, len);
+	else
+		memcpy_fromio(buf, maddr + offset, len);
+	iounmap(maddr);
+
+	return len;
+}
+#endif
+
 /*
  * Access another process' address space.
  * Source/target buffer must be kernel space,
@@ -2729,7 +2809,6 @@ int access_process_vm(struct task_struct
 {
 	struct mm_struct *mm;
 	struct vm_area_struct *vma;
-	struct page *page;
 	void *old_buf = buf;
 
 	mm = get_task_mm(tsk);
@@ -2741,28 +2820,47 @@ int access_process_vm(struct task_struct
 	while (len) {
 		int bytes, ret, offset;
 		void *maddr;
+		struct page *page = NULL;
 
 		ret = get_user_pages(tsk, mm, addr, 1,
 				write, 1, &page, &vma);
-		if (ret <= 0)
-			break;
-
-		bytes = len;
-		offset = addr & (PAGE_SIZE-1);
-		if (bytes > PAGE_SIZE-offset)
-			bytes = PAGE_SIZE-offset;
-
-		maddr = kmap(page);
-		if (write) {
-			copy_to_user_page(vma, page, addr,
-					  maddr + offset, buf, bytes);
-			set_page_dirty_lock(page);
+		if (ret <= 0) {
+			/*
+			 * Check if this is a VM_IO | VM_PFNMAP VMA, which
+			 * we can access using slightly different code.
+			 */
+#ifdef _HAVE_ARCH_IOREMAP_PROT
+			vma = find_vma(mm, addr);
+			if (!vma)
+				break;
+			if (vma->vm_ops && vma->vm_ops->access)
+				ret = vma->vm_ops->access(vma, addr, buf,
+							  len, write);
+			else
+				ret = generic_access_phys(vma, addr, buf,
+							  len, write);
+			if (ret <= 0)
+#endif
+				break;
+			bytes = ret;
 		} else {
-			copy_from_user_page(vma, page, addr,
-					    buf, maddr + offset, bytes);
+			bytes = len;
+			offset = addr & (PAGE_SIZE-1);
+			if (bytes > PAGE_SIZE-offset)
+				bytes = PAGE_SIZE-offset;
+
+			maddr = kmap(page);
+			if (write) {
+				copy_to_user_page(vma, page, addr,
+						  maddr + offset, buf, bytes);
+				set_page_dirty_lock(page);
+			} else {
+				copy_from_user_page(vma, page, addr,
+						    buf, maddr + offset, bytes);
+			}
+			kunmap(page);
+			page_cache_release(page);
 		}
-		kunmap(page);
-		page_cache_release(page);
 		len -= bytes;
 		buf += bytes;
 		addr += bytes;
arch/x86/mm/ioremap.c +8 -0
Index: linux-2.6.25-mm1/arch/x86/mm/ioremap.c
===================================================================
@@ -287,6 +287,14 @@ void __iomem *ioremap_cache(resource_siz
 }
 EXPORT_SYMBOL(ioremap_cache);
 
+void __iomem *ioremap_prot(resource_size_t phys_addr, unsigned long size,
+				unsigned long prot_val)
+{
+	return __ioremap_caller(phys_addr, size, (prot_val & _PAGE_CACHE_MASK),
+				__builtin_return_address(0));
+}
+EXPORT_SYMBOL(ioremap_prot);
+
 /**
  * iounmap - Free a IO remapping
  * @addr: virtual address from ioremap_*
include/asm-x86/io_32.h +3 -0
Index: linux-2.6.25-mm1/include/asm-x86/io_32.h
===================================================================
@@ -110,6 +110,9 @@ static inline void *phys_to_virt(unsigne
  */
 extern void __iomem *ioremap_nocache(resource_size_t offset, unsigned long size);
 extern void __iomem *ioremap_cache(resource_size_t offset, unsigned long size);
+extern void __iomem *ioremap_prot(resource_size_t offset, unsigned long size,
+				unsigned long prot_val);
+#define _HAVE_ARCH_IOREMAP_PROT
 
 /*
  * The default ioremap() behavior is non-cached:
include/asm-x86/io_64.h +3 -0
Index: linux-2.6.25-mm1/include/asm-x86/io_64.h
===================================================================
@@ -175,6 +175,9 @@ extern void early_iounmap(void *addr, un
  */
 extern void __iomem *ioremap_nocache(resource_size_t offset, unsigned long size);
 extern void __iomem *ioremap_cache(resource_size_t offset, unsigned long size);
+extern void __iomem *ioremap_prot(resource_size_t offset, unsigned long size,
+				unsigned long prot_val);
+#define _HAVE_ARCH_IOREMAP_PROT
 
 /*
  * The default ioremap() behavior is non-cached:
include/linux/mm.h +6 -0
Index: linux-2.6.25-mm1/include/linux/mm.h
===================================================================
@@ -171,6 +171,12 @@ struct vm_operations_struct {
 	/* notification that a previously read-only page is about to become
 	 * writable, if an error is returned it will cause a SIGBUS */
 	int (*page_mkwrite)(struct vm_area_struct *vma, struct page *page);
+
+	/* called by access_process_vm when get_user_pages() fails, typically
+	 * for use by special VMAs that can switch between memory and hardware
+	 */
+	int (*access)(struct vm_area_struct *vma, unsigned long addr,
+		      void *buf, int len, int write);
 #ifdef CONFIG_NUMA
 	/*
 	 * set_policy() op must add a reference to any non-NULL @new mempolicy
maintainer
#1 lore raw
Quoted 7 lines · On Tue, 29 Apr 2008 11:32:37 -0400 Rik van Riel <[email protected]> wrote:

Make access_process_vm work on VM_IO or VM_PFNMAP VMAs. This allows ptrace and /proc/pid/mem access to work on eg. video card memory mapped by the X server and lays the groundwork for gdb support for PPC Cell SPU memory.

Quoted 7 lines

---

 arch/x86/mm/ioremap.c   |    8 ++
 include/asm-x86/io_32.h |    3 +
 include/asm-x86/io_64.h |    3 +
 include/linux/mm.h      |    6 ++
 mm/memory.c             |  134 +++++++++++++++++++++++++++++++++++++++++-------

I'll consider this an MM patch, to be mastered in -mm. If agreeable, x86 review-and-acks would be nice, please.

mm/memory.c int in_gate_area_no_task(unsigned long a · line 2723

Quoted 10 lines

Index: linux-2.6.25-mm1/mm/memory.c
===================================================================

mm/memory.c +1 -0
@@ -2720,6 +2720,86 @@ int in_gate_area_no_task(unsigned long a
 
 #endif	/* __HAVE_ARCH_GATE_AREA */
 
+#ifdef _HAVE_ARCH_IOREMAP_PROT

urgh.

We have HAVE_ARCH*
We have __HAVE_ARCH*
We have ARCH_HAS*
We have __ARCH_HAS*

what a mess.

Probably the preferred (but still ugly) approach is to implement CONFIG_ARCH_*.

Quoted 23 lines
mm/memory.c +23 -0
+static resource_size_t follow_phys(struct vm_area_struct *vma,
+			unsigned long address, unsigned int flags,
+			unsigned long *prot)
+{
+	pgd_t *pgd;
+	pud_t *pud;
+	pmd_t *pmd;
+	pte_t *ptep, pte;
+	spinlock_t *ptl;
+	resource_size_t phys_addr = 0;
+	struct mm_struct *mm = vma->vm_mm;
+
+	VM_BUG_ON(!(vma->vm_flags & (VM_IO | VM_PFNMAP)));
+
+	pgd = pgd_offset(mm, address);
+	if (pgd_none(*pgd) || unlikely(pgd_bad(*pgd)))
+		goto no_page_table;
+
+	pud = pud_offset(pgd, address);
+	if (pud_none(*pud) || unlikely(pud_bad(*pud)))
+		goto no_page_table;
+
+	pmd = pmd_offset(pud, address);

mm/memory.c int in_gate_area_no_task(unsigned long a · line 2756

Quoted 10 lines
mm/memory.c +10 -0
+	if (pmd_none(*pmd) || unlikely(pmd_bad(*pmd)))
+		goto no_page_table;
+
+	/* We cannot handle huge page PFN maps. Luckily they don't exist. */
+	if (pmd_huge(*pmd))
+		goto no_page_table;
+
+	ptep = pte_offset_map_lock(mm, pmd, address, &ptl);
+	if (!ptep)
+		goto out;

hm, more copy-n-paste.

mm/memory.c int in_gate_area_no_task(unsigned long a · line 2764

Quoted 7 lines
mm/memory.c +7 -0
+	pte = *ptep;
+	if (!pte_present(pte))
+		goto unlock;
+	if ((flags & FOLL_WRITE) && !pte_write(pte))
+		goto unlock;
+	phys_addr = pte_pfn(pte);
+	phys_addr <<= PAGE_SHIFT; /* Shift here to avoid overflow on PAE? */

That comment betrays a lack of confidence ;)

What's the score here?

Quoted 74 lines
mm/memory.c +43 -14
+	*prot = pgprot_val(pte_pgprot(pte));
+
+unlock:
+	pte_unmap_unlock(ptep, ptl);
+out:
+	return phys_addr;
+no_page_table:
+	return 0;
+}
+
+int generic_access_phys(struct vm_area_struct *vma, unsigned long addr,
+			void *buf, int len, int write)
+{
+	resource_size_t phys_addr;
+	unsigned long prot = 0;
+	void *maddr;
+	int offset = addr & (PAGE_SIZE-1);
+
+	if (!(vma->vm_flags & (VM_IO | VM_PFNMAP)))
+		return -EINVAL;
+
+	phys_addr = follow_phys(vma, addr, write, &prot);
+
+	if (!phys_addr)
+		return -EINVAL;
+
+	maddr = ioremap_prot(phys_addr, PAGE_SIZE, prot);
+	if (write)
+		memcpy_toio(maddr + offset, buf, len);
+	else
+		memcpy_fromio(buf, maddr + offset, len);
+	iounmap(maddr);
+
+	return len;
+}
+#endif
+
 /*
  * Access another process' address space.
  * Source/target buffer must be kernel space,
@@ -2729,7 +2809,6 @@ int access_process_vm(struct task_struct
 {
 	struct mm_struct *mm;
 	struct vm_area_struct *vma;
-	struct page *page;
 	void *old_buf = buf;
 
 	mm = get_task_mm(tsk);
@@ -2741,28 +2820,47 @@ int access_process_vm(struct task_struct
 	while (len) {
 		int bytes, ret, offset;
 		void *maddr;
+		struct page *page = NULL;
 
 		ret = get_user_pages(tsk, mm, addr, 1,
 				write, 1, &page, &vma);
-		if (ret <= 0)
-			break;
-
-		bytes = len;
-		offset = addr & (PAGE_SIZE-1);
-		if (bytes > PAGE_SIZE-offset)
-			bytes = PAGE_SIZE-offset;
-
-		maddr = kmap(page);
-		if (write) {
-			copy_to_user_page(vma, page, addr,
-					  maddr + offset, buf, bytes);
-			set_page_dirty_lock(page);
+		if (ret <= 0) {
+			/*
+			 * Check if this is a VM_IO | VM_PFNMAP VMA, which
+			 * we can access using slightly different code.
+			 */

mm/memory.c int access_process_vm(struct task_struct · line 2841

Quoted 10 lines
mm/memory.c +10 -0
+#ifdef _HAVE_ARCH_IOREMAP_PROT
+			vma = find_vma(mm, addr);
+			if (!vma)
+				break;
+			if (vma->vm_ops && vma->vm_ops->access)
+				ret = vma->vm_ops->access(vma, addr, buf,
+							  len, write);
+			else
+				ret = generic_access_phys(vma, addr, buf,
+							  len, write);

Should we do it this way, or should we ensure that all suitable vmas have set their ->vm_ops->access to generic_access_phys()?

Quoted 67 lines
mm/memory.c +20 -4
+			if (ret <= 0)
+#endif
+				break;
+			bytes = ret;
 		} else {
-			copy_from_user_page(vma, page, addr,
-					    buf, maddr + offset, bytes);
+			bytes = len;
+			offset = addr & (PAGE_SIZE-1);
+			if (bytes > PAGE_SIZE-offset)
+				bytes = PAGE_SIZE-offset;
+
+			maddr = kmap(page);
+			if (write) {
+				copy_to_user_page(vma, page, addr,
+						  maddr + offset, buf, bytes);
+				set_page_dirty_lock(page);
+			} else {
+				copy_from_user_page(vma, page, addr,
+						    buf, maddr + offset, bytes);
+			}
+			kunmap(page);
+			page_cache_release(page);
 		}
-		kunmap(page);
-		page_cache_release(page);
 		len -= bytes;
 		buf += bytes;
 		addr += bytes;

Index: linux-2.6.25-mm1/arch/x86/mm/ioremap.c
===================================================================

arch/x86/mm/ioremap.c +8 -0
@@ -287,6 +287,14 @@ void __iomem *ioremap_cache(resource_siz
 }
 EXPORT_SYMBOL(ioremap_cache);
 
+void __iomem *ioremap_prot(resource_size_t phys_addr, unsigned long size,
+				unsigned long prot_val)
+{
+	return __ioremap_caller(phys_addr, size, (prot_val & _PAGE_CACHE_MASK),
+				__builtin_return_address(0));
+}
+EXPORT_SYMBOL(ioremap_prot);
+
 /**
  * iounmap - Free a IO remapping
  * @addr: virtual address from ioremap_*

Index: linux-2.6.25-mm1/include/asm-x86/io_32.h
===================================================================

include/asm-x86/io_32.h +3 -0
@@ -110,6 +110,9 @@ static inline void *phys_to_virt(unsigne
  */
 extern void __iomem *ioremap_nocache(resource_size_t offset, unsigned long size);
 extern void __iomem *ioremap_cache(resource_size_t offset, unsigned long size);
+extern void __iomem *ioremap_prot(resource_size_t offset, unsigned long size,
+				unsigned long prot_val);
+#define _HAVE_ARCH_IOREMAP_PROT
 
 /*
  * The default ioremap() behavior is non-cached:

Index: linux-2.6.25-mm1/include/asm-x86/io_64.h
===================================================================

include/asm-x86/io_64.h extern void early_iounmap(void *addr, un · line 180

Quoted 6 lines
include/asm-x86/io_64.h +3 -0
@@ -175,6 +175,9 @@ extern void early_iounmap(void *addr, un
  */
 extern void __iomem *ioremap_nocache(resource_size_t offset, unsigned long size);
 extern void __iomem *ioremap_cache(resource_size_t offset, unsigned long size);
+extern void __iomem *ioremap_prot(resource_size_t offset, unsigned long size,
+				unsigned long prot_val);
+#define _HAVE_ARCH_IOREMAP_PROT

I expect that any architecture which implements ioremap_prot() will have to implement it with the same signature, yes?

So perhaps the declaration should be placed in include/linux/io.h.

Quoted 19 lines
include/asm-x86/io_64.h +0 -0
 /*
  * The default ioremap() behavior is non-cached:

Index: linux-2.6.25-mm1/include/linux/mm.h
===================================================================

include/linux/mm.h +6 -0
@@ -171,6 +171,12 @@ struct vm_operations_struct {
 	/* notification that a previously read-only page is about to become
 	 * writable, if an error is returned it will cause a SIGBUS */
 	int (*page_mkwrite)(struct vm_area_struct *vma, struct page *page);
+
+	/* called by access_process_vm when get_user_pages() fails, typically
+	 * for use by special VMAs that can switch between memory and hardware
+	 */
+	int (*access)(struct vm_area_struct *vma, unsigned long addr,
+		      void *buf, int len, int write);
 #ifdef CONFIG_NUMA
 	/*
 	 * set_policy() op must add a reference to any non-NULL @new mempolicy
#2 lore raw
Quoted 2 lines · On Tue, 29 Apr 2008 11:09:19 -0700 Andrew Morton <[email protected]>…

I'll consider this an MM patch, to be mastered in -mm. If agreeable, x86 review-and-acks would be nice, please.

Sounds good to me. Ben Herrenschmidt has tested this patch on PPC Cell, accessing SPU memory and Adam Jackson has tested it on x86, accessing video memory with gdb attached to an X server.

Considering the recent amount of change in the ioremap code upstream, having this patch live in -mm for a few weeks is probably a good idea.

Quoted 8 lines
Quoted 8 lines

Index: linux-2.6.25-mm1/mm/memory.c
===================================================================

mm/memory.c +0 -0
@@ -2720,6 +2720,86 @@ int in_gate_area_no_task(unsigned long a
 
 #endif	/* __HAVE_ARCH_GATE_AREA */
 
Quoted 8 lines

mm/memory.c int in_gate_area_no_task(unsigned long a · line 2723

Quoted 1 line
mm/memory.c +1 -0
+#ifdef _HAVE_ARCH_IOREMAP_PROT

urgh.

We have HAVE_ARCH*
We have __HAVE_ARCH*
We have ARCH_HAS*
We have __ARCH_HAS*

We already have _HAVE_ARCH* too. I copied the convention from the first definition I ran into.

Quoted 1 line

what a mess.

No kidding.

Quoted 2 lines

Probably the preferred (but still ugly) approach is to implement CONFIG_ARCH_*.

If you feel strongly about having this as CONFIG_ARCH_IOREMAP_PROT I can send you an incremental patch to do things that way. Just let me know.

Quoted 5 lines

mm/memory.c int in_gate_area_no_task(unsigned long a · line 2756

Quoted 3 lines
mm/memory.c +3 -0
+	ptep = pte_offset_map_lock(mm, pmd, address, &ptl);
+	if (!ptep)
+		goto out;

hm, more copy-n-paste.

It's pretty close, yeah. Not quite the same though :(

Quoted 11 lines

mm/memory.c int in_gate_area_no_task(unsigned long a · line 2764

Quoted 7 lines
mm/memory.c +7 -0
+	pte = *ptep;
+	if (!pte_present(pte))
+		goto unlock;
+	if ((flags & FOLL_WRITE) && !pte_write(pte))
+		goto unlock;
+	phys_addr = pte_pfn(pte);
+	phys_addr <<= PAGE_SHIFT; /* Shift here to avoid overflow on PAE? */

That comment betrays a lack of confidence ;)

What's the score here?

On PAE I think that pte_pfn() returns an unsigned long, which cannot be left shifted by PAGE_SHIFT. After assigning that value to a resource_size_t (which is 64 bit on PAE) we can safely do the shift.

I can remove the question mark if you want.

Quoted 12 lines

mm/memory.c extern void early_iounmap(void *addr, un · line 180

Quoted 8 lines
mm/memory.c +4 -0
+++ linux-2.6.25-mm1/include/asm-x86/io_64.h	2008-04-28 21:37:42.000000000 -0400
@@ -175,6 +175,9 @@ extern void early_iounmap(void *addr, un
  */
 extern void __iomem *ioremap_nocache(resource_size_t offset, unsigned long size);
 extern void __iomem *ioremap_cache(resource_size_t offset, unsigned long size);
+extern void __iomem *ioremap_prot(resource_size_t offset, unsigned long size,
+				unsigned long prot_val);
+#define _HAVE_ARCH_IOREMAP_PROT

I expect that any architecture which implements ioremap_prot() will have to implement it with the same signature, yes?

Quoted 1 line

So perhaps the declaration should be placed in include/linux/io.h.

Well, they also need to implement pgprot_val and pte_pgprot. As for the ioremap declarations, I just placed them near the others, none of the function declarations for ioremap() itself are in include/linux/io.h.

Signature · 1 line
All Rights Reversed
#3 lore raw
In reply to Andrew Morton
Quoted 11 lines

urgh.

We have HAVE_ARCH*
We have __HAVE_ARCH*
We have ARCH_HAS*
We have __ARCH_HAS*

what a mess.

Probably the preferred (but still ugly) approach is to implement CONFIG_ARCH_*.

Only if it is a Kconfig symbol.

We have recently started to use 'HAVE_*' for boolean symbols used to select a specific function for one architecture.
See arch/Kconfig for a few samples.

And Documentation/kbuild/kconfig-language.txt for usage hints.

Sam

maintainer
#4 lore raw
Quoted 11 lines · On Tue, 29 Apr 2008 21:01:32 +0200 Sam Ravnborg <[email protected]> wrote:
Quoted 11 lines

urgh.

We have HAVE_ARCH*
We have __HAVE_ARCH*
We have ARCH_HAS*
We have __ARCH_HAS*

what a mess.

Probably the preferred (but still ugly) approach is to implement CONFIG_ARCH_*.

Quoted 8 lines

Only if it is a Kconfig symbol.

We have recently started to use 'HAVE_*' for boolean symbols used to select a specific function for one architecture.
See arch/Kconfig for a few samples.

And Documentation/kbuild/kconfig-language.txt for usage hints.

I think what you're telling us is to use CONFIG_HAVE_IOREMAP_PROT?

#5 lore raw
Quoted 16 lines · Andrew Morton
Quoted 13 lines · On Tue, 29 Apr 2008 21:01:32 +0200 Sam Ravnborg <[email protected]> wrote:
Quoted 11 lines

urgh.

We have HAVE_ARCH*
We have __HAVE_ARCH*
We have ARCH_HAS*
We have __ARCH_HAS*

what a mess.

Probably the preferred (but still ugly) approach is to implement CONFIG_ARCH_*.

Only if it is a Kconfig symbol.

Quoted 8 lines
Quoted 6 lines

We have recently started to use 'HAVE_*' for boolean symbols used to select a specific function for one architecture.
See arch/Kconfig for a few samples.

And Documentation/kbuild/kconfig-language.txt for usage hints.

I think what you're telling us is to use CONFIG_HAVE_IOREMAP_PROT?

I think so. But I just stumbled upon this mail and have not even tried to follow what you discuss.

So yes - if it is a kconfig symbol.
And if it is a bool.
And if it has no dependencies, or we can create a helper with no dependencies - so yes.

Sam