Skip to contentSkip to conversation

ppc4xx: Fix Katmai CFG_MONITOR_LEN

PATCH New Stefan Roese 2 participants 3 messages Apr 29, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Fix Katmai CFG_MONITOR_LEN

---
 include/configs/katmai.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/katmai.h +1 -1
index 122b700..aad28fb 100644
@@ -48,7 +48,7 @@
  * Base addresses -- Note these are effective addresses where the
  * actual resources get mapped (not physical addresses)
  *----------------------------------------------------------------------*/
-#define CFG_MONITOR_LEN		(256 * 1024)	/* Reserve 256 kB for Mon */
+#define CFG_MONITOR_LEN		(384 * 1024)	/* Reserve 384 kB for Mon */
 #define CFG_MALLOC_LEN		(512 * 1024)	/* Reserve 512 kB for malloc */
 
 #define CFG_SDRAM_BASE		0x00000000	/* _must_ be 0		*/
Signature · 1 line
1.5.5.1
#1 lore raw

PATCH 1/1 ppc4xx: Fix Katmai CFG_MONITOR_LEN

Quoted 1 line · In message <[email protected]> you wrote:

...

include/configs/katmai.h line 51

Quoted 2 lines
include/configs/katmai.h +1 -1
-#define CFG_MONITOR_LEN		(256 * 1024)	/* Reserve 256 kB for Mon */
+#define CFG_MONITOR_LEN		(384 * 1024)	/* Reserve 384 kB for Mon */

Hm... maybe we should become defensive and use

#define CFG_MONITOR_LEN (0xFFFFFFFF - CFG_MONITOR_BASE + 1)

instead?

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's certainly  convenient  the  way  the  crime  (or  condition)  of
stupidity   carries   with   it  its  own  punishment,  automatically
admisistered without remorse, pity, or prejudice. :-)
         -- Tom Christiansen in <[email protected]>
#2 lore raw

PATCH 1/1 ppc4xx: Fix Katmai CFG_MONITOR_LEN

Quoted 5 lines · Wolfgang Denk
Quoted 1 line · In message <[email protected]> you wrote:

...

Quoted 8 lines

include/configs/katmai.h line 51

Quoted 2 lines
include/configs/katmai.h +1 -1
-#define CFG_MONITOR_LEN		(256 * 1024)	/* Reserve 256 kB for Mon */
+#define CFG_MONITOR_LEN		(384 * 1024)	/* Reserve 384 kB for Mon */

Hm... maybe we should become defensive and use

#define CFG_MONITOR_LEN (0xFFFFFFFF - CFG_MONITOR_BASE + 1)

instead?

Yep, even better. I'll make the necessary changes.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================