Skip to contentSkip to conversation

fix drivers/media/common/tuners/ build bug

PATCH New Ingo Molnar 1 participant 1 message Apr 30, 2008 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix drivers/media/common/tuners/ build bug

x86.git randconfig testing found a build failure on latest -git:

drivers/built-in.o: In function `set_type':
tuner-core.c:(.text+0x2a9a26): undefined reference to tea5761_attach' tuner-core.c:(.text+0x2a9d05): undefined reference to tda9887_attach' tuner-core.c:(.text+0x2a9d51): undefined reference to xc2028_attach' tuner-core.c:(.text+0x2a9e22): undefined reference to tda829x_attach' tuner-core.c:(.text+0x2a9e3f): undefined reference to microtune_attach' drivers/built-in.o: In function tuner_probe':
tuner-core.c:(.text+0x2aa18a): undefined reference to tda829x_probe' tuner-core.c:(.text+0x2aa302): undefined reference to tea5761_autodetection'

with the following config:

http://redhat.com/~mingo/misc/config-Wed_Apr_30_10_21_40_CEST_2008.bad

the problem is caused by the drivers/media/common/tuners/ subdirectory not being part of the kbuild hierarchy anymore, due to commit 7c91f0624 ("V4L/DVB(7767): Move tuners to common/tuners").

this seems similar to the problem also reported by Mike Galbraith.

---
 drivers/media/common/Makefile |    1 +
 1 file changed, 1 insertion(+)
drivers/media/common/Makefile +1 -0
Index: linux/drivers/media/common/Makefile
===================================================================
@@ -2,6 +2,7 @@ saa7146-objs    := saa7146_i2c.o saa7146
 saa7146_vv-objs := saa7146_fops.o saa7146_video.o saa7146_hlp.o saa7146_vbi.o
 ir-common-objs  := ir-functions.o ir-keymaps.o
 
+obj-y += tuners/
 obj-$(CONFIG_VIDEO_SAA7146) += saa7146.o
 obj-$(CONFIG_VIDEO_SAA7146_VV) += saa7146_vv.o
 obj-$(CONFIG_VIDEO_IR) += ir-common.o