Skip to contentSkip to conversation

spi_bfin5xx use PIO for full duplex, not DMA

PATCH In review David Brownell 2 participants 2 messages Apr 30, 2008 1 message not in the archive SPI

lore
Share & tools
lore

David Brownell

author
#0 lore raw

PATCH 1/1 spi_bfin5xx use PIO for full duplex, not DMA

From: Vitja Makarov <[email protected]>

Use PIO for full-duplex transfers, instead of DMA.

Signed-off-by Vitja Makarov <[email protected]>
Signed-off-by Bryan Wu <[email protected]>
Signed-off-by David Brownell <[email protected]>
---
 drivers/spi/spi_bfin5xx.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/spi/spi_bfin5xx.c +5 -2
@@ -608,6 +608,7 @@ static void pump_transfers(unsigned long
 	u8 width;
 	u16 cr, dma_width, dma_config;
 	u32 tranf_success = 1;
+	u8 full_duplex = 0;
 
 	/* Get current state information */
 	message = drv_data->cur_msg;

@@ -658,6 +659,7 @@ static void pump_transfers(unsigned long
 	}
 
 	if (transfer->rx_buf != NULL) {
+		full_duplex = transfer->tx_buf != NULL;
 		drv_data->rx = transfer->rx_buf;
 		drv_data->rx_end = drv_data->rx + transfer->len;
 		dev_dbg(&drv_data->pdev->dev, "rx_buf is %p, rx_end is %p\n",

@@ -740,7 +742,8 @@ static void pump_transfers(unsigned long
 	 * successful use different way to r/w according to
 	 * drv_data->cur_chip->enable_dma
 	 */
-	if (drv_data->cur_chip->enable_dma && drv_data->len > 6) {
+	if (!full_duplex && drv_data->cur_chip->enable_dma
+				&& drv_data->len > 6) {
 
 		disable_dma(drv_data->dma_channel);
 		clear_dma_irqstat(drv_data->dma_channel);

@@ -828,7 +831,7 @@ static void pump_transfers(unsigned long
 		/* IO mode write then read */
 		dev_dbg(&drv_data->pdev->dev, "doing IO transfer\n");
 
-		if (drv_data->tx != NULL && drv_data->rx != NULL) {
+		if (full_duplex) {
 			/* full duplex mode */
 			BUG_ON((drv_data->tx_end - drv_data->tx) !=
 			       (drv_data->rx_end - drv_data->rx));

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

A message that is not in the archive (sent off-list or not yet received): 200804301547.46579.david-b-yBeKhBN/[email protected]

#2 lore raw

drivers/spi/spi_bfin5xx.c static void pump_transfers(unsigned long · line 611

Quoted 1 line · On Wed, 30 Apr 2008 15:47:46 -0700 David Brownell…
drivers/spi/spi_bfin5xx.c +1 -0
+	u8 full_duplex = 0;

that's a bool ;)

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone