Skip to contentSkip to conversation

Wrong list_lock argument in rose_node seqops

PATCH Applied Bernard Pidoux 2 participants 2 messages Apr 30, 2008 – May 3, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Bernard Pidoux

author
#0 lore raw

PATCH 1/1 Wrong list_lock argument in rose_node seqops

In rose_node_start() as well as in rose_node_stop() __acquires() and spin_lock_bh() were wrongly passing rose_neigh_list_lock instead of rose_node_list_lock arguments.

Signed-off-by Bernard Pidoux <[email protected]>
---
 net/rose/rose_route.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
net/rose/rose_route.c +4 -4
index 5053a53..bd59387 100644
@@ -1066,12 +1066,12 @@ out:
 #ifdef CONFIG_PROC_FS
 
 static void *rose_node_start(struct seq_file *seq, loff_t *pos)
-	__acquires(rose_neigh_list_lock)
+	__acquires(rose_node_list_lock)
 {
 	struct rose_node *rose_node;
 	int i = 1;
 
-	spin_lock_bh(&rose_neigh_list_lock);
+	spin_lock_bh(&rose_node_list_lock);
 	if (*pos == 0)
 		return SEQ_START_TOKEN;
 

@@ -1090,9 +1090,9 @@ static void *rose_node_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void rose_node_stop(struct seq_file *seq, void *v)
-	__releases(rose_neigh_list_lock)
+	__releases(rose_node_list_lock)
 {
-	spin_unlock_bh(&rose_neigh_list_lock);
+	spin_unlock_bh(&rose_node_list_lock);
 }
 
 static int rose_node_show(struct seq_file *seq, void *v)
Signature · 1 line
1.5.5
maintainer Applied
#1 lore raw

From: Bernard Pidoux <[email protected]>
Date: Wed, 30 Apr 2008 22:08:56 +0200

Quoted 5 lines

In rose_node_start() as well as in rose_node_stop() __acquires() and spin_lock_bh() were wrongly passing rose_neigh_list_lock instead of rose_node_list_lock arguments.

Signed-off-by Bernard Pidoux <[email protected]>

Applied, good catch.

Thanks Bernard.