Skip to contentSkip to conversation

v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

PATCH In review Andres Freund 4 participants 7 messages May 1, 2008 – May 2, 2008

Subsystems (2)
Media (V4L/DVB) Maxiradio FM radio receiver driver
lore
Share & tools
lore

Andres Freund

author
#0 lore raw

PATCH 1/1 v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.

Whitout this build fails with unknown macro on
e4c576b911e364737b1bf4f5bfdab1c440713f26

Hopefully I did everything correct, as this is my first usage of git beside checking out. Also its my first patch on lk....

Is an Signed-off-by already appropriate with such an trivial change?

Signed-off-by Andres Freund <[email protected]>
---
 drivers/media/radio/radio-maxiradio.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/drivers/media/radio/radio-maxiradio.c
index 0133ecf..e170fcd 100644

drivers/media/radio/radio-maxiradio.c +1 -0
@@ -34,6 +34,7 @@
 
 
 #include <linux/module.h>
+#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/delay.h>
#1 lore raw
Quoted 7 lines · Andres Freund

Whitout this build fails with unknown macro on
e4c576b911e364737b1bf4f5bfdab1c440713f26

Hopefully I did everything correct, as this is my first usage of git beside checking out. Also its my first patch on lk....

Is an Signed-off-by already appropriate with such an trivial change?

Yes.

Quoted 11 lines
Signed-off-by Andres Freund <[email protected]>
---
 drivers/media/radio/radio-maxiradio.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/media/radio/radio-maxiradio.c +0 -0
index 0133ecf..e170fcd 100644

drivers/media/radio/radio-maxiradio.c line 40

Quoted 7 lines
drivers/media/radio/radio-maxiradio.c +1 -0
@@ -34,6 +34,7 @@
 
 
 #include <linux/module.h>
+#include <linux/version.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/delay.h>

The #include is already there a dozen lines below.

It seems to be missing in another file.

Can you send the error message and your .config?

Thanks
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#2 lore raw

On Thursday 01 May 2008, Adrian Bunk wrote in "Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.":

Quoted 1 line

The #include is already there a dozen lines below.

Hm. Strange.
It fixed a build error for me. Will retest and report back.

Andres

#3 lore raw
Quoted 5 lines · Andres Freund

On Thursday 01 May 2008, Adrian Bunk wrote in "Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.":

Quoted 1 line

The #include is already there a dozen lines below.

Hm. Strange.
It fixed a build error for me. Will retest and report back.

That's why I said:

It seems to be missing in another file.
Can you send the error message and your .config?

Quoted 1 line

Andres

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#4 lore raw

On Thursday 01 May 2008, Adrian Bunk wrote in "Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.":

Quoted 4 lines
Quoted 2 lines

Hm. Strange.
It fixed a build error for me. Will retest and report back.

It seems to be missing in another file.
Can you send the error message and your .config?

Unfortunately no. I overwrote the .config with some other config and I couldnt reproduce the failure so far with a new config.
Sorry

Andres

#5 lore raw
In reply to Andres Freund
Quoted 8 lines · On Thu, 1 May 2008 20:05:41 +0200 Andres Freund <[email protected]> wrote:

Whitout this build fails with unknown macro on
e4c576b911e364737b1bf4f5bfdab1c440713f26

Hopefully I did everything correct, as this is my first usage of git beside checking out. Also its my first patch on lk....

Is an Signed-off-by already appropriate with such an trivial change?

Hi,

maybe the real fix is to remove the use of KERNEL_VERSION in this code??

Greetings,
Arjan van de Ven

#6 lore raw
Quoted 9 lines · Arjan van de Ven
Quoted 6 lines · On Thu, 1 May 2008 20:05:41 +0200 Andres Freund <[email protected]> wrote:

Whitout this build fails with unknown macro on
e4c576b911e364737b1bf4f5bfdab1c440713f26

Hopefully I did everything correct, as this is my first usage of git beside checking out. Also its my first patch on lk....

Quoted 6 lines
Quoted 2 lines

Is an Signed-off-by already appropriate with such an trivial change?

Hi,

maybe the real fix is to remove the use of KERNEL_VERSION in this code??

This is one of the rare cases where the usage of KERNEL_VERSION is valid. This is the code there:

#include <linux/version.h> /* for KERNEL_VERSION MACRO */
#define RADIO_VERSION KERNEL_VERSION(0,7,7)

This macro is required by V4L API to indicate the module version.

One possible solution would be to fork KERNEL_VERSION into something like V4L_VERSION, and replace it on drivers/media/video/* and drivers/media/radio/*.

Yet, I'm not sure if it would be nice to have two macros with the same code.

Signature · 4 lines
Cheers,
Mauro Carvalho Chehab
http://linuxtv.org
[email protected]