Skip to contentSkip to conversation

make quiet suppress parse_chan_pair boot messages

PATCH In review Rob Landley 3 participants 5 messages May 3, 2008 – May 19, 2008 User-mode Linux (UML)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make quiet suppress parse_chan_pair boot messages

From: Rob Landley <[email protected]>

I usually use UML as a better fakeroot, meaning I run it with a command line like "rootfstype=hostfs rw quiet init=/path/to/some_shell_script.sh". In this context, filling the screen with parse_chan_pair error messages which don't actually hurt anything defeats the purpose of "quiet".

The patch turns several KERN_ERR into KERN_WARNING. While I was there, I merged the redundant printk() statements into a function, and added one "else" after a test-for-null that did a printk but didn't do a continue.

---

 arch/um/drivers/chan_kern.c |   31 +++++++++++++++----------------
 arch/um/drivers/line.c      |    4 ++--
 2 files changed, 17 insertions(+), 18 deletions(-)
arch/um/drivers/chan_kern.c +15 -16
diff -r 7c6e2a3db359 arch/um/drivers/chan_kern.c
@@ -10,61 +10,60 @@
 #include "os.h"
 
 #ifdef CONFIG_NOCONFIG_CHAN
+
+static void not_configged_warn(void)
+{
+	printk(KERN_WARNING "Using a channel type which is configured out of "
+	       "UML\n");
+}
+
 static void *not_configged_init(char *str, int device,
 				const struct chan_opts *opts)
 {
-	printk(KERN_ERR "Using a channel type which is configured out of "
-	       "UML\n");
+	not_configged_warn();
 	return NULL;
 }
 
 static int not_configged_open(int input, int output, int primary, void *data,
 			      char **dev_out)
 {
-	printk(KERN_ERR "Using a channel type which is configured out of "
-	       "UML\n");
+	not_configged_warn();
 	return -ENODEV;
 }
 
 static void not_configged_close(int fd, void *data)
 {
-	printk(KERN_ERR "Using a channel type which is configured out of "
-	       "UML\n");
+	not_configged_warn();
 }
 
 static int not_configged_read(int fd, char *c_out, void *data)
 {
-	printk(KERN_ERR "Using a channel type which is configured out of "
-	       "UML\n");
+	not_configged_warn();
 	return -EIO;
 }
 
 static int not_configged_write(int fd, const char *buf, int len, void *data)
 {
-	printk(KERN_ERR "Using a channel type which is configured out of "
-	       "UML\n");
+	not_configged_warn();
 	return -EIO;
 }
 
 static int not_configged_console_write(int fd, const char *buf, int len)
 {
-	printk(KERN_ERR "Using a channel type which is configured out of "
-	       "UML\n");
+	not_configged_warn();
 	return -EIO;
 }
 
 static int not_configged_window_size(int fd, void *data, unsigned short *rows,
 				     unsigned short *cols)
 {
-	printk(KERN_ERR "Using a channel type which is configured out of "
-	       "UML\n");
+	not_configged_warn();
 	return -ENODEV;
 }
 
 static void not_configged_free(void *data)
 {
-	printk(KERN_ERR "Using a channel type which is configured out of "
-	       "UML\n");
+	not_configged_warn();
 }
 
 static const struct chan_ops not_configged_ops = {
arch/um/drivers/line.c +2 -2
diff -r 7c6e2a3db359 arch/um/drivers/line.c
@@ -717,8 +717,8 @@
 		if (line->init_str == NULL)
 			printk(KERN_ERR "lines_init - kstrdup returned NULL\n");
 
-		if (parse_chan_pair(line->init_str, line, i, opts, &error)) {
-			printk(KERN_ERR "parse_chan_pair failed for "
+		else if (parse_chan_pair(line->init_str, line, i, opts, &error)) {
+			printk(KERN_WARNING "parse_chan_pair failed for "
 			       "device %d : %s\n", i, error);
 			line->valid = 0;
 		}
Signature · 12 lines
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
#1 lore raw

arch/um/drivers/chan_kern.c line 17

Quoted 2 lines · Rob Landley
arch/um/drivers/chan_kern.c +2 -0
+	printk(KERN_WARNING "Using a channel type which is configured out of "
+	       "UML\n");

If you would use pr_warning(), it would fit nicely on a single line.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

#2 lore raw
In reply to Rob Landley
Quoted 8 lines · Rob Landley

I usually use UML as a better fakeroot, meaning I run it with a command line like "rootfstype=hostfs rw quiet init=/path/to/some_shell_script.sh". In this context, filling the screen with parse_chan_pair error messages which don't actually hurt anything defeats the purpose of "quiet".

The patch turns several KERN_ERR into KERN_WARNING. While I was there, I merged the redundant printk() statements into a function, and added one "else" after a test-for-null that did a printk but didn't do a continue.

Looks reasonable.

Jeff

Signature · 11 lines
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
#3 lore raw
Quoted 7 lines · On Friday 09 May 2008 10:22:17 Jeff Dike wrote:
Quoted 6 lines · Rob Landley

I usually use UML as a better fakeroot, meaning I run it with a command line like "rootfstype=hostfs rw quiet init=/path/to/some_shell_script.sh". In this context, filling the screen with parse_chan_pair error messages which don't actually hurt anything defeats the purpose of "quiet".

Quoted 5 lines
Quoted 3 lines

The patch turns several KERN_ERR into KERN_WARNING. While I was there, I merged the redundant printk() statements into a function, and added one "else" after a test-for-null that did a printk but didn't do a continue.

Looks reasonable.

Do I have to do anything to follow up, or is it queued to go upstream? (I can redo the printk() with pr_warning(), it's just the original didn't and I didn't change it...)

Rob

Signature · 11 lines
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
#4 lore raw

Re: [uml-devel] [PATCH] make quiet suppress parse_chan_pair boot?messages

Quoted 2 lines · Rob Landley

Do I have to do anything to follow up, or is it queued to go upstream?

It's queued for mainline.

Quoted 3 lines

(I can
redo the printk() with pr_warning(), it's just the original didn't and I didn't change it...)

I made the pr_warning change.

Jeff

Signature · 10 lines
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel