Skip to contentSkip to conversation

x86: remove spew print out about bus to node mapping

PATCH Applied Yinghai Lu 4 participants 4 messages May 4, 2008 – May 5, 2008

Subsystems (2)
x86 PCI
lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw

PATCH 1/1 x86: remove spew print out about bus to node mapping

Jeff Garzik pointed out that is not needed. looks like spam.

Signed-off-by Yinghai Lu <[email protected]>
arch/x86/pci/k8-bus_64.c +0 -8
index ab6d4b1..5c2799c 100644
@@ -504,14 +504,6 @@ static int __init early_fill_mp_bus_info(void)
 		}
 	}
 
-#ifdef CONFIG_NUMA
-	for (i = 0; i < BUS_NR; i++) {
-		node = mp_bus_to_node[i];
-		if (node >= 0)
-			printk(KERN_DEBUG "bus: %02x to node: %02x\n", i, node);
-	}
-#endif
-
 	for (i = 0; i < pci_root_num; i++) {
 		int res_num;
 		int busnum;
Applied
#1 lore raw
Quoted 1 line · Yinghai Lu

Jeff Garzik pointed out that is not needed. looks like spam.

applied, thanks.

Ingo

#2 lore raw
In reply to Yinghai Lu
Quoted 14 lines · Yinghai Lu

Jeff Garzik pointed out that is not needed. looks like spam.

Signed-off-by Yinghai Lu <[email protected]>
arch/x86/pci/k8-bus_64.c +0 -1
index ab6d4b1..5c2799c 100644
@@ -504,14 +504,6 @@ static int __init early_fill_mp_bus_info(void)
 		}
 	}
 
-#ifdef CONFIG_NUMA

arch/x86/pci/k8-bus_64.c static int __init early_fill_mp_bus_info(void) · line 509

Quoted 10 lines
arch/x86/pci/k8-bus_64.c +0 -7
-	for (i = 0; i < BUS_NR; i++) {
-		node = mp_bus_to_node[i];
-		if (node >= 0)
-			printk(KERN_DEBUG "bus: %02x to node: %02x\n", i, node);
-	}
-#endif
-
 	for (i = 0; i < pci_root_num; i++) {
 		int res_num;
 		int busnum;

What about this loop, looks noisy as well ?

Thanks,

tglx

#3 lore raw
Quoted 13 lines · Thomas Gleixner
Quoted 12 lines · Yinghai Lu

Jeff Garzik pointed out that is not needed. looks like spam.

Signed-off-by Yinghai Lu <[email protected]>
arch/x86/pci/k8-bus_64.c +0 -0
index ab6d4b1..5c2799c 100644
@@ -504,14 +504,6 @@ static int __init early_fill_mp_bus_info(void)
              }
      }
Quoted 15 lines

arch/x86/pci/k8-bus_64.c static int __init early_fill_mp_bus_info(void) · line 509

Quoted 12 lines
arch/x86/pci/k8-bus_64.c +0 -8
-#ifdef CONFIG_NUMA
-     for (i = 0; i < BUS_NR; i++) {
-             node = mp_bus_to_node[i];
-             if (node >= 0)
-                     printk(KERN_DEBUG "bus: %02x to node: %02x\n", i, node);
-     }
-#endif
-
      for (i = 0; i < pci_root_num; i++) {
              int res_num;
              int busnum;

What about this loop, looks noisy as well ?

for (i = 0; i < pci_root_num; i++) { ?

it is informative, about node/link to bus range...

YH