Skip to contentSkip to conversation

scsi_dh: remove &rq->cmd access

PATCH New FUJITA Tomonori 1 participant 1 message May 6, 2008 SCSI

lore
Share & tools
lore

FUJITA Tomonori

author
#0 lore raw

PATCH 1/1 scsi_dh: remove &rq->cmd access

This is against scsi-misc, a resend of

http://www.spinics.net/lists/linux-ide/msg22659.html

===
From: FUJITA Tomonori <[email protected]>
Subject: [PATCH] scsi_dh: remove &rq->cmd access

req->cmd was changed from a static array to a pointer. It breaks &rq->cmd access. scsi_dh acessess to &rq->cmd to initiazlize it but blk_get_request does so we can remove such.

Signed-off-by FUJITA Tomonori <[email protected]>
Cc Chandra Seetharaman <[email protected]>
Cc James Bottomley <[email protected]>
---
 drivers/scsi/device_handler/scsi_dh_emc.c   |    1 -
 drivers/scsi/device_handler/scsi_dh_hp_sw.c |    1 -
 drivers/scsi/device_handler/scsi_dh_rdac.c  |    1 -
 3 files changed, 0 insertions(+), 3 deletions(-)
drivers/scsi/device_handler/scsi_dh_emc.c +0 -1
index ed53f14..644e24a 100644
@@ -258,7 +258,6 @@ static struct request *get_req(struct scsi_device *sdev, int cmd)
 		return NULL;
 	}
 
-	memset(&rq->cmd, 0, BLK_MAX_CDB);
 	rq->cmd[0] = cmd;
 	rq->cmd_len = COMMAND_SIZE(rq->cmd[0]);
drivers/scsi/device_handler/scsi_dh_hp_sw.c +0 -1
index 12ceab7..531564f 100644
@@ -91,7 +91,6 @@ static int hp_sw_activate(struct scsi_device *sdev)
 	req->cmd_type = REQ_TYPE_BLOCK_PC;
 	req->cmd_flags |= REQ_FAILFAST;
 	req->cmd_len = COMMAND_SIZE(START_STOP);
-	memset(req->cmd, 0, MAX_COMMAND_SIZE);
 	req->cmd[0] = START_STOP;
 	req->cmd[4] = 1;	/* Start spin cycle */
 	req->timeout = HP_SW_TIMEOUT;
drivers/scsi/device_handler/scsi_dh_rdac.c +0 -1
index 6fff077..9f94942 100644
@@ -214,7 +214,6 @@ static struct request *get_rdac_req(struct scsi_device *sdev,
 		return NULL;
 	}
 
-	memset(&rq->cmd, 0, BLK_MAX_CDB);
 	rq->sense = h->sense;
 	memset(rq->sense, 0, SCSI_SENSE_BUFFERSIZE);
 	rq->sense_len = 0;
Signature · 1 line
1.5.4.2